Re: [PATCH V18 11/14] drm/xe/vram: Check bad_page_reservation policy in fault handler

["Mallesh, Koujalagi" <mallesh.koujalagi@intel.com>]

[-- Attachment #1: Type: text/plain, Size: 1695 bytes --]


On 27-08-2026 08:34 pm, Michal Wajdeczko wrote:
>
> On 8/26/2026 3:51 PM, Tejas Upadhyay wrote:
>> Before reserving a page at a faulting address, check the cached
>> bad_page_reservation policy from xe->ras. If the policy is disabled
>> (logging only), log the corrupted address and return -EOPNOTSUPP so
>> that RAS can report to firmware to drop the address from the SRAM
>> queue without attempting to offline the page.
>>
>> Signed-off-by: Tejas Upadhyay<tejas.upadhyay@intel.com>
>> ---
>>   drivers/gpu/drm/xe/xe_ttm_vram_mgr.c | 6 ++++++
>>   1 file changed, 6 insertions(+)
>>
>> diff --git a/drivers/gpu/drm/xe/xe_ttm_vram_mgr.c b/drivers/gpu/drm/xe/xe_ttm_vram_mgr.c
>> index b2b6c1bd2c55..24d134754265 100644
>> --- a/drivers/gpu/drm/xe/xe_ttm_vram_mgr.c
>> +++ b/drivers/gpu/drm/xe/xe_ttm_vram_mgr.c
>> @@ -864,6 +864,12 @@ int xe_ttm_vram_handle_addr_fault(struct xe_device *xe, u64 addr)
>>   	vram_mgr = &vr->ttm;
>>   	mm = &vram_mgr->mm;
>>   
>> +	if (!xe->ras.bad_page_reservation) {
>> +		drm_err(&xe->drm, "0x%llx is reported as corrupted address by HW\n",
>> +			addr);
> we do have easier to use
>
> 	xe_err(xe, ...)
>
> and also recently added SIGID logs:
>
> 	xe_log_err(xe, ...)
>
> which maybe we should consider here?
> or is it done by the other layer?
>
> @Mallesh ?

Agree with @Michal

Please use SIGID for err logging. xe_ttm_vram_handle_addr_fault() used in

handle_page_offline (https://patchwork.freedesktop.org/series/172710/), 
where all error reporting using SIGID.


Thanks,

-/Mallesh

>> +		return -EOPNOTSUPP;
>> +	}
>> +
>>   	/* Reserve page at address */
>>   	return xe_ttm_vram_reserve_page_at_addr(xe, addr - vr->dpa_base, vram_mgr, mm);
>>   }

[-- Attachment #2: Type: text/html, Size: 38460 bytes --]