Intel-XE Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Michal Wajdeczko <michal.wajdeczko@intel.com>
To: Tomasz Lis <tomasz.lis@intel.com>,
	intel-xe@lists.freedesktop.org,
	dri-devel <dri-devel@lists.freedesktop.org>
Cc: "Michał Winiarski" <michal.winiarski@intel.com>,
	"Piotr Piórkowski" <piotr.piorkowski@intel.com>
Subject: Re: [PATCH v3 1/3] drm/drm_mm: Safe macro for iterating through nodes in range
Date: Wed, 27 Nov 2024 22:31:24 +0100	[thread overview]
Message-ID: <79c6d852-0d0c-41e1-9dfc-b879290b4e39@intel.com> (raw)
In-Reply-To: <20241123031333.3435414-2-tomasz.lis@intel.com>

same as previously, please don't forget to include dri-devel for all drm
level changes

On 23.11.2024 04:13, Tomasz Lis wrote:
> Benefits of drm_mm_for_each_node_safe and drm_mm_for_each_node_in_range
> squished together into one macro.
> 
> Signed-off-by: Tomasz Lis <tomasz.lis@intel.com>
> ---
>  include/drm/drm_mm.h | 19 +++++++++++++++++++
>  1 file changed, 19 insertions(+)
> 
> diff --git a/include/drm/drm_mm.h b/include/drm/drm_mm.h
> index f654874c4ce6..43e99441f6ba 100644
> --- a/include/drm/drm_mm.h
> +++ b/include/drm/drm_mm.h
> @@ -504,6 +504,25 @@ __drm_mm_interval_first(const struct drm_mm *mm, u64 start, u64 last);
>  	     node__->start < (end__);					\
>  	     node__ = list_next_entry(node__, node_list))
>  
> +/**
> + * drm_mm_for_each_node_in_range_safe - iterator to walk over a range of
> + * allocated nodes
> + * @node__: drm_mm_node structure to assign to in each iteration step
> + * @next__: &struct drm_mm_node to store the next step
> + * @mm__: drm_mm allocator to walk
> + * @start__: starting offset, the first node will overlap this
> + * @end__: ending offset, the last node will start before this (but may overlap)
> + *
> + * This iterator walks over all nodes in the range allocator that lie
> + * between @start and @end. It is implemented similarly to list_for_each_safe(),
> + * so safe against removal of elements.
> + */
> +#define drm_mm_for_each_node_in_range_safe(node__, next__, mm__, start__, end__)	\
> +	for (node__ = __drm_mm_interval_first((mm__), (start__), (end__)-1), \
> +		next__ = list_next_entry(node__, node_list); \
> +	     node__->start < (end__);					\
> +	     node__ = next__, next__ = list_next_entry(next__, node_list))
> +
>  void drm_mm_scan_init_with_range(struct drm_mm_scan *scan,
>  				 struct drm_mm *mm,
>  				 u64 size, u64 alignment, unsigned long color,


  reply	other threads:[~2024-11-27 21:31 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-11-23  3:13 [PATCH v3 0/3] drm/xe/vf: Post-migration recovery of GGTT nodes and CTB Tomasz Lis
2024-11-23  3:13 ` [PATCH v3 1/3] drm/drm_mm: Safe macro for iterating through nodes in range Tomasz Lis
2024-11-27 21:31   ` Michal Wajdeczko [this message]
2024-11-23  3:13 ` [PATCH v3 2/3] drm/xe/sriov: Shifting GGTT area post migration Tomasz Lis
2024-11-27 22:30   ` Michal Wajdeczko
2024-12-03 18:22     ` Lis, Tomasz
2024-11-23  3:13 ` [PATCH v3 3/3] drm/xe/vf: Fixup CTB send buffer messages after migration Tomasz Lis
2024-11-27 23:21   ` Michal Wajdeczko
2024-12-03 18:21     ` Lis, Tomasz
2024-11-23  4:00 ` ✓ CI.Patch_applied: success for drm/xe/vf: Post-migration recovery of GGTT nodes and CTB (rev3) Patchwork
2024-11-23  4:00 ` ✗ CI.checkpatch: warning " Patchwork
2024-11-23  4:02 ` ✓ CI.KUnit: success " Patchwork
2024-11-23  4:20 ` ✓ CI.Build: " Patchwork
2024-11-23  4:22 ` ✓ CI.Hooks: " Patchwork
2024-11-23  4:24 ` ✗ CI.checksparse: warning " Patchwork
2024-11-23  4:45 ` ✓ Xe.CI.BAT: success " Patchwork
2024-11-24 14:04 ` ✗ Xe.CI.Full: failure " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=79c6d852-0d0c-41e1-9dfc-b879290b4e39@intel.com \
    --to=michal.wajdeczko@intel.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=intel-xe@lists.freedesktop.org \
    --cc=michal.winiarski@intel.com \
    --cc=piotr.piorkowski@intel.com \
    --cc=tomasz.lis@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox