public inbox for intel-xe@lists.freedesktop.org
 help / color / mirror / Atom feed
From: "Thomas Hellström" <thomas.hellstrom@linux.intel.com>
To: Matthew Brost <matthew.brost@intel.com>, intel-xe@lists.freedesktop.org
Cc: stable@vger.kernel.org
Subject: Re: [PATCH] drm/xe: Disable garbage collector work item on SVM close
Date: Fri, 20 Mar 2026 13:46:26 +0100	[thread overview]
Message-ID: <7c282de391630193875e2ffcc3002cc1f6e75178.camel@linux.intel.com> (raw)
In-Reply-To: <20260227015225.3081787-1-matthew.brost@intel.com>

On Thu, 2026-02-26 at 17:52 -0800, Matthew Brost wrote:
> When an SVM is closed, the garbage collector work item must be
> stopped
> synchronously and any future queuing must be prevented. Replace
> flush_work() with disable_work_sync() to ensure both conditions are
> met.
> 
> Fixes: 63f6e480d115 ("drm/xe: Add SVM garbage collector")
> Cc: stable@vger.kernel.org
> Signed-off-by: Matthew Brost <matthew.brost@intel.com>

Reviewed-by: Thomas Hellström <thomas.hellstrom@linux.intel.com>


> ---
>  drivers/gpu/drm/xe/xe_svm.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/xe/xe_svm.c
> b/drivers/gpu/drm/xe/xe_svm.c
> index 002b6c22ad3f..f8b57eca76fd 100644
> --- a/drivers/gpu/drm/xe/xe_svm.c
> +++ b/drivers/gpu/drm/xe/xe_svm.c
> @@ -903,7 +903,7 @@ int xe_svm_init(struct xe_vm *vm)
>  void xe_svm_close(struct xe_vm *vm)
>  {
>  	xe_assert(vm->xe, xe_vm_is_closed(vm));
> -	flush_work(&vm->svm.garbage_collector.work);
> +	disable_work_sync(&vm->svm.garbage_collector.work);
>  	xe_svm_put_pagemaps(vm);
>  	drm_pagemap_release_owner(&vm->svm.peer);
>  }

      parent reply	other threads:[~2026-03-20 12:46 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-02-27  1:52 [PATCH] drm/xe: Disable garbage collector work item on SVM close Matthew Brost
2026-02-27  3:06 ` ✓ CI.KUnit: success for " Patchwork
2026-02-27  3:49 ` ✓ Xe.CI.BAT: " Patchwork
2026-02-27 12:03 ` ✗ Xe.CI.FULL: failure " Patchwork
2026-03-20 12:46 ` Thomas Hellström [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7c282de391630193875e2ffcc3002cc1f6e75178.camel@linux.intel.com \
    --to=thomas.hellstrom@linux.intel.com \
    --cc=intel-xe@lists.freedesktop.org \
    --cc=matthew.brost@intel.com \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox