From: "Hogander, Jouni" <jouni.hogander@intel.com>
To: "intel-xe@lists.freedesktop.org" <intel-xe@lists.freedesktop.org>,
"dri-devel@lists.freedesktop.org"
<dri-devel@lists.freedesktop.org>,
"Manna, Animesh" <animesh.manna@intel.com>,
"intel-gfx@lists.freedesktop.org"
<intel-gfx@lists.freedesktop.org>
Cc: "Kandpal, Suraj" <suraj.kandpal@intel.com>,
"Nikula, Jani" <jani.nikula@intel.com>
Subject: Re: [PATCH v7 08/20] drm/i915/alpm: Modify AUX_LESS_WAKE_TIME bitfield for xe3lpd
Date: Wed, 18 Nov 2026 12:12:23 +0000 [thread overview]
Message-ID: <7cad06cfcd10fe599c07075018538dc8e520204e.camel@intel.com> (raw)
In-Reply-To: <20261026054001.799894-9-animesh.manna@intel.com>
On Mon, 2026-10-26 at 11:09 +0530, Animesh Manna wrote:
> The AUX_LESS_WAKE_TIME bitfield in ALPM_CTL is widened from 6 bits to
> 8 bits starting from xe3lpd (display version 35). Add the register
> mask
> and field macro for the wider bitfield and program the wake time
> using
> the appropriate macro based on the display version. Also use the
> wider
> limit when validating the computed wake lines and for the safest
> params
> fallback.
>
> v2: Modify AUX_LESS_WAKE_TIME bitfield for xe3lpd. [Suraj]
> v3: Separate out AUX_LESS_WAKE_TIME bitfield change into its own
> patch. [Jouni]
> v4: Use the wider bitfield limit in aux-less wake time computation
> and safest params. [Jouni, sashiko]
>
> Bspec: 71477
> Cc: Jouni Högander <jouni.hogander@intel.com>
> Signed-off-by: Animesh Manna <animesh.manna@intel.com>
> ---
> drivers/gpu/drm/i915/display/intel_alpm.c | 20 +++++++++++++++--
> --
> drivers/gpu/drm/i915/display/intel_psr_regs.h | 2 ++
> 2 files changed, 18 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/display/intel_alpm.c
> b/drivers/gpu/drm/i915/display/intel_alpm.c
> index b9e31c29ab96..0083752d94f0 100644
> --- a/drivers/gpu/drm/i915/display/intel_alpm.c
> +++ b/drivers/gpu/drm/i915/display/intel_alpm.c
> @@ -204,6 +204,12 @@ static int
> _lnl_compute_aux_less_wake_time(struct intel_dp *intel_dp,
> establishment_period, 1000);
> }
>
> +static int get_aux_less_wake_lines_max(struct intel_display
> *display)
> +{
> + return DISPLAY_VER(display) >= 35 ?
> ALPM_CTL_AUX_LESS_WAKE_TIME_MASK_XE3LPD :
> +
> ALPM_CTL_AUX_LESS_WAKE_TIME_MASK;
These should have been using REG_FIELD_MAX from the beginning. I think
this is good time to switch into that at least on aux_less_wake_lines.
BR,
Jouni Högander
> +}
> +
> static int
> _lnl_compute_aux_less_alpm_params(struct intel_dp *intel_dp,
> struct intel_crtc_state
> *crtc_state)
> @@ -220,14 +226,14 @@ _lnl_compute_aux_less_alpm_params(struct
> intel_dp *intel_dp,
>
> lfps_half_cycle = get_lfps_half_cycle_clocks(crtc_state);
>
> - if (aux_less_wake_lines > ALPM_CTL_AUX_LESS_WAKE_TIME_MASK
> ||
> + if (aux_less_wake_lines >
> get_aux_less_wake_lines_max(display) ||
> silence_period > PORT_ALPM_CTL_SILENCE_PERIOD_MASK ||
> lfps_half_cycle < 1 ||
> lfps_half_cycle >
> PORT_ALPM_LFPS_CTL_LAST_LFPS_HALF_CYCLE_DURATION_MASK + 1)
> return false;
>
> if (display->params.psr_safest_params)
> - aux_less_wake_lines =
> ALPM_CTL_AUX_LESS_WAKE_TIME_MASK;
> + aux_less_wake_lines =
> get_aux_less_wake_lines_max(display);
>
> crtc_state->alpm_state.aux_less_wake_lines =
> aux_less_wake_lines;
> crtc_state->alpm_state.silence_period_sym_clocks =
> silence_period;
> @@ -617,10 +623,16 @@ static void lnl_alpm_configure(struct intel_dp
> *intel_dp,
> * check panel support at this point.
> */
> if (intel_alpm_is_alpm_aux_less(intel_dp, crtc_state)) {
> + int wake_lines = crtc_state-
> >alpm_state.aux_less_wake_lines;
> +
> alpm_ctl = ALPM_CTL_ALPM_ENABLE |
> ALPM_CTL_ALPM_AUX_LESS_ENABLE |
> - ALPM_CTL_AUX_LESS_SLEEP_HOLD_TIME_50_SYMBOLS
> |
> - ALPM_CTL_AUX_LESS_WAKE_TIME(crtc_state-
> >alpm_state.aux_less_wake_lines);
> + ALPM_CTL_AUX_LESS_SLEEP_HOLD_TIME_50_SYMBOLS
> ;
> +
> + if (DISPLAY_VER(display) < 35)
> + alpm_ctl |=
> ALPM_CTL_AUX_LESS_WAKE_TIME(wake_lines);
> + else
> + alpm_ctl |=
> ALPM_CTL_AUX_LESS_WAKE_TIME_XE3LPD(wake_lines);
>
> if (intel_dp->as_sdp_supported)
> intel_alpm_configure_pr_as_sdp(intel_dp,
> crtc_state);
> diff --git a/drivers/gpu/drm/i915/display/intel_psr_regs.h
> b/drivers/gpu/drm/i915/display/intel_psr_regs.h
> index 78a05387eab5..124aa74e1dbb 100644
> --- a/drivers/gpu/drm/i915/display/intel_psr_regs.h
> +++ b/drivers/gpu/drm/i915/display/intel_psr_regs.h
> @@ -301,7 +301,9 @@
> #define ALPM_CTL_EXTENDED_FAST_WAKE_MIN_LINES 5
> #define
> ALPM_CTL_EXTENDED_FAST_WAKE_TIME(lines) REG_FIELD_PREP(ALPM_CTL_EXTENDED_FAST_WAKE_TIME_MASK,(lines)-ALPM_CTL_EXTENDED_FAST_WAKE_MIN_LINES)
> #define
> ALPM_CTL_AUX_LESS_WAKE_TIME_MASK REG_GENMASK(5, 0)
> +#define
> ALPM_CTL_AUX_LESS_WAKE_TIME_MASK_XE3LPD REG_GENMASK(7, 0)
> #define
> ALPM_CTL_AUX_LESS_WAKE_TIME(val) REG_FIELD_PREP(ALPM_CTL_AUX_LESS_WAKE_TIME_MASK,val)
> +#define
> ALPM_CTL_AUX_LESS_WAKE_TIME_XE3LPD(val) REG_FIELD_PREP(ALPM_CTL_AUX_LESS_WAKE_TIME_MASK_XE3LPD,val)
>
> #define _ALPM_CTL2_A 0x60954
> #define ALPM_CTL2(dev_priv, tran) _MMIO_TRANS2(dev_priv, tran,
> _ALPM_CTL2_A)
next prev parent reply other threads:[~2026-11-18 12:12 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-26 5:39 [PATCH v7 00/20] Enable DP2.1 alpm Animesh Manna
2026-10-26 5:39 ` [PATCH v7 01/20] drm/i915/alpm: Program zero-based LFPS half cycle duration Animesh Manna
2026-10-27 15:33 ` Jani Nikula
2026-10-28 5:42 ` Manna, Animesh
2026-10-26 5:39 ` [PATCH v7 02/20] drm/dp: Add DPCD definitions for DP2.1 ALPM capability Animesh Manna
2026-11-18 11:44 ` Hogander, Jouni
2026-10-26 5:39 ` [PATCH v7 03/20] drm/i915/alpm: Move alpm sink capability readout into a separate function Animesh Manna
2026-10-26 5:39 ` [PATCH v7 04/20] drm/i915/alpm: alpm_init() for DP2.1 Animesh Manna
2026-10-26 7:11 ` sashiko-bot
2026-11-18 11:44 ` Hogander, Jouni
2026-10-26 5:39 ` [PATCH v7 05/20] drm/i915/alpm: Enable debugfs " Animesh Manna
2026-11-18 11:45 ` Hogander, Jouni
2026-10-26 5:39 ` [PATCH v7 06/20] drm/i915/alpm: Refactor Auxless wake time calculation Animesh Manna
2026-11-18 11:46 ` Hogander, Jouni
2026-10-26 5:39 ` [PATCH v7 07/20] drm/i915/alpm: Auxless wake time calculation for Xe3p Animesh Manna
2026-10-26 5:39 ` [PATCH v7 08/20] drm/i915/alpm: Modify AUX_LESS_WAKE_TIME bitfield for xe3lpd Animesh Manna
2026-11-02 6:06 ` Kandpal, Suraj
2026-11-18 12:05 ` Hogander, Jouni
2026-11-18 12:12 ` Hogander, Jouni [this message]
2026-10-26 5:39 ` [PATCH v7 09/20] drm/i915/alpm: table based establishment period Animesh Manna
2026-11-18 12:15 ` Hogander, Jouni
2026-10-26 5:39 ` [PATCH v7 10/20] drm/i915/alpm: Half LFPS cycle calculation Animesh Manna
2026-10-26 7:06 ` sashiko-bot
2026-10-26 5:39 ` [PATCH v7 11/20] drm/i915/alpm: Modify LFPS cycle count for DP ALPM Animesh Manna
2026-10-26 5:39 ` [PATCH v7 12/20] drm/i915/alpm: Modify LFPS_CYCLE_COUNT bitfield for xe3lpd Animesh Manna
2026-11-02 6:07 ` Kandpal, Suraj
2026-10-26 5:39 ` [PATCH v7 13/20] drm/i915/alpm: Program LTTPR count for DP 2.1 ALPM Animesh Manna
2026-10-26 5:39 ` [PATCH v7 14/20] drm/i915/alpm: Enable MAC Transmitting LFPS for LT PHY Animesh Manna
2026-10-26 5:39 ` [PATCH v7 15/20] drm/i915/alpm: Compute and program switch to active latency Animesh Manna
2026-10-26 5:39 ` [PATCH v7 16/20] drm/i915/alpm: Replace is_edp() with alpm_is_possible() Animesh Manna
2026-10-26 7:16 ` sashiko-bot
2026-10-26 5:39 ` [PATCH v7 17/20] drm/i915/alpm: Disallow ALPM for UHBR link rate Animesh Manna
2026-10-26 5:39 ` [PATCH v7 18/20] drm/i915/alpm: Compute ALPM config before PSR config Animesh Manna
2026-10-26 5:39 ` [PATCH v7 19/20] drm/i915/alpm: Introduce has_alpm to decouple from pr/psr2/lobf Animesh Manna
2026-10-26 7:23 ` sashiko-bot
2026-10-26 5:39 ` [PATCH v7 20/20] drm/i915/dp: Enable AS SDP for DP Panel Replay with AUX-less ALPM Animesh Manna
2026-10-26 5:50 ` ✗ CI.checkpatch: warning for Enable DP2.1 alpm (rev7) Patchwork
2026-10-26 5:52 ` ✓ CI.KUnit: success " Patchwork
2026-10-26 6:28 ` ✓ Xe.CI.BAT: " Patchwork
2026-10-26 8:06 ` ✗ Xe.CI.FULL: failure " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7cad06cfcd10fe599c07075018538dc8e520204e.camel@intel.com \
--to=jouni.hogander@intel.com \
--cc=animesh.manna@intel.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=intel-xe@lists.freedesktop.org \
--cc=jani.nikula@intel.com \
--cc=suraj.kandpal@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox