Intel-XE Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: "Hogander, Jouni" <jouni.hogander@intel.com>
To: "intel-xe@lists.freedesktop.org" <intel-xe@lists.freedesktop.org>,
	"intel-gfx@lists.freedesktop.org"
	<intel-gfx@lists.freedesktop.org>,
	"Govindapillai, Vinod" <vinod.govindapillai@intel.com>
Cc: "ville.syrjala@linux.intel.com" <ville.syrjala@linux.intel.com>
Subject: Re: [PATCH 4/4] drm/i915/fbc: xe2_lpd+ no more surface size restrictions for FBC
Date: Tue, 21 Jul 2026 09:04:14 +0000	[thread overview]
Message-ID: <7d58d47642ea4b927eea13afb3f097ef52756a98.camel@intel.com> (raw)
In-Reply-To: <20260716225956.555995-5-vinod.govindapillai@intel.com>

On Fri, 2026-07-17 at 01:59 +0300, Vinod Govindapillai wrote:
> From xe2_lpd+ platforms, enabling FBC do not depend on the
> surface size. So remove it.

Here also display version is more clear. I think it is up to you if you
want to change:

Reviewed-by: Jouni Högander <jouni.hogander@intel.com>

> 
> Bspec: 69560
> Signed-off-by: Vinod Govindapillai <vinod.govindapillai@intel.com>
> ---
>  drivers/gpu/drm/i915/display/intel_fbc.c | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/drivers/gpu/drm/i915/display/intel_fbc.c
> b/drivers/gpu/drm/i915/display/intel_fbc.c
> index 20f02ef9387a..df8446457247 100644
> --- a/drivers/gpu/drm/i915/display/intel_fbc.c
> +++ b/drivers/gpu/drm/i915/display/intel_fbc.c
> @@ -1306,6 +1306,9 @@ static bool intel_fbc_surface_size_ok(const
> struct intel_plane_state *plane_stat
>  	struct intel_display *display =
> to_intel_display(plane_state);
>  	unsigned int effective_w, effective_h, max_w, max_h;
>  
> +	if (DISPLAY_VER(display) >= 20)
> +		return true;
> +
>  	intel_fbc_max_surface_size(display, &max_w, &max_h);
>  
>  	effective_w = plane_state->view.color_plane[0].x +


  reply	other threads:[~2026-07-21  9:04 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-16 22:59 'From 351218ae36a91f36924c9b3c1ecc4d42100fd573 Mon Sep 17 00:00:00 2001 Vinod Govindapillai
2026-07-16 22:59 ` [PATCH 1/4] drm/xe/display: Expose plane max width/height helpers to global scope Vinod Govindapillai
2026-07-21  9:07   ` Hogander, Jouni
2026-07-16 22:59 ` [PATCH 2/4] drm/i915/fbc: refactor maximum plane size handling for fbc Vinod Govindapillai
2026-07-21  9:09   ` Hogander, Jouni
2026-07-21  9:48     ` Govindapillai, Vinod
2026-07-16 22:59 ` [PATCH 3/4] drm/i915/fbc: xe2_lpd+ don't require any hardcoded plane width limit Vinod Govindapillai
2026-07-21  9:01   ` Hogander, Jouni
2026-07-21  9:47     ` Govindapillai, Vinod
2026-07-21 11:00       ` Govindapillai, Vinod
2026-07-16 22:59 ` [PATCH 4/4] drm/i915/fbc: xe2_lpd+ no more surface size restrictions for FBC Vinod Govindapillai
2026-07-21  9:04   ` Hogander, Jouni [this message]
2026-07-16 23:06 ` ✗ CI.checkpatch: warning for series starting with [1/4] drm/xe/display: Expose plane max width/height helpers to global scope Patchwork
2026-07-16 23:07 ` ✓ CI.KUnit: success " Patchwork
2026-07-16 23:53 ` ✓ Xe.CI.BAT: " Patchwork
2026-07-17  4:46 ` ✓ Xe.CI.FULL: " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7d58d47642ea4b927eea13afb3f097ef52756a98.camel@intel.com \
    --to=jouni.hogander@intel.com \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=intel-xe@lists.freedesktop.org \
    --cc=ville.syrjala@linux.intel.com \
    --cc=vinod.govindapillai@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox