From: Jani Nikula <jani.nikula@linux.intel.com>
To: Maarten Lankhorst <dev@lankhorst.se>,
intel-gfx@lists.freedesktop.org, intel-xe@lists.freedesktop.org
Cc: dri-devel@lists.freedesktop.org,
Maarten Lankhorst <dev@lankhorst.se>,
Uma Shankar <uma.shankar@intel.com>
Subject: Re: [PATCH 1/4] drm/i915/display: Make icl_dsi_frame_update use _fw too
Date: Thu, 02 Jul 2026 11:27:37 +0300 [thread overview]
Message-ID: <7d7cf653c4be0d88e69486e224c781bf4e73c730@intel.com> (raw)
In-Reply-To: <20260702080346.431508-2-dev@lankhorst.se>
On Thu, 02 Jul 2026, Maarten Lankhorst <dev@lankhorst.se> wrote:
> Don't use the dmc lock inside the vblank critical section,
> not even as last call.
The commit message should explain the why.
> Signed-off-by: Maarten Lankhorst <dev@lankhorst.se>
> Reviewed-by: Uma Shankar <uma.shankar@intel.com>
> ---
> drivers/gpu/drm/i915/display/icl_dsi.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/display/icl_dsi.c b/drivers/gpu/drm/i915/display/icl_dsi.c
> index ea0cdb7822f39..f1ccbc5efd6ea 100644
> --- a/drivers/gpu/drm/i915/display/icl_dsi.c
> +++ b/drivers/gpu/drm/i915/display/icl_dsi.c
> @@ -242,8 +242,8 @@ void icl_dsi_frame_update(struct intel_crtc_state *crtc_state)
> else
> return;
>
> - intel_de_rmw(display, DSI_CMD_FRMCTL(port), 0,
> - DSI_FRAME_UPDATE_REQUEST);
> + intel_de_rmw_fw(display, DSI_CMD_FRMCTL(port), 0,
> + DSI_FRAME_UPDATE_REQUEST);
> }
>
> static void dsi_program_swing_and_deemphasis(struct intel_encoder *encoder)
--
Jani Nikula, Intel
next prev parent reply other threads:[~2026-07-02 8:27 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-02 8:03 [PATCH 0/4] drm/intel/display: Remove forcewake during pipe updates Maarten Lankhorst
2026-07-02 8:03 ` [PATCH 1/4] drm/i915/display: Make icl_dsi_frame_update use _fw too Maarten Lankhorst
2026-07-02 8:27 ` Jani Nikula [this message]
2026-07-02 8:03 ` [PATCH 2/4] drm/i915/display: Use intel_de_read/write_fw in colorops Maarten Lankhorst
2026-07-02 8:28 ` Jani Nikula
2026-07-02 8:03 ` [PATCH 3/4] drm/i915/display: Use intel_de_write_fw in intel_pipe_fastset Maarten Lankhorst
2026-07-02 8:44 ` Jani Nikula
2026-07-02 11:29 ` Maarten Lankhorst
2026-07-02 8:03 ` [PATCH 4/4] drm/i915/display: Make set_pipeconf use the fw variants Maarten Lankhorst
2026-07-02 8:32 ` ✗ CI.checkpatch: warning for drm/intel/display: Remove forcewake during pipe updates Patchwork
2026-07-02 8:34 ` ✓ CI.KUnit: success " Patchwork
2026-07-02 9:16 ` ✓ Xe.CI.BAT: " Patchwork
2026-07-03 2:37 ` ✓ Xe.CI.FULL: " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7d7cf653c4be0d88e69486e224c781bf4e73c730@intel.com \
--to=jani.nikula@linux.intel.com \
--cc=dev@lankhorst.se \
--cc=dri-devel@lists.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=intel-xe@lists.freedesktop.org \
--cc=uma.shankar@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox