From: Jani Nikula <jani.nikula@linux.intel.com>
To: Ville Syrjala <ville.syrjala@linux.intel.com>,
intel-gfx@lists.freedesktop.org
Cc: intel-xe@lists.freedesktop.org
Subject: Re: [PATCH 5/7] drm/i915/dsb: Update previous instruction tracking in intel_dsb_align_tail() & co.
Date: Tue, 17 Nov 2026 18:07:15 +0200 [thread overview]
Message-ID: <7d90df4bf575d83be6b34824d3a40d07fa5d10d2@intel.com> (raw)
In-Reply-To: <20261116081041.6519-6-ville.syrjala@linux.intel.com>
On Mon, 16 Nov 2026, Ville Syrjala <ville.syrjala@linux.intel.com> wrote:
> From: Ville Syrjälä <ville.syrjala@linux.intel.com>
>
> intel_dsb_align_tail() and intel_dsb_gosub_align() simply memset
> a bunch of QWs to 0. What that actually does is emit a bunch of
> NOOP instructions. For complete correctness let's keep the
> previous instruction tracking up to date, instead of leaving
> it pointing at whatever instruction preceded the alignment
> NOOPs.
>
> Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
> ---
> drivers/gpu/drm/i915/display/intel_dsb.c | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/drivers/gpu/drm/i915/display/intel_dsb.c b/drivers/gpu/drm/i915/display/intel_dsb.c
> index 75f98b31c780..f8ca64a3c076 100644
> --- a/drivers/gpu/drm/i915/display/intel_dsb.c
> +++ b/drivers/gpu/drm/i915/display/intel_dsb.c
> @@ -601,6 +601,8 @@ static void intel_dsb_align_tail(struct intel_dsb *dsb)
> if (aligned_tail > tail) {
> dsb_buffer_fill(dsb, dsb->free_pos, 0, aligned_tail - tail);
> dsb->free_pos = aligned_tail / 4;
> +
> + intel_dsb_set_ins(dsb, dsb->free_pos - 2, 0, 0);
So is this just the last two NOOPs?
BR,
Jani.
> }
> }
>
> @@ -624,6 +626,8 @@ static void intel_dsb_gosub_align(struct intel_dsb *dsb)
> if (aligned_tail - tail <= 2 * 8) {
> dsb_buffer_fill(dsb, dsb->free_pos, 0, aligned_tail - tail);
> dsb->free_pos = aligned_tail / 4;
> +
> + intel_dsb_set_ins(dsb, dsb->free_pos - 2, 0, 0);
> }
> }
--
Jani Nikula, Intel
next prev parent reply other threads:[~2026-11-17 16:07 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-16 8:10 [PATCH 0/7] drm/i915/dsb: Optimize indexed register writes Ville Syrjala
2026-11-16 8:10 ` [PATCH 1/7] drm/i915/dsb: Remove old comment about stale contents of the DSB buffer Ville Syrjala
2026-11-17 15:43 ` Jani Nikula
2026-11-16 8:10 ` [PATCH 2/7] drm/i915/dsb: Eliminate intel_dsb_prev_ins_is_write() Ville Syrjala
2026-11-17 15:44 ` Jani Nikula
2026-11-16 8:10 ` [PATCH 3/7] drm/i915/dsb: Carve up intel_dsb_prev_ins_is_indexed_write() Ville Syrjala
2026-11-17 15:47 ` Jani Nikula
2026-11-16 8:10 ` [PATCH 4/7] drm/i915/dsb: Extract intel_dsb_set_ins() Ville Syrjala
2026-11-17 15:48 ` Jani Nikula
2026-11-16 8:10 ` [PATCH 5/7] drm/i915/dsb: Update previous instruction tracking in intel_dsb_align_tail() & co Ville Syrjala
2026-11-17 16:07 ` Jani Nikula [this message]
2026-11-17 18:41 ` Ville Syrjälä
2026-11-17 18:55 ` Ville Syrjälä
2026-11-16 8:10 ` [PATCH 6/7] drm/i915/dsb: Skip redundant zeroing of every second indexed write DW Ville Syrjala
2026-11-17 15:57 ` Jani Nikula
2026-11-16 8:10 ` [PATCH 7/7] drm/i915/dsb: Avoid redundant writes to the DSB buffer for indexed register writes Ville Syrjala
2026-11-17 16:05 ` Jani Nikula
2026-11-17 18:46 ` Ville Syrjälä
2026-11-16 8:47 ` ✓ CI.KUnit: success for drm/i915/dsb: Optimize " Patchwork
2026-11-16 9:19 ` ✓ Xe.CI.BAT: " Patchwork
2026-11-16 12:32 ` ✓ Xe.CI.FULL: " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7d90df4bf575d83be6b34824d3a40d07fa5d10d2@intel.com \
--to=jani.nikula@linux.intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=intel-xe@lists.freedesktop.org \
--cc=ville.syrjala@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox