Re: [PATCH 4/5] drm/xe/uapi: Fix code examples in xe_drm.h documentation

["Wang, X" <x.wang@intel.com>]

On 3/31/2026 10:20, Shuicheng Lin wrote:
> Fix incorrect field names and formatting in code examples:
> - .num_bb_per_exec -> .width (renamed struct field
>    in exec_queue_create examples)
> - .num_eng_per_bb -> .num_placements (renamed struct
>    field in exec_queue_create examples)
> - .atomic_val -> .atomic.val (correct nested struct
>    field access in madvise example)
> - Remove unnecessary backslash escaping in UUID format
>    string (%\08x -> %08x)
>
> Assisted-by: GitHub Copilot:claude-opus-4.6
> Signed-off-by: Shuicheng Lin <shuicheng.lin@intel.com>
> ---
>   include/uapi/drm/xe_drm.h | 12 ++++++------
>   1 file changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/include/uapi/drm/xe_drm.h b/include/uapi/drm/xe_drm.h
> index 36627322448c..c2e8cf31a82a 100644
> --- a/include/uapi/drm/xe_drm.h
> +++ b/include/uapi/drm/xe_drm.h
> @@ -1401,8 +1401,8 @@ struct drm_xe_vm_get_property {
>    *     struct drm_xe_exec_queue_create exec_queue_create = {
>    *          .extensions = 0,
>    *          .vm_id = vm,
> - *          .num_bb_per_exec = 1,
> - *          .num_eng_per_bb = 1,
> + *          .width = 1,
> + *          .num_placements = 1,
>    *          .instances = to_user_pointer(&instance),
>    *     };
>    *     ioctl(fd, DRM_IOCTL_XE_EXEC_QUEUE_CREATE, &exec_queue_create);
> @@ -1416,8 +1416,8 @@ struct drm_xe_vm_get_property {
>    *          .flags = DRM_XE_EXEC_QUEUE_LOW_LATENCY_HINT,
>    *          .extensions = 0,
>    *          .vm_id = vm,
> - *          .num_bb_per_exec = 1,
> - *          .num_eng_per_bb = 1,
> + *          .width = 1,
> + *          .num_placements = 1,
>    *          .instances = to_user_pointer(&instance),
>    *     };
>    *     ioctl(fd, DRM_IOCTL_XE_EXEC_QUEUE_CREATE, &exec_queue_create);
> @@ -2019,7 +2019,7 @@ struct drm_xe_oa_config {
>   	/** @extensions: Pointer to the first extension struct, if any */
>   	__u64 extensions;
>   
> -	/** @uuid: String formatted like "%\08x-%\04x-%\04x-%\04x-%\012x" */
> +	/** @uuid: String formatted like "%08x-%04x-%04x-%04x-%012x" */
>   	char uuid[36];
>   
>   	/** @n_regs: Number of regs in @regs_ptr */
> @@ -2181,7 +2181,7 @@ struct drm_xe_query_eu_stall {
>    *         .start = 0x100000,
>    *         .range = 0x2000,
>    *         .type = DRM_XE_MEM_RANGE_ATTR_ATOMIC,
> - *         .atomic_val = DRM_XE_ATOMIC_DEVICE,
> + *         .atomic.val = DRM_XE_ATOMIC_DEVICE,

Reviewed-by: Xin Wang <x.wang@intel.com>

>    *    };
>    *
>    *    ioctl(fd, DRM_IOCTL_XE_MADVISE, &madvise);