Intel-XE Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Matthew Auld <matthew.auld@intel.com>
To: "Zbigniew Kempczyński" <zbigniew.kempczynski@intel.com>,
	intel-xe@lists.freedesktop.org
Subject: Re: [PATCH] drm/xe_pat: Print PAT_ATS during register dump
Date: Tue, 31 Mar 2026 15:10:57 +0100	[thread overview]
Message-ID: <7e23b76c-2c39-40f6-abd0-cd50de5f6240@intel.com> (raw)
In-Reply-To: <20260331134330.2535519-2-zbigniew.kempczynski@intel.com>

On 31/03/2026 14:43, Zbigniew Kempczyński wrote:
> For Xe2 and beyond we miss printing PAT_ATS register.
> 
> Signed-off-by: Zbigniew Kempczyński <zbigniew.kempczynski@intel.com>
> Cc: Matthew Auld <matthew.auld@intel.com>

Nit: commit title drm/xe/pat:

> ---
>   drivers/gpu/drm/xe/xe_pat.c | 8 ++++++++
>   1 file changed, 8 insertions(+)
> 
> diff --git a/drivers/gpu/drm/xe/xe_pat.c b/drivers/gpu/drm/xe/xe_pat.c
> index 356f53bdb83c..75aaae7b003d 100644
> --- a/drivers/gpu/drm/xe/xe_pat.c
> +++ b/drivers/gpu/drm/xe/xe_pat.c
> @@ -531,6 +531,14 @@ static int xe2_dump(struct xe_gt *gt, struct drm_printer *p)
>   	drm_printf(p, "Page Table Access:\n");
>   	xe->pat.ops->entry_dump(p, "PTA_MODE", pat, false);
>   
> +	if (xe_gt_is_media_type(gt))
> +		pat = xe_mmio_read32(&gt->mmio, XE_REG(_PAT_ATS));
> +	else
> +		pat = xe_gt_mcr_unicast_read_any(gt, XE_REG_MCR(_PAT_ATS));
> +
> +	drm_printf(p, "PCIe ATS/PASID:\n");
> +	xe->pat.ops->entry_dump(p, "PAT_ATS ", pat, false);

Reviewed-by: Matthew Auld <matthew.auld@intel.com>

> +
>   	return 0;
>   }
>   


  parent reply	other threads:[~2026-03-31 14:11 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-31 13:43 [PATCH] drm/xe_pat: Print PAT_ATS during register dump Zbigniew Kempczyński
2026-03-31 13:50 ` ✓ CI.KUnit: success for " Patchwork
2026-03-31 14:10 ` Matthew Auld [this message]
2026-03-31 14:30 ` ✓ Xe.CI.BAT: " Patchwork
2026-03-31 18:54 ` ✗ Xe.CI.FULL: failure " Patchwork
2026-03-31 21:53   ` Matt Roper

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7e23b76c-2c39-40f6-abd0-cd50de5f6240@intel.com \
    --to=matthew.auld@intel.com \
    --cc=intel-xe@lists.freedesktop.org \
    --cc=zbigniew.kempczynski@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox