Intel-XE Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Michal Wajdeczko <michal.wajdeczko@intel.com>
To: Matthew Brost <matthew.brost@intel.com>
Cc: intel-xe@lists.freedesktop.org, Matthew Auld <matthew.auld@intel.com>
Subject: Re: [PATCH] drm/xe/sa: Drop hardcoded 4K guard in sub-allocator
Date: Wed, 18 Dec 2024 20:42:36 +0100	[thread overview]
Message-ID: <825e40ab-54ad-4849-bf7a-0f85b4307cdc@intel.com> (raw)
In-Reply-To: <Z2H9sADDJOvFG6j+@lstrano-desk.jf.intel.com>



On 17.12.2024 23:39, Matthew Brost wrote:
> On Tue, Dec 17, 2024 at 11:22:46PM +0100, Michal Wajdeczko wrote:
>> Any required prefetch guards are added during batch buffer
>> allocations anyway.
>>
> 
> This should work but I think we actually want to do the opposite of
> this - drop the prefetch pad in BB allocation. This would enable a more

but this will make the SA even more bound to usages specific to engines,
while the goal was to make the allocator more agnostic

> optimial usage of each suballocation. I think that would work unless we
> have an odd caching issue - if caching is a problem then maybe the BB is
> a cacheline.
> 
> I haven't had time to try to out yet but I think we explore the above
> option first. If I'm missing something and the above does not work, then
> agree with this patch.
> 
> Matt
> 

  parent reply	other threads:[~2024-12-18 19:42 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-12-17 22:22 [PATCH] drm/xe/sa: Drop hardcoded 4K guard in sub-allocator Michal Wajdeczko
2024-12-17 22:39 ` Matthew Brost
2024-12-18  9:15   ` Matthew Auld
2024-12-18 19:47     ` Michal Wajdeczko
2024-12-19  4:16       ` Matthew Brost
2024-12-18 19:42   ` Michal Wajdeczko [this message]
2024-12-18  0:05 ` ✓ CI.Patch_applied: success for " Patchwork
2024-12-18  0:05 ` ✓ CI.checkpatch: " Patchwork
2024-12-18  0:06 ` ✓ CI.KUnit: " Patchwork
2024-12-18  0:24 ` ✓ CI.Build: " Patchwork
2024-12-18  0:26 ` ✓ CI.Hooks: " Patchwork
2024-12-18  0:28 ` ✓ CI.checksparse: " Patchwork
2024-12-18  1:02 ` ✓ Xe.CI.BAT: " Patchwork
2024-12-18 10:42 ` ✗ Xe.CI.Full: failure " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=825e40ab-54ad-4849-bf7a-0f85b4307cdc@intel.com \
    --to=michal.wajdeczko@intel.com \
    --cc=intel-xe@lists.freedesktop.org \
    --cc=matthew.auld@intel.com \
    --cc=matthew.brost@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox