Re: [PATCH] drm/xe/sriov: Mark NVL as SR-IOV capable

["Lis, Tomasz" <tomasz.lis@intel.com>]

Reviewed-by: Tomasz Lis <tomasz.lis@intel.com>

-Tomasz

On 4/1/2026 12:07 AM, Matt Roper wrote:
> On Tue, Mar 31, 2026 at 03:22:59PM +0000, Jakub Kolakowski wrote:
>> Enable SR-IOV support for NVL platforms.
>>
>> Signed-off-by: Jakub Kolakowski <jakub1.kolakowski@intel.com>
>> Cc: Michal Wajdeczko <michal.wajdeczko@intel.com>
>> Cc: Piotr Piórkowski <piotr.piorkowski@intel.com>
>> Cc: Dnyaneshwar Bhadane <dnyaneshwar.bhadane@intel.com>
>> Cc: Matt Roper <matthew.d.roper@intel.com>
>> ---
>>   drivers/gpu/drm/xe/xe_pci.c | 2 ++
>>   1 file changed, 2 insertions(+)
>>
>> diff --git a/drivers/gpu/drm/xe/xe_pci.c b/drivers/gpu/drm/xe/xe_pci.c
>> index 1df3f08e2e1c..e7d7f0b6b998 100644
>> --- a/drivers/gpu/drm/xe/xe_pci.c
>> +++ b/drivers/gpu/drm/xe/xe_pci.c
>> @@ -443,6 +443,7 @@ static const struct xe_device_desc nvls_desc = {
>>   	.has_display = true,
>>   	.has_flat_ccs = 1,
>>   	.has_pre_prod_wa = 1,
>> +	.has_sriov = true,
> Since the structure field is defined as
>
>          u8 has_sriov:1;
>
> it might be slightly more idiomatic to assign 1 rather than 'true.'
> We're a bit inconsistent in the handling of the other flags in these
> structures as well.  Anyway, it doesn't really matter that much, so up
> to you whether you want to change it or not.  At some point we'll
> probably do a general cleanup to handle all of the flags in a consistent
> manner.
>
> Since we don't have CI setup for this platform yet, I'll let someone
> from the SR-IOV team give the formal r-b on this patch confirming that
> we have everything in place necessary to flip the switch here and start
> allowing SR-IOV use.
>
>
> Matt
>
>>   	.max_gt_per_tile = 2,
>>   	MULTI_LRC_MASK,
>>   	.require_force_probe = true,
>> @@ -481,6 +482,7 @@ static const struct xe_device_desc nvlp_desc = {
>>   	.has_flat_ccs = 1,
>>   	.has_page_reclaim_hw_assist = true,
>>   	.has_pre_prod_wa = true,
>> +	.has_sriov = true,
>>   	.max_gt_per_tile = 2,
>>   	MULTI_LRC_MASK,
>>   	.require_force_probe = true,
>> -- 
>> 2.34.1
>>