From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B7086D149E8 for ; Fri, 25 Oct 2024 19:34:16 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 84F5210EB7D; Fri, 25 Oct 2024 19:34:16 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=intel.com header.i=@intel.com header.b="GgoxyAU3"; dkim-atps=neutral Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.16]) by gabe.freedesktop.org (Postfix) with ESMTPS id 904CE10EB77 for ; Fri, 25 Oct 2024 19:34:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1729884855; x=1761420855; h=message-id:date:subject:to:cc:references:from: in-reply-to:content-transfer-encoding:mime-version; bh=SM0VOl7oKgQP5d+vIlc0UaRSTO5gYt2VrnKG9hyLW+Y=; b=GgoxyAU36cRBTZjtQAGhEpkLBe6+F4HULbSxPojiMPhWN8fpflu7LMLg jWutHyWNZFMslUF2lmu3boaKJcTXdPhrWCkvNFDn3nod0y6nTXoftkC4/ XxUCLk0Gdu2c7ESm0McaVJTXqHLOzWPCBW7F5oSfaCgSe41IU92caNqOu d3JqRvudixAzmP42AQYJFSlESbmXvcilmOaxR3bQDYQWWyBtJKxOaeblB HHlIHxYMMbIdA4TqDrppR8YEa254UMWtx7+5C8pNU6ZP4vOt2bzggNR4C bIOSJrdotAuXZJGzBLljcIVzl1UTy9RKJNPIJ7Zx1gMoQt+6jmeQhgmpP A==; X-CSE-ConnectionGUID: C3sVCn0OSxKNsnXgjjSmww== X-CSE-MsgGUID: Mp0CiXoDSGKX4SYh9GK4EQ== X-IronPort-AV: E=McAfee;i="6700,10204,11236"; a="17198090" X-IronPort-AV: E=Sophos;i="6.11,232,1725346800"; d="scan'208";a="17198090" Received: from orviesa010.jf.intel.com ([10.64.159.150]) by fmvoesa110.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 25 Oct 2024 12:33:54 -0700 X-CSE-ConnectionGUID: 3FXZBh/vSReb7gywJmFn9Q== X-CSE-MsgGUID: f23nI6QyQpCcqdrrJwtHNA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.11,232,1725346800"; d="scan'208";a="80916357" Received: from fmsmsx603.amr.corp.intel.com ([10.18.126.83]) by orviesa010.jf.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 25 Oct 2024 12:33:50 -0700 Received: from fmsmsx603.amr.corp.intel.com (10.18.126.83) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Fri, 25 Oct 2024 12:33:49 -0700 Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39 via Frontend Transport; Fri, 25 Oct 2024 12:33:49 -0700 Received: from NAM11-DM6-obe.outbound.protection.outlook.com (104.47.57.175) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.39; Fri, 25 Oct 2024 12:33:48 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=Kl03IKD+y9BEhI+0h7tSZCztRifV6rgOXk8ifDHV44gHQVZ/B15g95YGJ008XX7TyeGZ1UDHujub+2uy4PoynFE0vfWcYBEqkavqHZ0CDrWUqfOVwSJW/UWJT7Ssh7qsi+Kkp/tSfOLaa4JbHxlMiAqJ+y0+WM3W1UOaACN36+QQyvOQHKiKyl0a53vXxK34PjKYHUINfNqcSX3ATp5iGZvyelkHHNuSe8pb3zfjYthdNn/jbyncQLTV46/Sk26djoLNwWra7YbAntwTu8rV7TVf30pVLZGK/jyUMJZXyaJTg/jeWq4DUjRRld6UqfZM6vDN1bOjKhcO3k7Sd85gbA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=PGpQuxHFE6FSEUS7w2khPlJ1xdAVRIGIgBTH4PpyXMk=; b=RDMk/1m+WpkcEGmRbcH4UiMSFX/J7V+GfrsjtW9A3OC11LaHIp+Uh01rmiLGAADZ3AqLKjJANoUi3nU6O7lG1Z2MYJoFat0V5Z2oJ916zFKC+yb0d0fNJMlPtCUh0WmtpPhEtkwKo780SYlOw+GMjyrDi3x03EbjHi8zkkaZwC3QBgJCQ4LuOhIyKk3EyA6AH1UjHqgSLlZLgBi722DuCkfpG+GjNbFCbdeOJYxa6i1M3rw7BxPz/yBXpkn6xEqT21h4xgWzG3EkGvzoojdiHh/wPlwJhzm2xAwx9XdimY2tAj78Z69Oru/WlrpkYLROUOga9FlFTEEju7neJCNkXQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from DS0PR11MB6541.namprd11.prod.outlook.com (2603:10b6:8:d3::14) by SA3PR11MB7535.namprd11.prod.outlook.com (2603:10b6:806:307::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8093.18; Fri, 25 Oct 2024 19:33:46 +0000 Received: from DS0PR11MB6541.namprd11.prod.outlook.com ([fe80::e268:87f2:3bd1:1347]) by DS0PR11MB6541.namprd11.prod.outlook.com ([fe80::e268:87f2:3bd1:1347%5]) with mapi id 15.20.8093.021; Fri, 25 Oct 2024 19:33:46 +0000 Message-ID: <82debae5-4eea-4302-bb55-593c1791d3e6@intel.com> Date: Fri, 25 Oct 2024 21:33:39 +0200 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2] drm/xe/ufence: Flush xe ordered_wq in case of ufence timeout To: Matthew Brost , John Harrison CC: Nirmoy Das , Jani Nikula , , Badal Nilawar , Matthew Auld , "Himal Prasad Ghimiray" , Lucas De Marchi , References: <20241024151815.929142-1-nirmoy.das@intel.com> <87bjz9sbqs.fsf@intel.com> <3865ed60-94aa-4bfc-b263-90283aef274f@linux.intel.com> <892d9ec7-6a0c-43d6-bfc1-eb8004e27da6@intel.com> Content-Language: en-US From: Nirmoy Das In-Reply-To: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-ClientProxiedBy: TL2P290CA0006.ISRP290.PROD.OUTLOOK.COM (2603:1096:950:2::6) To DS0PR11MB6541.namprd11.prod.outlook.com (2603:10b6:8:d3::14) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS0PR11MB6541:EE_|SA3PR11MB7535:EE_ X-MS-Office365-Filtering-Correlation-Id: 1dbfc24d-fa6f-4161-0ac9-08dcf52bf147 X-LD-Processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|376014|366016; X-Microsoft-Antispam-Message-Info: =?utf-8?B?OUx2ZVBpTi9nd2V0ekd1QUx0dmJ1SDZZY3ZnMGdZelMyTmpRUk41ajJ1bDA5?= =?utf-8?B?KytSMmdoQS96NXIwUVBQd1VkdVpJTlFTYzR3SXhWMWdsMVJmRHJZWXBFNjNC?= =?utf-8?B?MEF2d0E0QzNsZGdKUTlZMDlDSW5SbExjR2RQNzNRMjFnS1NxM2xZci9ZZWtW?= =?utf-8?B?a0M2dVIyaEErdEtVOXUzeEwrVjBuVldxOTFNTGpRcHVKam9KcDU5TXVXKzho?= =?utf-8?B?akNaSTM0bzl0ZUtVY3ZOdTU3bW1ZT2hWa2lkeXA5cWlKSHdHcmpDSmNtM2J1?= =?utf-8?B?SEkwUHA1a2xRZk8yRjgya3FSN1Y0YWJiSzFiRTJGeC9ROXFwaVVDcFY1b1VK?= =?utf-8?B?eE5oNWQzeGJ3MWpvRWFMbU1ETGlzaDQwL1pObXRXQk9RMHk0WGFmOWhqV3A0?= =?utf-8?B?QWlxbG94K21aNTZtYUlqeWY0TWNwclhDWFZWS3pId000cHpnS1lXUmUxQUlk?= =?utf-8?B?RWpuU0tvZVdRNEs2YWhvRThBL0ZNRldDWTVLVExOQkt3YXI3UWhVSFczQml2?= =?utf-8?B?Q3VKWSs1enNKelZMaVh6UlB1cS9rNnFsS2lWMlNKS1BvakJwWE1hOWdHczQy?= =?utf-8?B?RVNNakJhVFFUZUNJWWp4QzBtcHAxcndNUmVOUHJNLytvay8vdXFaRUQxa0Er?= =?utf-8?B?dE1kdWFBUzN3MFI2MDhnVE1XbFFsSHp0NGNKWC9CT0ZONldTWVo2TTdvZXU4?= =?utf-8?B?WjErY0xGQjlMSk4xTGVpTkZ0TDFuZzh1RjQvYkVXY21Xdi9EeGo3Y3Mzd3oz?= =?utf-8?B?VlMrdkpXN2ZvZHJ4amF6Z3c3Q0JwVjJmM0RySFFGUTB4MFlmZEQ2ckkyT01P?= =?utf-8?B?cXNVUXFsL3Y2Uy9tQkdxN0ZqbHR3SWR0aEM1dVVhdk1MOTBQZHNNK0haZ2JF?= =?utf-8?B?NE5keVNzalhneHVGVnNLSTVYZHpLNVFhRlUzRWpaUUFKc2lxVys0b0FnajVi?= =?utf-8?B?aUtTY2JNbWtXSzJLK211SjB1ZjJDMUFNZFRwMnVSMEZGNHdFbWQ1UG1MQ1pk?= =?utf-8?B?cnBVR05XNGg3dkpCT3FXQ2d5d0xTMVRkSUR1d1NqUjExbUdTQkRZbCtFVDFr?= =?utf-8?B?U2pVT0ZQT2x3ZUczd1VhSlRWS0F5RlNKWHVPbW5RS1RkRG1wSFNZdHRkMzFa?= =?utf-8?B?WUdMK0pvZitPN0puWWNwRk9YdDBnZ2ZuMmVvR0NIZExqTy81ODM4VFArcUow?= =?utf-8?B?Y1YyamJzdUttL0Ixcy92Nm5wc2g3YXNqU0VwbFJpWnBhODIwNGJyY1Z3eDI4?= =?utf-8?B?NzFhZUhFSzJQZFIxMG4vTVNaZ3BaQi93VCtCd1pCTW5ZY2g4OTR6dzlkR0dz?= =?utf-8?B?V3FDU1kyRlNXY2VHcEdBbExpZ3dtUGQrRWFOZXZvQnhJeTdjcFNia0JHMkhp?= =?utf-8?B?Z0YzUWZJQ1QxOUZVdkxESkl6aWxyNXl2WGFzZi9oZjk1QUN5ODZncldPcXJr?= =?utf-8?B?YllGZUljRm1MVHpGK1FmY1J4YTZUTDhoRG0xM2sxNDBrMFd3WGQvSjA3Zml0?= =?utf-8?B?NEYwN2w3WDVVTUwwTGdlZVVCN0sxMUpERmtQVUNsUXdoMmRUUzQzZzQ3YXp6?= =?utf-8?B?UlEwMnRmU1M0K1EvbjhuYnRkVVhzSkM4NDJwbmo4N0ZkazdTZW5tcXowQXB0?= =?utf-8?B?bCsySi81MjRkMm0vTUcrQmxJWU5yS1ozbXpXK1FxUVUzNW5uQTNFamN5a2ho?= =?utf-8?Q?eWb8QQMQvhWnioj398ko?= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DS0PR11MB6541.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(1800799024)(376014)(366016); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?ZVBuNWhXK25LcHVDOU1xVVdkV0o4QlpoYXJ6REpnSGM4VjAvTXpZTlhiWE1x?= =?utf-8?B?ZVpJT0FMcysxaXVWVE0xdm1jM1ZBZEcwZkFPbHg1QVN0YzB6L1ltZWkvZlR4?= =?utf-8?B?RmNhVlA5Mm0raGpsRkZRWmdlRXNoQ0tkcEs1bGhCMVNiZkhCaE9wN0RxdDRt?= =?utf-8?B?ckdGRFVhdkM4L2cvdld1MXRpd0RBakNvV1hvaVVTZFpQNy94ZGhpdTcyRzNI?= =?utf-8?B?N0lJdmRYK05IRm0xdm9NRWlUK0hkSktwczgyVFlQbVFhVlAza3RoYWcxL3Np?= =?utf-8?B?KzBGWWJWQjk5SkIxSlVCWmRRSTVJMjQ4cWZQYzVwN2QvUHIxRTFWbUovNXhG?= =?utf-8?B?dzBNd0JBdHJnOENhbHBLbTRVRVBzZjNaRnRoWDBLYjBpemZtdnlLU0ErNzU0?= =?utf-8?B?UHZYY0xPME9WODE0TEhiRW1uUFlpQnJHWUtJUytXSE13ZTlkN1JkNjhHODdF?= =?utf-8?B?cUFaZDNUVE1vT3IxMkIvM3BxZ0F0bklNUXJZNDRIZlJzWTZUdWtKUzBzSllS?= =?utf-8?B?RXpsSkJzdGUrNi9vb29xazV2RFA0TDdGSlVCK3FZbjRQcUlDemFnOVdOdVlO?= =?utf-8?B?ZTZDc2NLa28zVXlOTXc4TkVlalZxM3l5aFRYbWNzUHlEdFJFV2J0R2N5VWMv?= =?utf-8?B?UFk2b0VyMlVCUU8wU2tsZnpObTd5TllpbzYzVkVDS3QwTGQ2RSszSWkrU0k5?= =?utf-8?B?ZDJmUkkwU0UzRXpzUjhHQUdLZXJVZXFmczFCeGJvcTl4eGNJVmNUaVlxWEVh?= =?utf-8?B?OGpVUHRHSkZvS3M2OTlHa09tQnlRRlRYZDdTWlllaTdhOGlvS2cyc29xbDQr?= =?utf-8?B?UjdQZXUza2grZ0pwL3lWYnNyMGRzOVRqTW91ZjFDSURtdFUvd05rNE5LOWdY?= =?utf-8?B?RDRtSTdYb1d5M21UYWlManVuemZyYUJzRC8velRyTGN6VGVTR2svTGx6ZUFr?= =?utf-8?B?MURjV2JHczYrcTZPbmFyL0kvdWJuZXlvUVpuNCtLV2cxeTRHYnBIQjU2R2E5?= =?utf-8?B?VW1Vbm1NMktWOGdOMlNpSXhTRTdTdHZ4Q2dOa0xhQTlLRDBRTVZ0b0dzMnFo?= =?utf-8?B?aTZ0c0U3TUg3U2lDQW9HbVg4dHRVNDhqbzZQdEhuUU5xTmdUVWgwNmRVOXB4?= =?utf-8?B?ZVJZSGRmUHVzUlJGdkcvWmFqL1drTXNNQjNOVDJ3K3R2QWkyc1Q3Snc4SUg1?= =?utf-8?B?YXE2ZW9UeUltWGhCbVd2WkNlNmJEaFZPR1E5S1NqZUdmNUVUdVNIV240a2k4?= =?utf-8?B?SkNlSmd5UThEN2JPWjRhamlqNzVwbk8yU3dvNENjeXAydWhZT2tLWDdJU1NK?= =?utf-8?B?YjdWLzh0K2xYVGdjV3FtS0lCZExKUjlLVzZESW9la3JRdUhCTSs4V3ZzS1Y1?= =?utf-8?B?OXYzenNUc25lVHNhWGR3cUdvTy93VFNUdndHc0cybXYvdEZveWxHejVESlJ2?= =?utf-8?B?Q0ZVVEdpbTl4MFU0dXlQaUhXQ292UHFzYTJwd1VreU1kc1hXREwycklVU3pG?= =?utf-8?B?Zk9PVWFFNHY4cWVJT2dWblFncTBDc2tHZmsyeUhzajdwdW4yNUd2NVBKOVlU?= =?utf-8?B?ai9MS1MxYlZCVUFWSm9RT0xmRFFYMzdRNXZkOUJvcHMrR0hINWpNaU1JTWEx?= =?utf-8?B?QlBzTGVRUW9rSVZLdGpiZDVhSllRdHlXNjYxbk1GTENBUVNtRGk1RTVpbFND?= =?utf-8?B?Zi9TbTQ1M1hXUGdQdG1Gc3dzRSszRUhYZTV6eEFkMG9kRUttSUlRS3Mzc28z?= =?utf-8?B?Z1N2ZGhJR0RvNE5pUzBzdmwxZ3FzTFNDaXJ5aHZoZDVtbno5cG5tQ1dDRDFS?= =?utf-8?B?U2pBa2l2dWdtMGpITVR6NDU1WHl0eTFHdVRaalg0VG5NeWkvUjZpdVViRUFj?= =?utf-8?B?RVBzaWoxNmxLaC9Zb29oMHJzeVFPb1gzN0hoV3NoNmMrUHp0N3A1SWVGNkti?= =?utf-8?B?QmRDbzFBbWtXWnY1Y2psNWIrMGhhcVBPSU9mWUhrVTRrRDI4VERnSks5bVBF?= =?utf-8?B?VVhTVFhhb0lSb2xlTzY3UUdlalBNc3NIdm9QdTlQSVNGL1ZIMk9GWWtQamdy?= =?utf-8?B?eFpJSWVvNXF4U2hqWldpaDVBVjZJTmFiUWVyWktDMHNTOTdjY2U5di9aWnZh?= =?utf-8?Q?wPp7Mbb7mgH7jMGYrgWtKpXvY?= X-MS-Exchange-CrossTenant-Network-Message-Id: 1dbfc24d-fa6f-4161-0ac9-08dcf52bf147 X-MS-Exchange-CrossTenant-AuthSource: DS0PR11MB6541.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Oct 2024 19:33:46.3327 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 9EYSJ0DICcQHjgGh2lHbu/fMmiuGya/rOLhghaztPueaiYMKjeYvLjkNJN7Foch7cKA6u1HzWwMnwpjHL2emOA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA3PR11MB7535 X-OriginatorOrg: intel.com X-BeenThere: intel-xe@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel Xe graphics driver List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-xe-bounces@lists.freedesktop.org Sender: "Intel-xe" On 10/25/2024 8:34 PM, Matthew Brost wrote: > On Fri, Oct 25, 2024 at 11:27:55AM -0700, John Harrison wrote: >> On 10/25/2024 09:03, Nirmoy Das wrote: >>> On 10/24/2024 6:32 PM, Jani Nikula wrote: >>>> On Thu, 24 Oct 2024, Nirmoy Das wrote: >>>>> Flush xe ordered_wq in case of ufence timeout which is observed >>>>> on LNL and that points to the recent scheduling issue with E-cores. >>>>> >>>>> This is similar to the recent fix: >>>>> commit e51527233804 ("drm/xe/guc/ct: Flush g2h worker in case of g2h >>>>> response timeout") and should be removed once there is E core >>>>> scheduling fix. >>>>> >>>>> v2: Add platform check(Himal) >>>>> s/__flush_workqueue/flush_workqueue(Jani) >>>>> >>>>> Cc: Badal Nilawar >>>>> Cc: Jani Nikula >>>>> Cc: Matthew Auld >>>>> Cc: John Harrison >>>>> Cc: Himal Prasad Ghimiray >>>>> Cc: Lucas De Marchi >>>>> Cc: # v6.11+ >>>>> Link: https://gitlab.freedesktop.org/drm/xe/kernel/-/issues/2754 >>>>> Suggested-by: Matthew Brost >>>>> Signed-off-by: Nirmoy Das >>>>> Reviewed-by: Matthew Brost >>>>> --- >>>>> drivers/gpu/drm/xe/xe_wait_user_fence.c | 14 ++++++++++++++ >>>>> 1 file changed, 14 insertions(+) >>>>> >>>>> diff --git a/drivers/gpu/drm/xe/xe_wait_user_fence.c b/drivers/gpu/drm/xe/xe_wait_user_fence.c >>>>> index f5deb81eba01..78a0ad3c78fe 100644 >>>>> --- a/drivers/gpu/drm/xe/xe_wait_user_fence.c >>>>> +++ b/drivers/gpu/drm/xe/xe_wait_user_fence.c >>>>> @@ -13,6 +13,7 @@ >>>>> #include "xe_device.h" >>>>> #include "xe_gt.h" >>>>> #include "xe_macros.h" >>>>> +#include "compat-i915-headers/i915_drv.h" >>>> Sorry, you just can't use this in xe core. At all. Not even a little >>>> bit. It's purely for i915 display compat code. >>>> >>>> If you need it for the LNL platform check, you need to use: >>>> >>>> xe->info.platform == XE_LUNARLAKE >>> Will do that. That macro looked odd but I didn't know a better way. >>> >>>> Although platform checks in xe code are generally discouraged. >>> This issue unfortunately depending on platform instead of graphics IP. >> But isn't this issue dependent upon the CPU platform not the graphics >> platform? As in, a DG2 card plugged in to a LNL host will also have this >> issue. So testing any graphics related value is technically incorrect. Haven't thought about. LNL only has x8 PCIe lanes shared between NVME and other IOs but thunderbolt based eGPU should be easily doable. I think I could do "if (boot_cpu_data.x86_vfm == INTEL_LUNARLAKE_M)" instead. >> > This is a good point, maybe for now we blindly do this regardless of > platform. It is basically harmless to do this after a timeout... Also a > warning message if we can detect this fixed the timeout for CI purposes. I am open to this as well. Please let me know which one should be a better solution here. Regards, Nirmoy > > Matt > >> John. >> >>> >>> Thanks, >>> >>> Nirmoy >>> >>>> BR, >>>> Jani. >>>> >>>> >>>> >>>>> #include "xe_exec_queue.h" >>>>> static int do_compare(u64 addr, u64 value, u64 mask, u16 op) >>>>> @@ -155,6 +156,19 @@ int xe_wait_user_fence_ioctl(struct drm_device *dev, void *data, >>>>> } >>>>> if (!timeout) { >>>>> + if (IS_LUNARLAKE(xe)) { >>>>> + /* >>>>> + * This is analogous to e51527233804 ("drm/xe/guc/ct: Flush g2h >>>>> + * worker in case of g2h response timeout") >>>>> + * >>>>> + * TODO: Drop this change once workqueue scheduling delay issue is >>>>> + * fixed on LNL Hybrid CPU. >>>>> + */ >>>>> + flush_workqueue(xe->ordered_wq); >>>>> + err = do_compare(addr, args->value, args->mask, args->op); >>>>> + if (err <= 0) >>>>> + break; >>>>> + } >>>>> err = -ETIME; >>>>> break; >>>>> }