Re: [RFC 12/12] drm/xe/vm: Add debug prints for SVM range prefetch

["Ghimiray, Himal Prasad" <himal.prasad.ghimiray@intel.com>]

On 10-03-2025 18:13, Himal Prasad Ghimiray wrote:
> Introduce debug logs for the prefetch operation of SVM ranges.
> 
> Signed-off-by: Himal Prasad Ghimiray <himal.prasad.ghimiray@intel.com>
> ---
>   drivers/gpu/drm/xe/xe_vm.c | 7 ++++++-
>   1 file changed, 6 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/xe/xe_vm.c b/drivers/gpu/drm/xe/xe_vm.c
> index a1607283a5fe..b2b0824b8777 100644
> --- a/drivers/gpu/drm/xe/xe_vm.c
> +++ b/drivers/gpu/drm/xe/xe_vm.c
> @@ -2372,6 +2372,7 @@ vm_bind_ioctl_ops_create(struct xe_vm *vm, struct xe_vma_ops *vops,
>   			xa_store(&op->prefetch_range.range, i, svm_range, GFP_KERNEL);
>   			op->prefetch_range.ranges_count++;
>   			vops->flags |= XE_VMA_OPS_HAS_SVM_PREFETCH;
> +			xe_svm_range_debug(svm_range, "PREFETCH - RANGE CREATED");
>   
>   			if (range_end > xe_svm_range_end(svm_range) &&
>   			    xe_svm_range_end(svm_range) < xe_vma_end(vma)) {
> @@ -2869,6 +2870,7 @@ static int prefetch_ranges_lock_and_prep(struct xe_vm *vm,
>   						vm->usm.asid, (u64)&vm->svm.gpusvm, err);
>   					return -ENODATA;
>   				}
> +				xe_svm_range_debug(svm_range, "PREFETCH - RANGE MIGRATED TO VRAM");
>   			}
>   
>   			err = xe_svm_range_get_pages(vm, svm_range, &ctx);
> @@ -2878,8 +2880,11 @@ static int prefetch_ranges_lock_and_prep(struct xe_vm *vm,
>   
>   				drm_err(&vm->xe->drm, "Get pages failed, asid=%u, gpusvm=0x%016llx, errno %d\n",
>   					vm->usm.asid, (u64)&vm->svm.gpusvm, err);
> -				return err;
> +				err = -ENODATA;
>   			}
> +			if (err)
> +				return err;

 > -				return err;
 > +				err = -ENODATA;
 >   			}
 > +			if (err)
 > +				return err;

not needed. will remove in next version.

> +			xe_svm_range_debug(svm_range, "PREFETCH - RANGE GET PAGES DONE");
>   		}
>   	}
>   	return err;