From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 7E2EDC54E67 for ; Thu, 28 Mar 2024 10:52:55 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 31F2810E3F1; Thu, 28 Mar 2024 10:52:55 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=arndb.de header.i=@arndb.de header.b="BLt9jvNz"; dkim=pass (2048-bit key; unprotected) header.d=messagingengine.com header.i=@messagingengine.com header.b="XS2xnBUC"; dkim-atps=neutral Received: from fhigh2-smtp.messagingengine.com (fhigh2-smtp.messagingengine.com [103.168.172.153]) by gabe.freedesktop.org (Postfix) with ESMTPS id 0B2B810E3F1 for ; Thu, 28 Mar 2024 10:52:53 +0000 (UTC) Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailfhigh.nyi.internal (Postfix) with ESMTP id 1323D11400DB; Thu, 28 Mar 2024 06:52:53 -0400 (EDT) Received: from imap51 ([10.202.2.101]) by compute5.internal (MEProxy); Thu, 28 Mar 2024 06:52:53 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=arndb.de; h=cc :cc:content-type:content-type:date:date:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:subject :subject:to:to; s=fm1; t=1711623173; x=1711709573; bh=pYSP327WQF DVmZr6n7v2NiEuO6ZV1nPOeivuxd5HieM=; b=BLt9jvNz5hthy4N8+5JykzYgPC RyR2Kt4srpR8FZvhqE9UwZolwjy9UkgDiU8jmpvrn+guG9q4ww72iOw1B3KSthtf nHLqJyI3829+aCC5BHGqFU05vCbXClHgFHJuBZa9QPacaLx7CpO0BSMx87Ap1YHw GUIjOQnl/3TMwsb4/O7Q60lBBRSUAayuhVbsDCb2HwaT66g8vqv+IJkHViaogjIi cEfTAg7S7n4LBhtI3Ija9tGw6Imk2IwfOdDb9pJc6dNYJheSz71+5/t1B3G9HreX B94kzTGzEnVXQJngAzZWGiKCPoRN8nvKMIjeufHCLPoJv8gpDMateEzqOKeg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:subject:subject:to :to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm2; t=1711623173; x=1711709573; bh=pYSP327WQFDVmZr6n7v2NiEuO6ZV 1nPOeivuxd5HieM=; b=XS2xnBUCepnAJHRLgcsCubXP1XsFjy6OOTVNxv+0P+76 ukUTzYGCbiDEDEM95MyJo21HL+0HhJiI4w5E+ccfhieJv0qbjNALiKdFHBD4G7I5 mJCV/A7ejDpfSuhJvrDJSv4HiLX1I54FhMJyZ6XSpYnL29cEpa+vJ5vvXx/6wPJ0 ZytjPwl5YQ2BGV2eIY6w9kcT9W/Shd2neMba8WyGisC3x1ccHPy2pCKOZ9Z+RaF4 7aakQtP8pfvSAq278waGWLjzOWYZDYRPXzOf7dOJ+roAEM+wIDP8Hfie57wCVLH0 sPjUcZ+22H6wJJuzPf+SdV/QsfC7aHr0Qg/d4EK52w== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvledrudduledgudelucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepofgfggfkjghffffhvfevufgtsehttdertderredtnecuhfhrohhmpedftehr nhguuceuvghrghhmrghnnhdfuceorghrnhgusegrrhhnuggsrdguvgeqnecuggftrfgrth htvghrnhepffehueegteeihfegtefhjefgtdeugfegjeelheejueethfefgeeghfektdek teffnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomheprg hrnhgusegrrhhnuggsrdguvg X-ME-Proxy: Feedback-ID: i56a14606:Fastmail Received: by mailuser.nyi.internal (Postfix, from userid 501) id C68DDB6008D; Thu, 28 Mar 2024 06:52:52 -0400 (EDT) X-Mailer: MessagingEngine.com Webmail Interface User-Agent: Cyrus-JMAP/3.11.0-alpha0-333-gbfea15422e-fm-20240327.001-gbfea1542 MIME-Version: 1.0 Message-Id: <84c264bb-0316-42eb-85d2-ddd8f8dbf1d4@app.fastmail.com> In-Reply-To: <87o7ayfxbh.fsf@intel.com> References: <20240328102455.944131-1-jani.nikula@intel.com> <87o7ayfxbh.fsf@intel.com> Date: Thu, 28 Mar 2024 11:52:32 +0100 From: "Arnd Bergmann" To: "Jani Nikula" , intel-gfx@lists.freedesktop.org, intel-xe@lists.freedesktop.org Cc: "Lucas De Marchi" Subject: Re: [PATCH] drm/i915: use fine grained -Woverride-init disable Content-Type: text/plain X-BeenThere: intel-xe@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel Xe graphics driver List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-xe-bounces@lists.freedesktop.org Sender: "Intel-xe" On Thu, Mar 28, 2024, at 11:46, Jani Nikula wrote: > On Thu, 28 Mar 2024, "Arnd Bergmann" wrote: >> On Thu, Mar 28, 2024, at 11:24, Jani Nikula wrote: >>> Use localized __diag_push(), __diag_ignore_all() with rationale, and >>> __diag_pop() for specific initializations instead of blanket disabling >>> of -Woverride-init across several files. >>> >>> Note that we've tried this before with commit 88e9664434c9 ("drm/i915: >>> use localized __diag_ignore_all() instead of per file") and reverted in >>> commit 290d16104575 ("Revert "drm/i915: use localized >>> __diag_ignore_all() instead of per file""). The issue turned out to be >>> in __diag_ignore_all() and it was fixed by commit 689b097a06ba >>> ("compiler-gcc: Suppress -Wmissing-prototypes warning for all supported >>> GCC"). So we should be able to pull this off now. >>> >>> Cc: "Arnd Bergmann" >>> Cc: Lucas De Marchi >>> Signed-off-by: Jani Nikula >> >> Looks good to me, >> >> Acked-by: Arnd Bergmann > > Thanks! I'll take this via drm-intel-next for v6.10. Up to you what to > do with your patch [1], either drop the i915 and xe changes, or we can > handle the trivial conflict too if keeping the changes helps you > somehow. I'll just drop all of the parts for drivers/gpu and send another patch for the amdgpu driver to do the same as your patch. Arnd