Re: [PATCH] drm/xe/guc: Fix version check for page-reclaim feature

[Daniele Ceraolo Spurio <daniele.ceraolospurio@intel.com>]

On 12/15/2025 9:04 AM, Michal Wajdeczko wrote:
> Page reclamation interfaces were introduced in GuC firmware version
> 70.31.0 (which corresponds to GuC ABI version 1.14.0), but since this
> feature is also available for the VFs and VFs don't know the firmware
> version, use GuC compatibility version check instead.
>
> Fixes: 77ebc7c10d16 ("drm/xe/guc: Add page reclamation interface to GuC")
> Signed-off-by: Michal Wajdeczko <michal.wajdeczko@intel.com>
> Cc: Brian Nguyen <brian3.nguyen@intel.com>
> Cc: Matthew Brost <matthew.brost@intel.com>
> Cc: Shuicheng Lin <shuicheng.lin@intel.com>

Reviewed-by: Daniele Ceraolo Spurio <daniele.ceraolospurio@intel.com>

Daniele

> ---
>   drivers/gpu/drm/xe/xe_guc.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/xe/xe_guc.c b/drivers/gpu/drm/xe/xe_guc.c
> index 7daae3294665..09ac092c3687 100644
> --- a/drivers/gpu/drm/xe/xe_guc.c
> +++ b/drivers/gpu/drm/xe/xe_guc.c
> @@ -768,7 +768,7 @@ int xe_guc_init(struct xe_guc *guc)
>   		return 0;
>   
>   	/* Disable page reclaim if GuC FW does not support */
> -	if (GUC_FIRMWARE_VER(guc) < MAKE_GUC_VER(70, 31, 0))
> +	if (GUC_SUBMIT_VER(guc) < MAKE_GUC_VER(1, 14, 0))
>   		xe->info.has_page_reclaim_hw_assist = false;
>   
>   	if (IS_SRIOV_VF(xe)) {