Re: [PATCH v4 1/3] drm/xe/vf: Enable VF migration only on supported GUC versions

[Michal Wajdeczko <michal.wajdeczko@intel.com>]

On 11/18/2025 12:41 PM, Satyanarayana K V P wrote:
> Enable VF migration starting with GUC 70.54.0 (compatibility version
> 1.27.0). Gate the feature on the GuC firmware version and keep it disabled
> on older or unsupported versions.

hmm, do we need this second sentence?

and please use "GuC" naming everywhere

> 
> Signed-off-by: Satyanarayana K V P <satyanarayana.k.v.p@intel.com>
> Cc: Michal Wajdeczko <michal.wajdeczko@intel.com>
> Cc: Matthew Brost <matthew.brost@intel.com>
> Cc: Tomasz Lis <tomasz.lis@intel.com>
> 
> ---
> V3 -> V4:
> - New commit
> 
> V2 -> V3:
> - None.
> 
> V1 -> V2:
> - None.
> ---
>  drivers/gpu/drm/xe/xe_sriov_vf.c | 12 ++++++++++++
>  1 file changed, 12 insertions(+)
> 
> diff --git a/drivers/gpu/drm/xe/xe_sriov_vf.c b/drivers/gpu/drm/xe/xe_sriov_vf.c
> index 284ce37ca92d..b73498097df5 100644
> --- a/drivers/gpu/drm/xe/xe_sriov_vf.c
> +++ b/drivers/gpu/drm/xe/xe_sriov_vf.c
> @@ -180,6 +180,18 @@ void xe_sriov_vf_init_early(struct xe_device *xe)
>   */
>  int xe_sriov_vf_init_late(struct xe_device *xe)
>  {
> +	struct xe_gt *gt = xe_root_mmio_gt(xe);
> +	struct xe_uc_fw_version guc_version;
> +
> +	xe_gt_sriov_vf_guc_versions(gt, NULL, &guc_version);
> +	if (MAKE_GUC_VER_STRUCT(guc_version) < MAKE_GUC_VER(1, 27, 0)) {
> +		xe_sriov_vf_migration_disable(xe,
> +					      "requires GUC ABI >= 1.27.0, but only %u.%u.%u found",
> +					      guc_version.major, guc_version.minor,
> +					      guc_version.patch);
> +		return 0;
> +	}

and move this code to the vf_migration_init_late() helper, like
we did in xe_sriov_vf_init_early() and vf_migration_init_early()

> +
>  	return xe_sriov_vf_ccs_init(xe);
>  }
>