From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 92075D3399E for ; Mon, 28 Oct 2024 16:36:33 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 5E5B610E510; Mon, 28 Oct 2024 16:36:33 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=intel.com header.i=@intel.com header.b="mAYB2V7s"; dkim-atps=neutral Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.13]) by gabe.freedesktop.org (Postfix) with ESMTPS id 7648E10E510 for ; Mon, 28 Oct 2024 16:36:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1730133393; x=1761669393; h=date:message-id:from:to:cc:subject:in-reply-to: references:mime-version; bh=lRA4coS4VvQXjSBy4sDjd0Bn4/FtKVlkuHePYaAhKGs=; b=mAYB2V7sgzrpVOrhP3nJKR/y9gse/S+W7UgMDAm4VyAlE2MplilCyvOd mhf3MOtJzfxlJkY0i56A3+f2fvSyKuAuTnHnW0nxrBzGXjA1hO3v2CFFm sl1CHaNd1eqM08ddlKHR19WHXVxNE9q4/SMmjcDkfxFwU+TNeO0TnLmyG hxBPPuEv89175gnGss0/WmywXYEj7rbZwkt3deVZ9Xe5Z0PwDWZhaNCDF mTZp+020arNSelP8hNdB6/3Nrs3pbrnP8fhOyLCbsLqowkRinmAUme+0I vNtbmaUpaKqCFLggrNTfkuHeqV8+Bcbxz/lRIQ8uGQhOUpjgEbYmKAx9t Q==; X-CSE-ConnectionGUID: DCUxftaITHCoIXrUXC9EHw== X-CSE-MsgGUID: PWOdrvYoTB29Oz80d4C/hQ== X-IronPort-AV: E=McAfee;i="6700,10204,11222"; a="40836450" X-IronPort-AV: E=Sophos;i="6.11,199,1725346800"; d="scan'208";a="40836450" Received: from orviesa008.jf.intel.com ([10.64.159.148]) by orvoesa105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 28 Oct 2024 09:36:33 -0700 X-CSE-ConnectionGUID: 8rqZ2eyiRXGL6p27hdAsgA== X-CSE-MsgGUID: t6iWll4VQZy2lMPNb+f8Zg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.11,239,1725346800"; d="scan'208";a="82481541" Received: from orsosgc001.jf.intel.com (HELO orsosgc001.intel.com) ([10.165.21.142]) by orviesa008-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 28 Oct 2024 09:36:33 -0700 Date: Mon, 28 Oct 2024 09:36:32 -0700 Message-ID: <854j4wtca7.wl-ashutosh.dixit@intel.com> From: "Dixit, Ashutosh" To: Jonathan Cavitt Cc: intel-xe@lists.freedesktop.org, saurabhg.gupta@intel.com, alex.zuo@intel.com, umesh.nerlige.ramappa@intel.com, john.c.harrison@intel.com, stable@vger.kernel.org Subject: Re: [PATCH v3] drm/xe/xe_guc_ads: save/restore OA registers In-Reply-To: <20241023200716.82624-1-jonathan.cavitt@intel.com> References: <20241023200716.82624-1-jonathan.cavitt@intel.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?ISO-8859-4?Q?Goj=F2?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/28.2 (x86_64-redhat-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-BeenThere: intel-xe@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel Xe graphics driver List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-xe-bounces@lists.freedesktop.org Sender: "Intel-xe" On Wed, 23 Oct 2024 13:07:15 -0700, Jonathan Cavitt wrote: > Hi Umesh, > @@ -748,6 +754,14 @@ static unsigned int guc_mmio_regset_write(struct xe_guc_ads *ads, > } > } > > + guc_mmio_regset_write_one(ads, regset_map, EU_PERF_CNTL0, count++); > + guc_mmio_regset_write_one(ads, regset_map, EU_PERF_CNTL1, count++); > + guc_mmio_regset_write_one(ads, regset_map, EU_PERF_CNTL2, count++); > + guc_mmio_regset_write_one(ads, regset_map, EU_PERF_CNTL3, count++); > + guc_mmio_regset_write_one(ads, regset_map, EU_PERF_CNTL4, count++); > + guc_mmio_regset_write_one(ads, regset_map, EU_PERF_CNTL5, count++); > + guc_mmio_regset_write_one(ads, regset_map, EU_PERF_CNTL6, count++); I am trying to understand how this works. So these registers are saved/restored by GuC because they are not part of HW context image and that is why GuC needs to do the save/restore? Bspec 46458/56839 do seem to be saying that these registers are context saved/restored? If that is indeed true (though not sure), do they need to be here? Thanks. -- Ashutosh