From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 94EF9C021A1 for ; Mon, 10 Feb 2025 17:31:21 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 5787F10E5E3; Mon, 10 Feb 2025 17:31:21 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=intel.com header.i=@intel.com header.b="K2O4oK7W"; dkim-atps=neutral Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.17]) by gabe.freedesktop.org (Postfix) with ESMTPS id 5D73910E5DC for ; Mon, 10 Feb 2025 17:31:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1739208680; x=1770744680; h=date:message-id:from:to:cc:subject:in-reply-to: references:mime-version; bh=RIWiM6N0OVSWg26WCzR2ckzAgfefB6MPU8k0hSb7iKY=; b=K2O4oK7WWBjQFerdhDd65wmGzg+tFvKrCsWR+qv+fCz1RZFCp5YpBzGD UqxBxEjT0AdGf2gKadPxL0kj2JhZ97f0V3oV/4RGjHpJqDurCcvY9yEXf N7JKsHMncCH90WFxc1u1qQdABJ8OxHYY3WMeigIkDVg+kdJZjwTE4yoLo AUWHxQzcWhoMmD1aJWFpcgf1nNudrBJN0kJupnbjZuMtjqu7cnuFSdZqS ajZilRxepe3dOWZRgCKYEBZ09upSnhlySlwOEpdn52K/eXX95B6cYRqo4 GtwRQdWgo8QuSbD98dqKMB15sbU2dY2iThs5C+SMzLNmpqrrFggbbsIqI g==; X-CSE-ConnectionGUID: +ivoVb4tQ0mWsMzPDCaxYA== X-CSE-MsgGUID: fAvVaNMWSyK3nvhG3rVFMA== X-IronPort-AV: E=McAfee;i="6700,10204,11341"; a="39688167" X-IronPort-AV: E=Sophos;i="6.13,275,1732608000"; d="scan'208";a="39688167" Received: from orviesa006.jf.intel.com ([10.64.159.146]) by fmvoesa111.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 Feb 2025 09:31:15 -0800 X-CSE-ConnectionGUID: NwSfGUd9SHi4e3ErEhYG5Q== X-CSE-MsgGUID: cSSoy6mlRba+6A2uhE35og== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.13,275,1732608000"; d="scan'208";a="112201271" Received: from orsosgc001.jf.intel.com (HELO orsosgc001.intel.com) ([10.165.21.142]) by orviesa006-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 Feb 2025 09:31:16 -0800 Date: Mon, 10 Feb 2025 09:31:15 -0800 Message-ID: <855xlh9064.wl-ashutosh.dixit@intel.com> From: "Dixit, Ashutosh" To: Harish Chegondi Cc: Subject: Re: [PATCH v9 1/8] drm/xe/topology: Add a function to find the index of the last enabled DSS in a mask In-Reply-To: <2bc4dab8887901e7514567bf5aadcab3c68ea776.1739193510.git.harish.chegondi@intel.com> References: <2bc4dab8887901e7514567bf5aadcab3c68ea776.1739193510.git.harish.chegondi@intel.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?ISO-8859-4?Q?Goj=F2?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/28.2 (x86_64-redhat-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-BeenThere: intel-xe@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel Xe graphics driver List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-xe-bounces@lists.freedesktop.org Sender: "Intel-xe" On Mon, 10 Feb 2025 05:46:42 -0800, Harish Chegondi wrote: > > +static inline unsigned int > +xe_gt_topology_mask_last_dss(const xe_dss_mask_t mask) > +{ > + return find_last_bit(mask, XE_MAX_DSS_FUSE_BITS); I am still wondering if this function should be in the .c instead, because we have not included linux/find.h where find_last_bit is declared, and if this might have problems of circular depenedencies in the future. Anyway, for now things are compiling so this is: Reviewed-by: Ashutosh Dixit > +} > + > unsigned int > xe_dss_mask_group_ffs(const xe_dss_mask_t mask, int groupsize, int groupnum); > > -- > 2.48.1 >