Re: [PATCH v4 08/13] drm/xe/pxp: Add userspace and LRC support for PXP-using queues

["Dixit, Ashutosh" <ashutosh.dixit@intel.com>]

On Mon, 06 Jan 2025 13:12:05 -0800, Daniele Ceraolo Spurio wrote:
>
> Userspace is required to mark a queue as using PXP to guarantee that the
> PXP instructions will work. In addition to managing the PXP sessions,
> when a PXP queue is created the driver will set the relevant bits in
> its context control register.
>
> On submission of a valid PXP queue, the driver will validate all
> encrypted objects mapped to the VM to ensured they were encrypted with
> the current key.
>
> v2: Remove pxp_types include outside of PXP code (Jani), better comments
> and code cleanup (John)
>
> v3: split the internal PXP management to a separate patch for ease of
> review. re-order ioctl checks to always return -EINVAL if parameters are
> invalid, rebase on msix changes.
>
> Signed-off-by: Daniele Ceraolo Spurio <daniele.ceraolospurio@intel.com>
> Cc: John Harrison <John.C.Harrison@Intel.com>
> ---
>  drivers/gpu/drm/xe/regs/xe_engine_regs.h |  1 +
>  drivers/gpu/drm/xe/xe_exec_queue.c       | 56 +++++++++++++++++++++++-
>  drivers/gpu/drm/xe/xe_exec_queue.h       |  5 +++
>  drivers/gpu/drm/xe/xe_exec_queue_types.h |  2 +
>  drivers/gpu/drm/xe/xe_execlist.c         |  2 +-
>  drivers/gpu/drm/xe/xe_lrc.c              | 18 ++++++--
>  drivers/gpu/drm/xe/xe_lrc.h              |  4 +-
>  drivers/gpu/drm/xe/xe_pxp.c              | 35 +++++++++++++--
>  drivers/gpu/drm/xe/xe_pxp.h              |  4 +-
>  include/uapi/drm/xe_drm.h                | 40 ++++++++++++++++-

I believe patches which touch 'include/uapi/drm/xe_drm.h' should be titled
"drm/xe/pxp/uapi: foo" or "drm/xe/uapi: foo".