From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B5963C4345F for ; Tue, 23 Apr 2024 15:21:36 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 69BDC11344A; Tue, 23 Apr 2024 15:21:36 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=intel.com header.i=@intel.com header.b="F6jDOuJ5"; dkim-atps=neutral Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.19]) by gabe.freedesktop.org (Postfix) with ESMTPS id C717811344F for ; Tue, 23 Apr 2024 15:21:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1713885694; x=1745421694; h=date:message-id:from:to:cc:subject:in-reply-to: references:mime-version; bh=zn4yYSGVvzxJ6i6EpmS8SuYhNUTC4YnkeVs/EkEtM4c=; b=F6jDOuJ5p50ueuP3bv3JAbNJ59UDU+qaCIwO69wey85NRjzk5FC/t3kU XpPHfb6qpgzuq4UMVBSNbPtG4nWRX2sYIC8fmjeCs9fVsZYw9D5gqXdIY f235OSgV7LKfeX29LyfJ3Iy0zO9Osketjo+dXifTAlCk9Tb+gPtDdIu0s Sif56VFB7oJSWgYB+iOcI0YujgPrrabtQdU9yfVhoMOoL6+LTW86lxdTk 1vaL0TVtKUPZwcYkI/rbezd4AzZQeHF91BrPn2MQ1DN6PovbsfGN2lZ+n AdXl9eGSesMI05+vM3ey13RUAG9bz6smI/fpTnTdOHYlX6huM2PdzPlpM g==; X-CSE-ConnectionGUID: //TiksowQhKWX1FNWjRzKw== X-CSE-MsgGUID: s99HMygHRUWByMGft4vVBw== X-IronPort-AV: E=McAfee;i="6600,9927,11053"; a="9350101" X-IronPort-AV: E=Sophos;i="6.07,222,1708416000"; d="scan'208";a="9350101" Received: from orviesa009.jf.intel.com ([10.64.159.149]) by orvoesa111.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 Apr 2024 08:21:34 -0700 X-CSE-ConnectionGUID: nQcUFknmSVGEf15HMIh5rA== X-CSE-MsgGUID: NZ5T5nXZRXGBrYBig2I00g== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.07,222,1708416000"; d="scan'208";a="24375284" Received: from orsosgc001.jf.intel.com (HELO orsosgc001.intel.com) ([10.165.21.138]) by orviesa009-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 Apr 2024 08:21:35 -0700 Date: Tue, 23 Apr 2024 08:21:34 -0700 Message-ID: <855xw8m7ep.wl-ashutosh.dixit@intel.com> From: "Dixit, Ashutosh" To: Himal Prasad Ghimiray Cc: intel-xe@lists.freedesktop.org, Matthew Brost Subject: Re: [PATCH] drm/xe/vm: Use xe_vm_lock() helper for locking In-Reply-To: <20240423070332.2036539-1-himal.prasad.ghimiray@intel.com> References: <20240423070332.2036539-1-himal.prasad.ghimiray@intel.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?ISO-8859-4?Q?Goj=F2?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/28.2 (x86_64-redhat-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-BeenThere: intel-xe@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel Xe graphics driver List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-xe-bounces@lists.freedesktop.org Sender: "Intel-xe" On Tue, 23 Apr 2024 00:03:32 -0700, Himal Prasad Ghimiray wrote: > Hi Himal, > There is no change in functionality. Using the helper function > defined within the driver. > > Cc: Matthew Brost > Signed-off-by: Himal Prasad Ghimiray > --- > drivers/gpu/drm/xe/xe_vm.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/xe/xe_vm.c b/drivers/gpu/drm/xe/xe_vm.c > index 85d6f359142d..e9c8dc6d7b83 100644 > --- a/drivers/gpu/drm/xe/xe_vm.c > +++ b/drivers/gpu/drm/xe/xe_vm.c > @@ -1279,7 +1279,7 @@ struct xe_vm *xe_vm_create(struct xe_device *xe, u32 flags) > > drm_gem_object_put(vm_resv_obj); > > - err = dma_resv_lock_interruptible(xe_vm_resv(vm), NULL); > + err = xe_vm_lock(vm, true); > if (err) > goto err_close; But isn't dma_resv_lock coupled with dma_resv_unlock? So that should also be changed, if at all? And what about other places in Xe which still contain dma_resv_lock_interruptible? Ashutosh