From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id EC6C4C4725D for ; Sat, 20 Jan 2024 02:36:38 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id A213410EAE5; Sat, 20 Jan 2024 02:36:38 +0000 (UTC) Received: from mgamail.intel.com (mgamail.intel.com [134.134.136.31]) by gabe.freedesktop.org (Postfix) with ESMTPS id 3759610EAED for ; Sat, 20 Jan 2024 02:36:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1705718198; x=1737254198; h=date:message-id:from:to:cc:subject:in-reply-to: references:mime-version; bh=YhUWETniWf+G/nTybIa/LkKm0tyuY9Nt8y6h375M9c8=; b=jC8wyG9Aimehhd56bJ0QRK+qu1gYquDJF6tO34n2Wce8tulWJLQPVixr qHajaGg2+7izAM1HdBdiuKR2jtZU84BiyLsZdifdjYGWqH9+DNQ8v8NEF goQkEePY16ih+9qJKe4gV0m1ZRvTAx9pRlmc/2aN5B6mYHICmayB+J3PQ tCII0AlQFc6a41Q4jshgntrYNQxvnaPsAOu7GLgj0yFw/COqBTS4MjBVf LIxA9fewFUxnvbO1w194A/6ewl7um5WfiZpxUK+64Z+PV3VeEaFmFyNfX nSNxn+09c8q8w+csI9RZWYid8csMr3oHEG6m/i3EzL7TYND7NsmacP95z Q==; X-IronPort-AV: E=McAfee;i="6600,9927,10957"; a="465173532" X-IronPort-AV: E=Sophos;i="6.05,206,1701158400"; d="scan'208";a="465173532" Received: from orviesa003.jf.intel.com ([10.64.159.143]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Jan 2024 18:36:37 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.05,206,1701158400"; d="scan'208";a="749694" Received: from orsosgc001.jf.intel.com (HELO unerlige-ril.intel.com) ([10.165.21.138]) by ORVIESA003-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Jan 2024 18:36:38 -0800 Date: Fri, 19 Jan 2024 18:36:37 -0800 Message-ID: <855xzod93e.wl-ashutosh.dixit@intel.com> From: "Dixit, Ashutosh" To: Umesh Nerlige Ramappa Subject: Re: [PATCH 03/17] drm/xe/oa/uapi: Add oa_max_sample_rate sysctl In-Reply-To: References: <20231208064329.2387604-1-ashutosh.dixit@intel.com> <20231208064329.2387604-4-ashutosh.dixit@intel.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?ISO-8859-4?Q?Goj=F2?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/28.2 (x86_64-redhat-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-BeenThere: intel-xe@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel Xe graphics driver List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: intel-xe@lists.freedesktop.org Errors-To: intel-xe-bounces@lists.freedesktop.org Sender: "Intel-xe" On Wed, 13 Dec 2023 16:58:52 -0800, Umesh Nerlige Ramappa wrote: > > > --- a/drivers/gpu/drm/xe/xe_device.c > > +++ b/drivers/gpu/drm/xe/xe_device.c > > @@ -29,6 +29,7 @@ > > #include "xe_irq.h" > > #include "xe_mmio.h" > > #include "xe_module.h" > > +#include "xe_oa.h" > > #include "xe_pat.h" > > #include "xe_pcode.h" > > #include "xe_perf.h" > > @@ -480,6 +481,10 @@ int xe_device_probe(struct xe_device *xe) > > > > xe_heci_gsc_init(xe); > > > > + err = xe_oa_init(xe); > > + if (err) > > + goto err_irq_shutdown; > > + > > err = xe_display_init(xe); > > if (err) > > goto err_irq_shutdown; > > ^ this needs to do an xe_oa_fini on failure, so should be a different/new > goto label. Good point, fixed in v8. Though the "drm/xe/oa/uapi: Add oa_max_sample_rate sysctl" patch is gone in v8, so the change has been made in "drm/xe/oa/uapi: Add OA data formats".