From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 1D2E2D111A7 for ; Wed, 26 Nov 2025 23:08:40 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id D85D110E748; Wed, 26 Nov 2025 23:08:39 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=intel.com header.i=@intel.com header.b="Ey3k+P1P"; dkim-atps=neutral Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.8]) by gabe.freedesktop.org (Postfix) with ESMTPS id 2CC8C10E748 for ; Wed, 26 Nov 2025 23:08:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1764198518; x=1795734518; h=date:message-id:from:to:cc:subject:in-reply-to: references:mime-version; bh=l4xrmZqzxDAhvt19VajOR/ypI4yfy+j3Bslw+9Lx0aw=; b=Ey3k+P1P1SxoghhumNtryJd9YZoiZVe1SvUPG+VuVdJC4BrGDWb/NkIU 9qoMGvcc0nue1xNEGsimL8MtriI5b3XJIVtR2sJTGpoiiEDFKTc6wPb7J 6KUxSkEzgi34YswwZddQDAxu18M38Q8oLpdrMItp36CGZvHWAmUE9ztoq tKPTzL9/SspULDu7H4BPuRQ82kriROib9lZI0/Zpdfp2a074iHeWAblkC 7lLGF89dHDib2fuGxI+jWH4GqZu5aP/YbirfQ+Qrzc3qpAocLa67SZlVK cayBle6cUgMlnuHaJIQd9rBiBcurkIitPWZ7qWbnWOlS2KIy2AYUCCsdf w==; X-CSE-ConnectionGUID: Q00w6mxtRjGbVViH1PMP4A== X-CSE-MsgGUID: o3I9Oo0UQDiR9KrKE0cO0g== X-IronPort-AV: E=McAfee;i="6800,10657,11625"; a="83853041" X-IronPort-AV: E=Sophos;i="6.20,229,1758610800"; d="scan'208";a="83853041" Received: from fmviesa009.fm.intel.com ([10.60.135.149]) by fmvoesa102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 26 Nov 2025 15:08:38 -0800 X-CSE-ConnectionGUID: y+G3Hn6uQeqZ2b+DxNDFMA== X-CSE-MsgGUID: HiKxCXoyTFKMdvKabquWVw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.20,229,1758610800"; d="scan'208";a="193528444" Received: from orsosgc001.jf.intel.com (HELO orsosgc001.intel.com) ([10.88.27.185]) by fmviesa009-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 26 Nov 2025 15:08:36 -0800 Date: Wed, 26 Nov 2025 15:08:33 -0800 Message-ID: <857bvc5r4e.wl-ashutosh.dixit@intel.com> From: "Dixit, Ashutosh" To: Matthew Brost Cc: , Umesh Nerlige Ramappa Subject: Re: [PATCH 2/5] drm/xe/oa/uapi: Add gt_id to struct drm_xe_oa_unit In-Reply-To: References: <20251126035220.13089-1-ashutosh.dixit@intel.com> <20251126035220.13089-3-ashutosh.dixit@intel.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?ISO-8859-4?Q?Goj=F2?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/30.2 (x86_64-redhat-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-BeenThere: intel-xe@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel Xe graphics driver List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-xe-bounces@lists.freedesktop.org Sender: "Intel-xe" On Wed, 26 Nov 2025 12:42:53 -0800, Matthew Brost wrote: > > > diff --git a/include/uapi/drm/xe_drm.h b/include/uapi/drm/xe_drm.h > > index 47853659a705e..ec09b281eafe7 100644 > > --- a/include/uapi/drm/xe_drm.h > > +++ b/include/uapi/drm/xe_drm.h > > @@ -1676,12 +1676,16 @@ struct drm_xe_oa_unit { > > #define DRM_XE_OA_CAPS_OA_BUFFER_SIZE (1 << 2) > > #define DRM_XE_OA_CAPS_WAIT_NUM_REPORTS (1 << 3) > > #define DRM_XE_OA_CAPS_OAM (1 << 4) > > +#define DRM_XE_OA_CAPS_OA_UNIT_GT_ID (1 << 5) > > > > /** @oa_timestamp_freq: OA timestamp freq */ > > __u64 oa_timestamp_freq; > > > > + /** @gt_id: gt id for this OA unit */ > > + __u64 gt_id; > > u64 seems like overkill. Maybe a u32 or u16 to save some bits for the future? Sure, will change to u16 before merging. > > > + > > /** @reserved: MBZ */ > > - __u64 reserved[4]; > > + __u64 reserved[3]; > > > > /** @num_engines: number of engines in @eci array */ > > __u64 num_engines; > > -- > > 2.48.1 > >