From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id BCA10E77188 for ; Wed, 8 Jan 2025 17:11:27 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 8423610E903; Wed, 8 Jan 2025 17:11:27 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=intel.com header.i=@intel.com header.b="QNhI9dq/"; dkim-atps=neutral Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.18]) by gabe.freedesktop.org (Postfix) with ESMTPS id C90CD10EC22; Wed, 8 Jan 2025 17:11:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1736356287; x=1767892287; h=date:message-id:from:to:cc:subject:in-reply-to: references:mime-version; bh=UkbL9CwMQ1SSeHtkWKDMAl+XUfWdl5GTtLu1RuEo36c=; b=QNhI9dq/LGkVqEFnf4U6wU/0QdCHCXrVLv23729LiuB6RrGAnhJj7OGj osk2tx5TzNh3G/pvTdonbHc+dbtvW61ga/hy8Q1bYCCJdxDRPhq012hnr WvCm/p/zu6rltKw4llFLDFRW0XyWPPp9SF0qbBZI0fgXSmzGX7YfEV1rw YlifiLwu/+8OwcKSUzHFuOXxPfTXzP/JS5wfgtdlgJszV13ph/oPSD1gW EMCSyszHeZ4xzNBQB8Ktn7XhZsqh1WHym9HAUMSkyZyztLQaW1h3XtHCP rlpgp4miEoKVABMmoWg0ABhuJU2KQLA0Zb07Fuxpjb4JaM9uAnZn7Qy/T g==; X-CSE-ConnectionGUID: Mp6HJg6PQviVgkqc1c5V3g== X-CSE-MsgGUID: gPDmjMdfQWWWqYK3lMHpPg== X-IronPort-AV: E=McAfee;i="6700,10204,11309"; a="36708806" X-IronPort-AV: E=Sophos;i="6.12,298,1728975600"; d="scan'208";a="36708806" Received: from orviesa010.jf.intel.com ([10.64.159.150]) by orvoesa110.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 Jan 2025 09:11:27 -0800 X-CSE-ConnectionGUID: VVkA8sfRT2KOcEa5X0cTLA== X-CSE-MsgGUID: kJG04WAHRXCsWfLa2ZSpuw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.12,224,1728975600"; d="scan'208";a="103019333" Received: from orsosgc001.jf.intel.com (HELO orsosgc001.intel.com) ([10.165.21.142]) by orviesa010-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 Jan 2025 09:11:26 -0800 Date: Wed, 08 Jan 2025 09:11:26 -0800 Message-ID: <857c75b58h.wl-ashutosh.dixit@intel.com> From: "Dixit, Ashutosh" To: Tejas Upadhyay Cc: intel-xe@lists.freedesktop.org, dri-devel@lists.freedesktop.org, badal.nilawar@intel.com, vinay.belgaumkar@intel.com Subject: Re: [RFC PATCH 2/2] drm/uapi: Adjust uniform spacing In-Reply-To: <20250108150603.2995709-3-tejas.upadhyay@intel.com> References: <20250108150603.2995709-1-tejas.upadhyay@intel.com> <20250108150603.2995709-3-tejas.upadhyay@intel.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?ISO-8859-4?Q?Goj=F2?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/28.2 (x86_64-redhat-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-BeenThere: intel-xe@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel Xe graphics driver List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-xe-bounces@lists.freedesktop.org Sender: "Intel-xe" On Wed, 08 Jan 2025 07:06:03 -0800, Tejas Upadhyay wrote: > > Extensions in exec queue creation formatted to have uniform > spacing in defines. > > Signed-off-by: Tejas Upadhyay > --- > include/uapi/drm/xe_drm.h | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/include/uapi/drm/xe_drm.h b/include/uapi/drm/xe_drm.h > index 62447f5422d8..868dac05c100 100644 > --- a/include/uapi/drm/xe_drm.h > +++ b/include/uapi/drm/xe_drm.h > @@ -1108,9 +1108,9 @@ struct drm_xe_vm_bind { > * > */ > struct drm_xe_exec_queue_create { > -#define DRM_XE_EXEC_QUEUE_EXTENSION_SET_PROPERTY 0 > -#define DRM_XE_EXEC_QUEUE_SET_PROPERTY_PRIORITY 0 > -#define DRM_XE_EXEC_QUEUE_SET_PROPERTY_TIMESLICE 1 > +#define DRM_XE_EXEC_QUEUE_EXTENSION_SET_PROPERTY 0 > +#define DRM_XE_EXEC_QUEUE_SET_PROPERTY_PRIORITY 0 > +#define DRM_XE_EXEC_QUEUE_SET_PROPERTY_TIMESLICE 1 This is wrong. For the lower 2 #define's are sub-property types of set_property. The original code is correct.