From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9576EC48260 for ; Thu, 8 Feb 2024 22:26:43 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 54CD110EF3B; Thu, 8 Feb 2024 22:26:43 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=intel.com header.i=@intel.com header.b="OShLFZPf"; dkim-atps=neutral Received: from mgamail.intel.com (mgamail.intel.com [192.55.52.88]) by gabe.freedesktop.org (Postfix) with ESMTPS id 3308810EF3B for ; Thu, 8 Feb 2024 22:26:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1707431201; x=1738967201; h=date:message-id:from:to:cc:subject:in-reply-to: references:mime-version; bh=n/qMPJST+UgL8qzEO5ikJc3qySMsH+KYA77JqeMsD5M=; b=OShLFZPfRpfh2FhEWHR09zchIfRX9wD7wZOVLfXSoFyQLJJ+/rNt2w/J riEi7I32R5xJovpd3sP2jjDK6Lc4OxDjqC/jVtEm4cXkLZZIs/HO5yfvX 5XZQF/fgeeQJ85vwvIN+96u9B5EbFTO50YPL0QyD0Vdo2ZRCUvFT5Uery 1n3ZzojrxXU24vC4TEivn65V9ZkvjaUi+NXAlAv6iImmggyDdauUGxYWX bwtAZcEJFESadI81VCyOd0a84r+uJrNNDcKp8mXMQ5OnfdloLLu1OF9m5 2wT0aWLuUmM1LaVmLz2IWk+mKYeQH/sfl5eo2n68UQHbIcKtwLvN6/E4L w==; X-IronPort-AV: E=McAfee;i="6600,9927,10978"; a="436462918" X-IronPort-AV: E=Sophos;i="6.05,255,1701158400"; d="scan'208";a="436462918" Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 Feb 2024 14:26:40 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10978"; a="934267659" X-IronPort-AV: E=Sophos;i="6.05,255,1701158400"; d="scan'208";a="934267659" Received: from orsosgc001.jf.intel.com (HELO unerlige-ril.intel.com) ([10.165.21.138]) by fmsmga001-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 Feb 2024 14:26:39 -0800 Date: Thu, 08 Feb 2024 14:26:39 -0800 Message-ID: <857cjewq1s.wl-ashutosh.dixit@intel.com> From: "Dixit, Ashutosh" To: Lionel Landwerlin Cc: intel-xe@lists.freedesktop.org, Umesh Nerlige Ramappa Subject: Re: [PATCH 06/16] drm/xe/oa/uapi: Define and parse OA stream properties In-Reply-To: <1c3fef48-f59b-440a-bfb7-275fb5f5d57d@intel.com> References: <20240208054916.3788133-1-ashutosh.dixit@intel.com> <20240208054916.3788133-7-ashutosh.dixit@intel.com> <1c3fef48-f59b-440a-bfb7-275fb5f5d57d@intel.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?ISO-8859-4?Q?Goj=F2?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/28.2 (x86_64-redhat-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-BeenThere: intel-xe@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel Xe graphics driver List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-xe-bounces@lists.freedesktop.org Sender: "Intel-xe" On Thu, 08 Feb 2024 13:40:29 -0800, Lionel Landwerlin wrote: Hi Lionel, > + > + /** @DRM_XE_OA_PROPERTY_OA_FORMAT: Perf counter report format */ > + DRM_XE_OA_PROPERTY_OA_FORMAT, > + /** > + * OA_FORMAT's are specified the same way as in Bspec, in terms of > + * the following quantities: a. enum @drm_xe_oa_format_type > + * b. Counter select c. Counter size and d. BC report > + */ > +#define DRM_XE_OA_FORMAT_MASK_FMT_TYPE (0xff << 0) > +#define DRM_XE_OA_FORMAT_MASK_COUNTER_SEL (0xff << 8) > +#define DRM_XE_OA_FORMAT_MASK_COUNTER_SIZE (0xff << 16) > +#define DRM_XE_OA_FORMAT_MASK_BC_REPORT (0xff << 24) > > People outside of Intel don't have access to the BSpec. Hmm, I was assuming Bspec is public, at least parts of it. Since we keep dropping Bspec references in patch commit messages? > > And since there is no page number either Page numbers are in the commit message, but you are right, they should be added here. > , it would just be easier for everybody to say : > > "Refer to the oa_formats array in drivers/gpu/drm/xe/xe_oa.c" Umesh, what do you think about this? I don't like the idea too much, of referring to the internal implementation in the uapi, but if Bspec is not public, and we want to keep this uapi, we'll probably need to do this. Also, we are directly returning the oa_status register in response to DRM_XE_PERF_IOCTL_STATUS ioctl (see 'struct drm_xe_oa_stream_status'), so that also needs access to Bspec. But there I think we can just document the relevant bits in xe_drm.h. Thanks. -- Ashutosh