From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A2B28C27C53 for ; Wed, 19 Jun 2024 22:10:27 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 3BA1D10E296; Wed, 19 Jun 2024 22:10:27 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=intel.com header.i=@intel.com header.b="EwLtROGa"; dkim-atps=neutral Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.18]) by gabe.freedesktop.org (Postfix) with ESMTPS id 0D88510E296 for ; Wed, 19 Jun 2024 22:10:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1718835027; x=1750371027; h=date:message-id:from:to:cc:subject:in-reply-to: references:mime-version; bh=r7VuVG+VrUY4LhZL0O02JUN1r2na72c/VaU0bRstYFg=; b=EwLtROGaCa7FmAMjk7kKvKa95py0z1YtEfl2tjMQaPl5f+grBo8KnIER vpyoulDFCjVQ7W/U+h2Ht0G3u+jop9yZ7xn9XBqldU0MHb/l+loICipGt 38jwn3oLknH9UYWxTKhUOBmB/2ajickZP6u32HMRtcjs1b5HmMsJ3NvNK 8MpTudJsJIqkMYLKXS1Lm1ced/60696deZ/N1oOpB3cjwd3MyWPP/x1QE zcLDobqIMGcdztKCKtBxd1ibP0nPA0ZmyzlDl4XDD+n78Lh0U0bOZr9tY 1soN17cycC+3k9mM3TDzPWL6R/izxay4BgMkrMpU5I6lrgvUsnoLnH4OS w==; X-CSE-ConnectionGUID: /5ixa+bNR2ie72bQb5HSTg== X-CSE-MsgGUID: 5a1/qrt3Q82biBqu39AKnQ== X-IronPort-AV: E=McAfee;i="6700,10204,11108"; a="15929529" X-IronPort-AV: E=Sophos;i="6.08,251,1712646000"; d="scan'208";a="15929529" Received: from orviesa002.jf.intel.com ([10.64.159.142]) by orvoesa110.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Jun 2024 15:10:26 -0700 X-CSE-ConnectionGUID: L7vvcObaRAm4J4U+c9SEFw== X-CSE-MsgGUID: PR98GeJFT6aTZzcnIAy+VQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.08,251,1712646000"; d="scan'208";a="72785140" Received: from orsosgc001.jf.intel.com (HELO orsosgc001.intel.com) ([10.165.21.138]) by orviesa002-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Jun 2024 15:10:26 -0700 Date: Wed, 19 Jun 2024 15:10:25 -0700 Message-ID: <858qz0r3ce.wl-ashutosh.dixit@intel.com> From: "Dixit, Ashutosh" To: Michal Wajdeczko Cc: intel-xe@lists.freedesktop.org Subject: Re: [PATCH 5/9] drm/xe/vf: Don't initialize OA if VF In-Reply-To: <85a5jgr3zj.wl-ashutosh.dixit@intel.com> References: <20240619214557.905-1-michal.wajdeczko@intel.com> <20240619214557.905-6-michal.wajdeczko@intel.com> <85a5jgr3zj.wl-ashutosh.dixit@intel.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?ISO-8859-4?Q?Goj=F2?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/28.2 (x86_64-redhat-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-BeenThere: intel-xe@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel Xe graphics driver List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-xe-bounces@lists.freedesktop.org Sender: "Intel-xe" On Wed, 19 Jun 2024 14:56:32 -0700, Dixit, Ashutosh wrote: > > On Wed, 19 Jun 2024 14:45:53 -0700, Michal Wajdeczko wrote: > > > > We don't support Observation Architecture on the VF device. > > > > Signed-off-by: Michal Wajdeczko > > Cc: Rodrigo Vivi > > Cc: Ashutosh Dixit > > --- > > drivers/gpu/drm/xe/xe_oa.c | 4 ++++ > > 1 file changed, 4 insertions(+) > > > > diff --git a/drivers/gpu/drm/xe/xe_oa.c b/drivers/gpu/drm/xe/xe_oa.c > > index 34206e0b6a08..f54a97954452 100644 > > --- a/drivers/gpu/drm/xe/xe_oa.c > > +++ b/drivers/gpu/drm/xe/xe_oa.c > > @@ -35,6 +35,7 @@ > > #include "xe_perf.h" > > #include "xe_pm.h" > > #include "xe_sched_job.h" > > +#include "xe_sriov.h" > > > > #define DEFAULT_POLL_FREQUENCY_HZ 200 > > #define DEFAULT_POLL_PERIOD_NS (NSEC_PER_SEC / DEFAULT_POLL_FREQUENCY_HZ) > > @@ -2385,6 +2386,9 @@ int xe_oa_init(struct xe_device *xe) > > if (XE_WARN_ON(!xe_device_uc_enabled(xe)) || XE_WARN_ON(GRAPHICS_VER(xe) < 12)) > > return 0; > > > > + if (IS_SRIOV_VF(xe)) > > + return 0; > > + > > Do we want to add XE_WARN_ON's Though maybe not, if we don't want to see the WARN_ON when loading the VF driver... > or combine this if statement with the previous one? > > In any case: > > Reviewed-by: Ashutosh Dixit > > > > oa->xe = xe; > > oa->oa_formats = oa_formats; > > > > -- > > 2.43.0 > >