From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 30E51C4828F for ; Thu, 8 Feb 2024 21:56:13 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id C4FDB10EE9C; Thu, 8 Feb 2024 21:56:12 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=intel.com header.i=@intel.com header.b="Jaban7Fs"; dkim-atps=neutral Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.10]) by gabe.freedesktop.org (Postfix) with ESMTPS id 8A7C810E359 for ; Thu, 8 Feb 2024 21:56:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1707429371; x=1738965371; h=date:message-id:from:to:cc:subject:in-reply-to: references:mime-version; bh=2TDFwhVXPQeIDg1c3DU6Z5jDoyw8MtiIeJhmI8rF/MQ=; b=Jaban7FsAoeXrIlrxt0vfPnBOp9ZqYKEG1wtt6g521tIygFSK6YDGC3O 7f2rLe4VNe7l0nPUAtqq4aiwO3zFBDOYsRqsR8gcObvl3mOJUXhjSUM6L vCeOt8ajSSEwVWJpYG3IpvlMG+lAXGtp9JsP/LScjMm2pFxIqUThm8Fvl u5dH7iaGi5At9DV2N06uge8Vpp+BdobWkGpXdjSONaRgtUcoLe3dHjD6e TE8Gqmqtu94LKudmDAvEExkXXV6UTyzlaABJZ+hhNpQLcC5y7QW/6bUSe Go/6FLgT4Ipz7Hy+0TVP9aI42TcIML1wmTed3LYtOVCAawXDTr/XSdiDq Q==; X-IronPort-AV: E=McAfee;i="6600,9927,10978"; a="18740970" X-IronPort-AV: E=Sophos;i="6.05,254,1701158400"; d="scan'208";a="18740970" Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orvoesa102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 Feb 2024 13:56:05 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10978"; a="824963608" X-IronPort-AV: E=Sophos;i="6.05,254,1701158400"; d="scan'208";a="824963608" Received: from orsosgc001.jf.intel.com (HELO unerlige-ril.intel.com) ([10.165.21.138]) by orsmga001-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 Feb 2024 13:56:04 -0800 Date: Thu, 08 Feb 2024 13:56:04 -0800 Message-ID: <858r3uwrgr.wl-ashutosh.dixit@intel.com> From: "Dixit, Ashutosh" To: Lionel Landwerlin Cc: Subject: Re: [PATCH 00/16] Add OA functionality to Xe In-Reply-To: <48da0dc4-692d-4337-be0d-889027a9f5e1@intel.com> References: <20240208054916.3788133-1-ashutosh.dixit@intel.com> <48da0dc4-692d-4337-be0d-889027a9f5e1@intel.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?ISO-8859-4?Q?Goj=F2?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/28.2 (x86_64-redhat-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-BeenThere: intel-xe@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel Xe graphics driver List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-xe-bounces@lists.freedesktop.org Sender: "Intel-xe" On Thu, 08 Feb 2024 13:34:42 -0800, Lionel Landwerlin wrote: > Hi Lionel, > Just looked at the series and I'm not seeing a way to reconfigure the OA > unit with a different config once the stream is opened. > Was this feature removed? No, it's still there. Search for 'xe_oa_config_locked' here: https://patchwork.freedesktop.org/patch/577445/?series=121084&rev=9 In Xe, because there are multiple stream types, we have a PERF layer. OA is one of the stream types. So these operations are part of the PERF layer now: /** * enum drm_xe_perf_ioctls - Perf fd ioctl's * * Information exchanged between userspace and kernel for perf fd ioctl's * is stream type specific */ enum drm_xe_perf_ioctls { /** @DRM_XE_PERF_IOCTL_ENABLE: Enable data capture for a stream */ DRM_XE_PERF_IOCTL_ENABLE = _IO('i', 0x0), /** @DRM_XE_PERF_IOCTL_DISABLE: Disable data capture for a stream */ DRM_XE_PERF_IOCTL_DISABLE = _IO('i', 0x1), /** @DRM_XE_PERF_IOCTL_CONFIG: Change stream configuration */ DRM_XE_PERF_IOCTL_CONFIG = _IO('i', 0x2), /** @DRM_XE_PERF_IOCTL_STATUS: Return stream status */ DRM_XE_PERF_IOCTL_STATUS = _IO('i', 0x3), /** @DRM_XE_PERF_IOCTL_INFO: Return stream info */ DRM_XE_PERF_IOCTL_INFO = _IO('i', 0x4), }; Thanks. -- Ashutosh