From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 67F00D6DDFA for ; Fri, 15 Nov 2024 13:48:52 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 2D31B10E05B; Fri, 15 Nov 2024 13:48:52 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=intel.com header.i=@intel.com header.b="fpPuffYv"; dkim-atps=neutral Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.14]) by gabe.freedesktop.org (Postfix) with ESMTPS id 81DB310E05B for ; Fri, 15 Nov 2024 13:48:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1731678530; x=1763214530; h=date:message-id:from:to:cc:subject:in-reply-to: references:mime-version; bh=xIC9JQRUhPZ3M6pX8GpLZFyRKbmxK0Oo5H9S2UtFe+Q=; b=fpPuffYv8TA90n42Yu33SoorX4uipO+3n0zW6C/7wig6+rOSUvex7aLL JnqgPuzq68gBl96IryFqrX21u+kpLfkvQR28y+TveHeh2uU83Pb3ZOT5j dNkFEBRGDmHp5MHyHLUxc9cYoJY+wT9ea1TltaXAyi2g9Ze3DurZE6asd bWbl3Z+7n63w0oeV4Jod6UE0dScOl2sAD6/i6dibykJlCdXWbaVePaOZF Y/g7H8K3yds0lpXEyaK2IsuhrtQnR+/2L2HIEuUi0YnrDmI8g9zu6Mhu1 HmEQnGnAZD3aD+Zc/wAH3szshGhYzpGkxjGsYz8FF/46xQh5tYOEMmqyB g==; X-CSE-ConnectionGUID: KYK+uthvTxq2sahGG5Nwrg== X-CSE-MsgGUID: 3zD5dLtTQzal16idXt4nCw== X-IronPort-AV: E=McAfee;i="6700,10204,11257"; a="31937489" X-IronPort-AV: E=Sophos;i="6.12,156,1728975600"; d="scan'208";a="31937489" Received: from orviesa001.jf.intel.com ([10.64.159.141]) by fmvoesa108.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 15 Nov 2024 05:48:50 -0800 X-CSE-ConnectionGUID: E9Q/B5KkQNWY6mmw0SnaQQ== X-CSE-MsgGUID: LXenmaZXRJaEscROJLy6cA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.12,156,1728975600"; d="scan'208";a="126105363" Received: from orsosgc001.jf.intel.com (HELO orsosgc001.intel.com) ([10.165.21.142]) by smtpauth.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 15 Nov 2024 05:48:50 -0800 Date: Fri, 15 Nov 2024 05:48:49 -0800 Message-ID: <85a5e0y5dq.wl-ashutosh.dixit@intel.com> From: "Dixit, Ashutosh" To: Michal Wajdeczko Cc: Raag Jadav , intel-xe@lists.freedesktop.org, anshuman.gupta@intel.com Subject: Re: [PATCH v1] drm/xe/throttle: Log throttle reasons In-Reply-To: References: <20241115125614.857611-1-raag.jadav@intel.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?ISO-8859-4?Q?Goj=F2?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/28.2 (x86_64-redhat-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-BeenThere: intel-xe@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel Xe graphics driver List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-xe-bounces@lists.freedesktop.org Sender: "Intel-xe" On Fri, 15 Nov 2024 05:12:08 -0800, Michal Wajdeczko wrote: > > > > On 15.11.2024 13:56, Raag Jadav wrote: > > Log throttle register MMIO reads which will be useful for debugging. > > > > Signed-off-by: Raag Jadav > > --- > > drivers/gpu/drm/xe/xe_gt_throttle.c | 9 ++++++--- > > 1 file changed, 6 insertions(+), 3 deletions(-) > > > > diff --git a/drivers/gpu/drm/xe/xe_gt_throttle.c b/drivers/gpu/drm/xe/xe_gt_throttle.c > > index 03b225364101..0ce21ffc08dc 100644 > > --- a/drivers/gpu/drm/xe/xe_gt_throttle.c > > +++ b/drivers/gpu/drm/xe/xe_gt_throttle.c > > @@ -37,15 +37,18 @@ dev_to_gt(struct device *dev) > > > > u32 xe_gt_throttle_get_limit_reasons(struct xe_gt *gt) > > { > > + struct xe_device *xe = gt_to_xe(gt); > > + bool media = xe_gt_is_media_type(gt); Also not sure what the point of these new variables is, previous code is fine. I actually prefer it to the new code. So this patch should be just a single line of xe_gt_dbg, IMO. > > u32 reg; > > > > - xe_pm_runtime_get(gt_to_xe(gt)); > > - if (xe_gt_is_media_type(gt)) > > + xe_pm_runtime_get(xe); > > + if (media) > > reg = xe_mmio_read32(>->mmio, MTL_MEDIA_PERF_LIMIT_REASONS); > > else > > reg = xe_mmio_read32(>->mmio, GT0_PERF_LIMIT_REASONS); > > - xe_pm_runtime_put(gt_to_xe(gt)); > > + xe_pm_runtime_put(xe); > > > > + drm_dbg(&xe->drm, "%s reg: 0x%x\n", media ? "media" : "gt", reg); > > we prefer GT oriented logs, so this should be: > > xe_gt_dbg(gt, ".... > > > return reg; > > } > > >