From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D9FD4C27C53 for ; Wed, 19 Jun 2024 21:56:35 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 367CF10E27F; Wed, 19 Jun 2024 21:56:35 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=intel.com header.i=@intel.com header.b="SkLrpDBH"; dkim-atps=neutral Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.17]) by gabe.freedesktop.org (Postfix) with ESMTPS id BED9410E27F for ; Wed, 19 Jun 2024 21:56:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1718834194; x=1750370194; h=date:message-id:from:to:cc:subject:in-reply-to: references:mime-version; bh=lD/+eRpRv3Rm9/tCUua0HVr/i3Ae+ZkRns8dpXBrW8Y=; b=SkLrpDBHMxdSBKNeKsf0sUPbK9UL2Wixrzplq+fZg1YiP9S1bmpYk7CA CiJj3lHNlGKntTmBLKxfL8GwYMiPr5qeIna+5Nw9KREtDWXcE+HA4zzB5 409v2d+2LNJxYb90GglL2yg/MR4mjvdCAGU+3Qq0/rRCPWLH7rY52i7GC 99B9fN/XLvSO2Jmb8BUo9t2bq253kimIDkyO6IKZqHoJXBgEMiXEBM59E qwS0uc51j3s47ydCRIhAahWUYn1w4Husfz/L2ySYATZmMwZHkJrIHYZTc 8QmFDuRHLGVzVqj6GEea5itm4r8nONtRdkKSLWpR9Fh8XhPIrY4+ibbkv w==; X-CSE-ConnectionGUID: Tw18xvMkQmCZrqZEIKzXeg== X-CSE-MsgGUID: JjsqhqRVR9GZBbX4Binklw== X-IronPort-AV: E=McAfee;i="6700,10204,11108"; a="15663779" X-IronPort-AV: E=Sophos;i="6.08,251,1712646000"; d="scan'208";a="15663779" Received: from fmviesa010.fm.intel.com ([10.60.135.150]) by fmvoesa111.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Jun 2024 14:56:33 -0700 X-CSE-ConnectionGUID: aShphOJQSli7e3QLU4+r5g== X-CSE-MsgGUID: UYOnLzArQCya3zq6DxnlqA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.08,251,1712646000"; d="scan'208";a="42158929" Received: from orsosgc001.jf.intel.com (HELO orsosgc001.intel.com) ([10.165.21.138]) by fmviesa010-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Jun 2024 14:56:33 -0700 Date: Wed, 19 Jun 2024 14:56:32 -0700 Message-ID: <85a5jgr3zj.wl-ashutosh.dixit@intel.com> From: "Dixit, Ashutosh" To: Michal Wajdeczko Cc: intel-xe@lists.freedesktop.org Subject: Re: [PATCH 5/9] drm/xe/vf: Don't initialize OA if VF In-Reply-To: <20240619214557.905-6-michal.wajdeczko@intel.com> References: <20240619214557.905-1-michal.wajdeczko@intel.com> <20240619214557.905-6-michal.wajdeczko@intel.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?ISO-8859-4?Q?Goj=F2?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/28.2 (x86_64-redhat-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-BeenThere: intel-xe@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel Xe graphics driver List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-xe-bounces@lists.freedesktop.org Sender: "Intel-xe" On Wed, 19 Jun 2024 14:45:53 -0700, Michal Wajdeczko wrote: > > We don't support Observation Architecture on the VF device. > > Signed-off-by: Michal Wajdeczko > Cc: Rodrigo Vivi > Cc: Ashutosh Dixit > --- > drivers/gpu/drm/xe/xe_oa.c | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/drivers/gpu/drm/xe/xe_oa.c b/drivers/gpu/drm/xe/xe_oa.c > index 34206e0b6a08..f54a97954452 100644 > --- a/drivers/gpu/drm/xe/xe_oa.c > +++ b/drivers/gpu/drm/xe/xe_oa.c > @@ -35,6 +35,7 @@ > #include "xe_perf.h" > #include "xe_pm.h" > #include "xe_sched_job.h" > +#include "xe_sriov.h" > > #define DEFAULT_POLL_FREQUENCY_HZ 200 > #define DEFAULT_POLL_PERIOD_NS (NSEC_PER_SEC / DEFAULT_POLL_FREQUENCY_HZ) > @@ -2385,6 +2386,9 @@ int xe_oa_init(struct xe_device *xe) > if (XE_WARN_ON(!xe_device_uc_enabled(xe)) || XE_WARN_ON(GRAPHICS_VER(xe) < 12)) > return 0; > > + if (IS_SRIOV_VF(xe)) > + return 0; > + Do we want to add XE_WARN_ON's or combine this if statement with the previous one? In any case: Reviewed-by: Ashutosh Dixit > oa->xe = xe; > oa->oa_formats = oa_formats; > > -- > 2.43.0 >