From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 095D2C021B8 for ; Tue, 25 Feb 2025 20:55:32 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id C1E3B10E7E3; Tue, 25 Feb 2025 20:55:31 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=intel.com header.i=@intel.com header.b="goi38mZq"; dkim-atps=neutral Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.14]) by gabe.freedesktop.org (Postfix) with ESMTPS id 45B7B10E7E3 for ; Tue, 25 Feb 2025 20:55:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1740516931; x=1772052931; h=date:message-id:from:to:cc:subject:in-reply-to: references:mime-version; bh=y8JbV6+4T1xgFstcwqyiicB7aeU1U5gshw8uHDfbsbk=; b=goi38mZq/IDIZKG9vkaBWzCJgQ1ddoPeg13IGLm+fuCQu7egmdS/UTDq mAnzl6mZm0Zd15n+eU/zM2WePMiBc3RlHr2hZAfxdqTVcEIeOhDT29w50 cHAYNK51nb3KZyzVySCR9CkUjRVwOVaD2LHnY0CQl+t6mTY8VqOYXtuYT n2spfY6Ma4XLwEHtbsDXrRsP848gS5ii+nxNfQWSjecRXqSc4MqtcuRUA lOV3h7SC2PDH1WLLNDrMq2Spo2qPiQcJcv5/5VngqFKf0WN3eEmhL3gy0 Jr9LNd4NuJuD0y/QuLPotB2YSODhlnYM+WYYaBvHOrW3b9wJ2RCUCCNbv A==; X-CSE-ConnectionGUID: RcjamzUFQOe0TByQOHn9Mg== X-CSE-MsgGUID: v/I4KkRMQr+xNme2iqPHtA== X-IronPort-AV: E=McAfee;i="6700,10204,11356"; a="45128902" X-IronPort-AV: E=Sophos;i="6.13,314,1732608000"; d="scan'208";a="45128902" Received: from orviesa006.jf.intel.com ([10.64.159.146]) by orvoesa106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 25 Feb 2025 12:55:26 -0800 X-CSE-ConnectionGUID: VV4Kzoj2R1+kYRhzUqv0nw== X-CSE-MsgGUID: Mf9m/qlpTASaxfdCN181FA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.13,314,1732608000"; d="scan'208";a="116494960" Received: from orsosgc001.jf.intel.com (HELO orsosgc001.intel.com) ([10.165.21.142]) by orviesa006-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 25 Feb 2025 12:55:25 -0800 Date: Tue, 25 Feb 2025 12:55:25 -0800 Message-ID: <85bjupkama.wl-ashutosh.dixit@intel.com> From: "Dixit, Ashutosh" To: Harish Chegondi Cc: Subject: Re: [PATCH v11 4/8] drm/xe/eustall: Add support to read() and poll() EU stall data In-Reply-To: <6c8f4edb987cc00ef4f7ab6da90582facc5323b4.1740474556.git.harish.chegondi@intel.com> References: <6c8f4edb987cc00ef4f7ab6da90582facc5323b4.1740474556.git.harish.chegondi@intel.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?ISO-8859-4?Q?Goj=F2?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/28.2 (x86_64-redhat-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-BeenThere: intel-xe@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel Xe graphics driver List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-xe-bounces@lists.freedesktop.org Sender: "Intel-xe" On Tue, 25 Feb 2025 01:20:21 -0800, Harish Chegondi wrote: > > Implement the EU stall sampling APIs to read() and poll() EU stall data. > A work function periodically polls the EU stall data buffer write pointer > registers to look for any new data and caches the write pointer. The read > function compares the cached read and write pointers and copies any new > data to the user space. > > v11: Used gt->eu_stall->stream_lock instead of stream->buf_lock. > Removed read and write offsets from trace and added read size. > Moved workqueue from struct xe_eu_stall_data_stream to > struct xe_eu_stall_gt. LGTM now with these changes: Reviewed-by: Ashutosh Dixit