From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 03967CFA460 for ; Wed, 23 Oct 2024 19:31:18 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id C312310E21E; Wed, 23 Oct 2024 19:31:18 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=intel.com header.i=@intel.com header.b="isKmIETF"; dkim-atps=neutral Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.8]) by gabe.freedesktop.org (Postfix) with ESMTPS id 760B810E21E for ; Wed, 23 Oct 2024 19:31:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1729711878; x=1761247878; h=date:message-id:from:to:cc:subject:in-reply-to: references:mime-version; bh=Tlm+5qqzFhytneCJl0cgTDqxPS+iYokBAnXJFTaam+E=; b=isKmIETFZZPI6qdsdQm8J6RsFeWCTskShNdyP/D8rKGoCFf+QAdyScz/ ibJNFxsAQU4Z0y7eZI7ASBvNHqjaQf4DSoH9ppyD5lSQBaLGsz6vfOPdX eWl+wNS/Xw45JjIMSivPx8JorSqgd9tYjjSumNoWhhv37snMnHjCJvr8u c8IQnNYr9RxiVgBbkyv60SNZtQt2XJZpUw1fRbbZqn3rJGO0xSAmrbijc pCHZ8XE7CIey/4bAd23gFnmFRDcyeGjReHFKDVCXT3RS4mosbImIApv6o Y05G/Zgz9GaurNXxGYw/lgQyKG9b7yhwFO0oPnkaMr35HCfqhmyhqCsd8 Q==; X-CSE-ConnectionGUID: SuZ1F/fuSUqV9ywW9Kjc4Q== X-CSE-MsgGUID: OM/EzbKbTZuSRa7ElAv8bA== X-IronPort-AV: E=McAfee;i="6700,10204,11234"; a="46806878" X-IronPort-AV: E=Sophos;i="6.11,227,1725346800"; d="scan'208";a="46806878" Received: from fmviesa006.fm.intel.com ([10.60.135.146]) by fmvoesa102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 Oct 2024 12:31:17 -0700 X-CSE-ConnectionGUID: Wdg78nCYT1+vOBgQMr0cug== X-CSE-MsgGUID: uZ+AgIVkS8O4gyNTeLvSRA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.11,227,1725346800"; d="scan'208";a="79921055" Received: from orsosgc001.jf.intel.com (HELO orsosgc001.intel.com) ([10.165.21.142]) by fmviesa006-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 Oct 2024 12:31:17 -0700 Date: Wed, 23 Oct 2024 12:31:16 -0700 Message-ID: <85bjzavcor.wl-ashutosh.dixit@intel.com> From: "Dixit, Ashutosh" To: Jonathan Cavitt Cc: intel-xe@lists.freedesktop.org, saurabhg.gupta@intel.com, alex.zuo@intel.com, umesh.nerlige.ramappa@intel.com, john.c.harrison@intel.com Subject: Re: [PATCH v2] drm/xe/xe_guc_ads: save/restore OA registers In-Reply-To: <20241022141054.5311-1-jonathan.cavitt@intel.com> References: <20241022141054.5311-1-jonathan.cavitt@intel.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?ISO-8859-4?Q?Goj=F2?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/28.2 (x86_64-redhat-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-BeenThere: intel-xe@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel Xe graphics driver List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-xe-bounces@lists.freedesktop.org Sender: "Intel-xe" On Tue, 22 Oct 2024 07:10:54 -0700, Jonathan Cavitt wrote: > > Several OA registers and allowlist registers were missing from the > save/restore list for GuC and could be lost during an engine reset. Add > them to the list. > > v2: > - Fix commit message (Umesh) > - Add missing closes (Ashutosh) > > Closes: https://gitlab.freedesktop.org/drm/xe/kernel/-/issues/2249 > Suggested-by: Umesh Nerlige Ramappa > Suggested-by: John Harrison > Signed-off-by: Jonathan Cavitt > Acked-by: Ashutosh Dixit > Reviewed-by: Umesh Nerlige Ramappa How about also adding to this: Fixes: dd08ebf6c352 ("drm/xe: Introduce a new DRM driver for Intel GPUs") Cc: stable@vger.kernel.org Otherwise if anyone tries OA on 6.11 (when it appeared) might hit this issue and start filing bugs etc. So the simplest I think is to add the above now itself. Otoh, 6.12 will probably be a LTS kernel and this patch will be there...