From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E02F6C4828E for ; Fri, 2 Feb 2024 22:56:40 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id A009910F14E; Fri, 2 Feb 2024 22:56:40 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=intel.com header.i=@intel.com header.b="QdeAdhvB"; dkim-atps=neutral Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.20]) by gabe.freedesktop.org (Postfix) with ESMTPS id 71FEC10F14E for ; Fri, 2 Feb 2024 22:56:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1706914597; x=1738450597; h=date:message-id:from:to:cc:subject:in-reply-to: references:mime-version; bh=jxrG0KZM/LefYtzwV6MCuE5WvpcpcnRENCaMyVuOyvY=; b=QdeAdhvB2Dp/DYok2qCZiNIqsq42nwe9KImEANtD5nF4lbcI97K4PDUw mJV4JsA+SQFZuisC5z0ODV9xEWDweLlcPj+CKP0u80PqjnX3MkEFy/oEw 6SxhRBoj2/O7SS4fa1JmQIVTxjlbfT5zPo+uVMhdPfnc1KDE5gtXke+4u R2pRt6TvrUyj3Bj9Ax37LMx9g/Z37p4klF/dmy5G/+DPc61i/s7u6CeAM JYXKklwIOjtZ2y3l/aSNan4j21FzAQL7Q0uOIS36X2aJAEatEATk6yBT0 n1RqlLeCI+JtZU6trcNH2FRsiALiAMiI8ebcEa/7u7VcL9FX1QEww6dBk w==; X-IronPort-AV: E=McAfee;i="6600,9927,10971"; a="168528" X-IronPort-AV: E=Sophos;i="6.05,238,1701158400"; d="scan'208";a="168528" Received: from fmviesa007.fm.intel.com ([10.60.135.147]) by orvoesa112.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 02 Feb 2024 14:49:30 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.05,238,1701158400"; d="scan'208";a="257265" Received: from orsosgc001.jf.intel.com (HELO unerlige-ril.intel.com) ([10.165.21.138]) by fmviesa007-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 02 Feb 2024 14:49:31 -0800 Date: Fri, 02 Feb 2024 14:49:30 -0800 Message-ID: <85cytebhxh.wl-ashutosh.dixit@intel.com> From: "Dixit, Ashutosh" To: intel-xe@lists.freedesktop.org Cc: Riana Tauro , carlos.santa@intel.com Subject: Re: [PATCH] drm/xe/xe_gt_idle: Drop redundant newline in name In-Reply-To: <20240202223525.3221158-1-ashutosh.dixit@intel.com> References: <20240202223525.3221158-1-ashutosh.dixit@intel.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?ISO-8859-4?Q?Goj=F2?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/28.2 (x86_64-redhat-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-BeenThere: intel-xe@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel Xe graphics driver List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-xe-bounces@lists.freedesktop.org Sender: "Intel-xe" On Fri, 02 Feb 2024 14:35:25 -0800, Ashutosh Dixit wrote: > > Newline in name is redunant and produces an unnecessary empty line during > 'cat name'. > > Fixes: 27a1a1e2e47d ("drm/xe: stringify the argument to avoid potential vulnerability") > Signed-off-by: Ashutosh Dixit > --- > drivers/gpu/drm/xe/xe_gt_idle.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/xe/xe_gt_idle.c b/drivers/gpu/drm/xe/xe_gt_idle.c > index 9358f73368896..42fdc7f688d0e 100644 > --- a/drivers/gpu/drm/xe/xe_gt_idle.c > +++ b/drivers/gpu/drm/xe/xe_gt_idle.c > @@ -87,7 +87,7 @@ static ssize_t name_show(struct device *dev, > { > struct xe_gt_idle *gtidle = dev_to_gtidle(dev); > > - return sysfs_emit(buff, "%s\n", gtidle->name); > + return sysfs_emit(buff, "%s", gtidle->name); Sorry, please ignore this patch. The issue is there but the patch is incorrect.