From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 4421E109C028 for ; Wed, 25 Mar 2026 15:02:23 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 033EF10E16D; Wed, 25 Mar 2026 15:02:23 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=intel.com header.i=@intel.com header.b="G7K9+LTP"; dkim-atps=neutral Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.19]) by gabe.freedesktop.org (Postfix) with ESMTPS id 84A9C10E16D for ; Wed, 25 Mar 2026 15:02:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1774450943; x=1805986943; h=date:message-id:from:to:cc:subject:in-reply-to: references:mime-version; bh=t+pIshV2cKiP7ANS8jUKTaGgPmgqoTS3zTpaTraXYAY=; b=G7K9+LTPlij3xXJ76MO+Ep6TJPVxXR+5Ilf7tk/Gb4jG7FmoQ+TyAklL FzvMvgz/bdYDD+k92VkVz5XxlKTpPnJcaLg47WcyGFNH1oS78nHCDfHtN ApwFTDyvZP8kPciNRTrl/bAjGaNo+lg5eyy0+V+jgIEx9CjXG5OfQJ3Xl MVwNLi7yfPFb39dD5vscffs1HzHWe+JIt7/y/MlSlkb4Q71+s4HFGiLsy gCtEI+mgs1/8e8rIF5o/eyF95P+vYuhZ914phDaeJgeiOV4+7wG2+nWvB vufJQmh/n49HepuCqunsZmmr3lT4ExaK9W+vP0H/OV/++zYhITxp0AYmg A==; X-CSE-ConnectionGUID: JEED4N7MTgu92GBGAUEWnA== X-CSE-MsgGUID: Y7aBrulASAC7ZdOaMqjDpg== X-IronPort-AV: E=McAfee;i="6800,10657,11740"; a="74520847" X-IronPort-AV: E=Sophos;i="6.23,140,1770624000"; d="scan'208";a="74520847" Received: from fmviesa005.fm.intel.com ([10.60.135.145]) by fmvoesa113.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 25 Mar 2026 08:02:22 -0700 X-CSE-ConnectionGUID: I8xaj1oWSeW8+wznEMHInw== X-CSE-MsgGUID: 8nmr9ae3Qr2ApUdvmRVrqQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.23,140,1770624000"; d="scan'208";a="229479417" Received: from orsosgc001.jf.intel.com (HELO orsosgc001.intel.com) ([10.88.27.185]) by fmviesa005-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 25 Mar 2026 08:02:22 -0700 Date: Wed, 25 Mar 2026 08:02:21 -0700 Message-ID: <85fr5o9cle.wl-ashutosh.dixit@intel.com> From: "Dixit, Ashutosh" To: Umesh Nerlige Ramappa Cc: intel-xe@lists.freedesktop.org, badal.nilawar@intel.com, anoop.c.vijay@intel.com Subject: Re: [PATCH v8 3/3] drm/xe/soc_remapper: Add system controller config for SoC remapper In-Reply-To: <20251223183943.3175941-8-umesh.nerlige.ramappa@intel.com> References: <20251223183943.3175941-5-umesh.nerlige.ramappa@intel.com> <20251223183943.3175941-8-umesh.nerlige.ramappa@intel.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?ISO-8859-4?Q?Goj=F2?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/30.2 (x86_64-redhat-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-BeenThere: intel-xe@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel Xe graphics driver List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-xe-bounces@lists.freedesktop.org Sender: "Intel-xe" On Tue, 23 Dec 2025 10:39:47 -0800, Umesh Nerlige Ramappa wrote: > > @@ -30,10 +36,17 @@ static void xe_soc_remapper_set_telem_region(struct xe_device *xe, u32 index) > */ > int xe_soc_remapper_init(struct xe_device *xe) > { > - if (xe->info.has_soc_remapper_telem) { > + bool has_soc_remapper = xe->info.has_soc_remapper_telem || > + xe->info.has_soc_remapper_sysctrl; > + > + if (has_soc_remapper) > spin_lock_init(&xe->soc_remapper.lock); > + > + if (xe->info.has_soc_remapper_telem) > xe->soc_remapper.set_telem_region = xe_soc_remapper_set_telem_region; > - } > + > + if (xe->info.has_soc_remapper_sysctrl) > + xe->soc_remapper.set_sysctrl_region = xe_soc_remapper_set_sysctrl_region; Maybe these if () statements hould be moved inside these functions? Otherwise they will need to replicated in every place these functions are called? We've already seen this problem in the sysctrl series.