From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 09CD4C02198 for ; Mon, 10 Feb 2025 23:53:29 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id CA77210E21B; Mon, 10 Feb 2025 23:53:28 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=intel.com header.i=@intel.com header.b="QDHZy4SU"; dkim-atps=neutral Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.13]) by gabe.freedesktop.org (Postfix) with ESMTPS id DF80210E21B for ; Mon, 10 Feb 2025 23:53:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1739231608; x=1770767608; h=date:message-id:from:to:cc:subject:in-reply-to: references:mime-version; bh=afhpkUBE8/j4tHcI+AQjkOWGpNEmXiPDsXxBu4COxg4=; b=QDHZy4SUQZfFu6bIO3xBMY16geDbtq7YtDvfCdwUjDLGfHhx9680TbSf UczdNnzBcOQ6LxPZX1ybJDRAOcHgrbag2jT7HFNVuqNdrz1bloQDZhmYc ylme/hgo0tjo19gM4MUGGGs8EXxjeuA1HNCXjtrBd733d3OZm3lls5Xie Nm+R8bpzdBHuoIwX0j0ye/aIr3PYXR17XF3oFh1jEZE0PkcizuE9dD/1D V1Dd7++1KDJV7KB6vVDxAsjPA51BruF/B1+sXGljEq8XBi4dk4qxCBPOW 2LpLT3UTXuE1X1mdkIQUZtDecHPQMFvgabphKD7TTxBbhWzvrFhuiG0aY A==; X-CSE-ConnectionGUID: voGmpSEtT+KBLw2XMfwYtw== X-CSE-MsgGUID: db4khsCLQLWQscFiJwLWIA== X-IronPort-AV: E=McAfee;i="6700,10204,11341"; a="42673310" X-IronPort-AV: E=Sophos;i="6.13,275,1732608000"; d="scan'208";a="42673310" Received: from fmviesa009.fm.intel.com ([10.60.135.149]) by fmvoesa107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 Feb 2025 15:53:27 -0800 X-CSE-ConnectionGUID: VkOa1OA9S1Gz6KQao72q1w== X-CSE-MsgGUID: eLpDAYxZSHCAMSSlO05bkQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.13,275,1732608000"; d="scan'208";a="112978352" Received: from orsosgc001.jf.intel.com (HELO orsosgc001.intel.com) ([10.165.21.142]) by fmviesa009-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 Feb 2025 15:53:27 -0800 Date: Mon, 10 Feb 2025 15:53:26 -0800 Message-ID: <85frkl2w7d.wl-ashutosh.dixit@intel.com> From: "Dixit, Ashutosh" To: Harish Chegondi Cc: Subject: Re: [PATCH v9 2/8] drm/xe/uapi: Introduce API for EU stall sampling In-Reply-To: <85h6512ybc.wl-ashutosh.dixit@intel.com> References: <36d701413aeb171c86d5dd2ce7272918eb4ab818.1739193510.git.harish.chegondi@intel.com> <85h6512ybc.wl-ashutosh.dixit@intel.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?ISO-8859-4?Q?Goj=F2?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/28.2 (x86_64-redhat-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-BeenThere: intel-xe@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel Xe graphics driver List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-xe-bounces@lists.freedesktop.org Sender: "Intel-xe" On Mon, 10 Feb 2025 15:07:51 -0800, Dixit, Ashutosh wrote: > > > + > > + ret = xe_eu_stall_user_extensions(xe, data, &props); > > + if (ret) > > + return ret; > > + > > + if (!props.gt) { > > + drm_dbg(&xe->drm, "GT ID not provided for EU stall sampling\n"); > > + return -EINVAL; > > + } > > This check is not needed. props.gt cannot be NULL the way > set_prop_eu_stall_gt_id is implemented. > > If you need it, use xe_assert(props->gt) in set_prop_eu_stall_gt_id. Sorry, this is needed in case gt_id is not provided by userland. Unless default gt_id can be 0, in which case this is not needed?