From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 1E0E8E7718B for ; Fri, 20 Dec 2024 20:06:03 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id BF25F10E3D2; Fri, 20 Dec 2024 20:06:02 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=intel.com header.i=@intel.com header.b="gRbZq980"; dkim-atps=neutral Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.9]) by gabe.freedesktop.org (Postfix) with ESMTPS id CED0F10E3D2 for ; Fri, 20 Dec 2024 20:06:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1734725161; x=1766261161; h=date:message-id:from:to:cc:subject:in-reply-to: references:mime-version; bh=liqsWAU+Cucg8AvXHeojqGIQvxY/X762lOYxWU/FguI=; b=gRbZq980Bsvpm4iQGnwrFOy5w1kCepkJNaqN94WvLLkZd0A4xsBvQr7s AGsaI78RM1BNaX+pCDNkPahltaiAcjCcJc9h9dLIWMFCAlkVhS8QqBNd7 4TjZJgU317J/cCDRoPINlY9EnTzhtac34Il2B3zTGqIIodHYjwi91b5S9 CUCa1vO04bL/MmK+uiFCptIwW6WiSbPgKJ/VZziAHgdAMbH4Rf/8UrDpL 7E6XofG+MT/Qh8L2onanNN02ScNMQW8i5g3zS/lExJglktsY+6YpsSQ+L BuCWrFMqJ68O2QsJBf9vKPGh79EQSNOs/mXma+wjN2I3qX6UVudhCNX3R Q==; X-CSE-ConnectionGUID: ApXD2kWXRaGg2r97TmJEkA== X-CSE-MsgGUID: yLsLmlpuQX68NvhkHSsDzg== X-IronPort-AV: E=McAfee;i="6700,10204,11292"; a="45974841" X-IronPort-AV: E=Sophos;i="6.12,251,1728975600"; d="scan'208";a="45974841" Received: from fmviesa005.fm.intel.com ([10.60.135.145]) by fmvoesa103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 Dec 2024 12:06:00 -0800 X-CSE-ConnectionGUID: ggXec6jZSuOZcQTL5i2nMA== X-CSE-MsgGUID: REgL1ga2QB2yHECOj0IXtA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.12,224,1728975600"; d="scan'208";a="103209284" Received: from orsosgc001.jf.intel.com (HELO orsosgc001.intel.com) ([10.165.21.142]) by fmviesa005-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 Dec 2024 12:06:00 -0800 Date: Fri, 20 Dec 2024 12:05:59 -0800 Message-ID: <85h66y15nc.wl-ashutosh.dixit@intel.com> From: "Dixit, Ashutosh" To: "Souza, Jose" Cc: "intel-xe@lists.freedesktop.org" , "Nerlige Ramappa, Umesh" Subject: Re: [PATCH v5 0/2] Fixes for MI_REPORT_PERF_COUNT In-Reply-To: References: <20241220171919.571528-1-umesh.nerlige.ramappa@intel.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?ISO-8859-4?Q?Goj=F2?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/28.2 (x86_64-redhat-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-BeenThere: intel-xe@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel Xe graphics driver List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-xe-bounces@lists.freedesktop.org Sender: "Intel-xe" On Fri, 20 Dec 2024 11:54:04 -0800, Souza, Jose wrote: > Hi Jose, > On Fri, 2024-12-20 at 09:19 -0800, Umesh Nerlige Ramappa wrote: > > OA programming sequence for query mode or MI_REPORT_PERF_COUNT requires > > modifying some HW registers in the same hw context as the user exec > > queue. User passes the exec_queue to the OA interface and OA > > implementation submits an MI_LOAD_REGISTER_IMM to this queue to modify > > the registers. > > > > The OA implementation submits a batch mapped in GGTT to the user exec > > queue and hence, some plumbing is added into relevant code to enable > > that (as per suggestions from Matthew Brost). > > > > v2: review rework > > v3: > > - review rework > > - original patches squashed for porting to stable > > - code cleanup > > > > v4: > > - review rework/fixes > > > > v5: > > - minor review rework/fixes > > v5 fixed the oops that I got in v4 and also fixed the GPU hang when > closing OA stream. Thanks so much for testing. Ashutosh > > > > > Signed-off-by: Umesh Nerlige Ramappa > > > > Umesh Nerlige Ramappa (2): > > xe/oa: Fix query mode of operation for OAR/OAC > > xe/oa: Drop the unused logic to parse context image > > > > drivers/gpu/drm/xe/xe_oa.c | 224 +++++------------------- > > drivers/gpu/drm/xe/xe_oa_types.h | 3 - > > drivers/gpu/drm/xe/xe_ring_ops.c | 5 +- > > drivers/gpu/drm/xe/xe_sched_job_types.h | 2 + > > 4 files changed, 51 insertions(+), 183 deletions(-) > > >