From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id AB84DC46CD2 for ; Tue, 30 Jan 2024 18:33:21 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id ABD0D112398; Tue, 30 Jan 2024 18:33:15 +0000 (UTC) Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.10]) by gabe.freedesktop.org (Postfix) with ESMTPS id 7948B112398 for ; Tue, 30 Jan 2024 18:33:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1706639593; x=1738175593; h=date:message-id:from:to:cc:subject:in-reply-to: references:mime-version; bh=4pg8t2E+5IhgOJGUuAK0VK9sZk940182y1Sc109f3jg=; b=H7ERpZUuyfNsQORGbFtNel8bbWsHyefHqbLuBYwbAhGVd+2/c3k4UecO +02e0zj0QELiZLrAnYpD2ZLoxwmjUG7COT+wvd7aBU4FIvu8yw5RJusYs FQ/YMuuJQi/sFV4WN4Ud7Gzck7VrSo4DWbCbN8PDUEGp3JKBYF/3ZZBHF x9EazRax9f6QRP44bZ9Wadp67L8mpgTXeAOjcciCM8hLqGFO0N7+wJcVq rv6We2zWrqJqWuFJVYonyEU5aMZVk5hKN4mQI2R12PHs8o87fBnjzYcyP nz9AFfFuDzAmuUAMkVzDGjkOIRqvYk5yKf8ocfWHT2pO/K8MXrW032+zw g==; X-IronPort-AV: E=McAfee;i="6600,9927,10969"; a="16752771" X-IronPort-AV: E=Sophos;i="6.05,230,1701158400"; d="scan'208";a="16752771" Received: from orsmga005.jf.intel.com ([10.7.209.41]) by orvoesa102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 30 Jan 2024 10:33:12 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10969"; a="961368776" X-IronPort-AV: E=Sophos;i="6.05,230,1701158400"; d="scan'208";a="961368776" Received: from orsosgc001.jf.intel.com (HELO unerlige-ril.intel.com) ([10.165.21.138]) by orsmga005-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 30 Jan 2024 10:33:12 -0800 Date: Tue, 30 Jan 2024 10:33:12 -0800 Message-ID: <85h6iubriv.wl-ashutosh.dixit@intel.com> From: "Dixit, Ashutosh" To: Daniele Ceraolo Spurio Subject: Re: [PATCH v2 1/3] drm/xe: Remove ci-only GuC FW definitions In-Reply-To: <20231219200023.2502159-1-daniele.ceraolospurio@intel.com> References: <20231219200023.2502159-1-daniele.ceraolospurio@intel.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?ISO-8859-4?Q?Goj=F2?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/28.2 (x86_64-redhat-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-BeenThere: intel-xe@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel Xe graphics driver List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: intel-xe@lists.freedesktop.org, Rodrigo Vivi Errors-To: intel-xe-bounces@lists.freedesktop.org Sender: "Intel-xe" On Tue, 19 Dec 2023 12:00:20 -0800, Daniele Ceraolo Spurio wrote: > > diff --git a/drivers/gpu/drm/xe/xe_uc_fw.c b/drivers/gpu/drm/xe/xe_uc_fw.c > index 73d6938c921d..9dff96dfe455 100644 > --- a/drivers/gpu/drm/xe/xe_uc_fw.c > +++ b/drivers/gpu/drm/xe/xe_uc_fw.c > @@ -102,9 +102,7 @@ struct fw_blobs_by_type { > }; > > #define XE_GUC_FIRMWARE_DEFS(fw_def, mmp_ver, major_ver) \ > - fw_def(LUNARLAKE, mmp_ver(xe, guc, lnl, 70, 6, 8)) \ > fw_def(METEORLAKE, major_ver(i915, guc, mtl, 70, 7)) \ > - fw_def(PVC, mmp_ver(xe, guc, pvc, 70, 9, 1)) \ > fw_def(DG2, major_ver(i915, guc, dg2, 70, 5)) \ > fw_def(DG1, major_ver(i915, guc, dg1, 70, 5)) \ > fw_def(ALDERLAKE_N, major_ver(i915, guc, tgl, 70, 5)) \ I think this commit should include an error message saying FW not found (or whatever). A lot of people have spent a lot of time because probe just fails with "xe: probe of 0000:00:02.0 failed with error -22" without any indication of why? I actually reached this patch after bisecting and realizing FW had been moved to xe-for-ci branch :/