From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 76E1FE77188 for ; Fri, 20 Dec 2024 03:48:01 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 4876D10E369; Fri, 20 Dec 2024 03:48:01 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=intel.com header.i=@intel.com header.b="SwzkliVk"; dkim-atps=neutral Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.9]) by gabe.freedesktop.org (Postfix) with ESMTPS id B68A210E369 for ; Fri, 20 Dec 2024 03:47:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1734666480; x=1766202480; h=date:message-id:from:to:cc:subject:in-reply-to: references:mime-version; bh=shhDCkOV/Bpjc47d1LIMXCSHCtRWIqic1hIq0GaatzM=; b=SwzkliVkdA+z0p0AD/SJRGyA641hd3/ov/CtvkhaB2vNAteHT5WqRpwo SB7m4OVA+1W1oMCxQyyTF0uOwj7eh2h8oDEVomQ1Vznoy8FvXp2zqb/Ij LAOcRi6Ayky8p2iMODIfWNDqvba9PWBR1/A90ODJuU/zLj5VExO4N/7qi RZijPop26XgF+n2TgMQKA1ewXAkU3dN82UPS8rguGqaeWpPcmd2Sfg2JH PhkwLUqYIKHryE0r9+erAs4vkuarRWB3qIE4FlYVQZVqXiiNHTgNWRAsf hqJbYb3vYQm1YG0X7u1ymqsqo/9lUtLbvYSYzwzgMRGhOzU1gW1jQSMxS w==; X-CSE-ConnectionGUID: tzS+J9ZhTOWQELjiZZmBPA== X-CSE-MsgGUID: n8XzF37aSrahOFQkPQ4NpQ== X-IronPort-AV: E=McAfee;i="6700,10204,11291"; a="57682334" X-IronPort-AV: E=Sophos;i="6.12,249,1728975600"; d="scan'208";a="57682334" Received: from orviesa010.jf.intel.com ([10.64.159.150]) by orvoesa101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Dec 2024 19:48:00 -0800 X-CSE-ConnectionGUID: 0tG/s/YQRuWA0uPuANjHBA== X-CSE-MsgGUID: HNQMxTjzQ7yfcbYpAPjwJg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.12,224,1728975600"; d="scan'208";a="98230404" Received: from orsosgc001.jf.intel.com (HELO orsosgc001.intel.com) ([10.165.21.142]) by orviesa010-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Dec 2024 19:48:00 -0800 Date: Thu, 19 Dec 2024 19:47:59 -0800 Message-ID: <85jzbv10cw.wl-ashutosh.dixit@intel.com> From: "Dixit, Ashutosh" To: Umesh Nerlige Ramappa Cc: , Subject: Re: [PATCH v4 2/2] xe/oa: Drop the unused logic to parse context image In-Reply-To: <20241220002234.554135-3-umesh.nerlige.ramappa@intel.com> References: <20241220002234.554135-1-umesh.nerlige.ramappa@intel.com> <20241220002234.554135-3-umesh.nerlige.ramappa@intel.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?ISO-8859-4?Q?Goj=F2?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/28.2 (x86_64-redhat-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-BeenThere: intel-xe@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel Xe graphics driver List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-xe-bounces@lists.freedesktop.org Sender: "Intel-xe" On Thu, 19 Dec 2024 16:22:34 -0800, Umesh Nerlige Ramappa wrote: > Hi Umesh, > Now that all register configurations are using MI_LOAD_REGISTER_IMM, > drop the logic to parse context image for offset. Could you also please delete these two lines: #include "regs/xe_lrc_layout.h" #include "xe_lrc.h" Looks like we don't have any references to xe_lrc in OA code now :) With that, this is also: Reviewed-by: Ashutosh Dixit