From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 5FF29D18151 for ; Mon, 14 Oct 2024 21:39:54 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 310E610E4D7; Mon, 14 Oct 2024 21:39:54 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=intel.com header.i=@intel.com header.b="ZvOOXie/"; dkim-atps=neutral Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.16]) by gabe.freedesktop.org (Postfix) with ESMTPS id 47FAC10E4D7 for ; Mon, 14 Oct 2024 21:39:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1728941993; x=1760477993; h=date:message-id:from:to:cc:subject:in-reply-to: references:mime-version; bh=knoKr98PIOtel3a0WjZ84qxLCamJ+eGEPTBSEtQwPMU=; b=ZvOOXie//ZmtMka2W7lEQb0ReEbG57tfhEhstZOoNEfnELXClswkZiUB Kv/JKr9PPIYJL2NjiJOA22utUsuZcvw3nqt2QQCB2n8zNDOaAbp9+8A9K OMW1amDgk0kmbGKuKTLjlk6pgMEH2muYArN51XQI2cO8aPCs57eL+jEQT 2aGw9bdQ67fpdLAbGxq2wWt0QVJxVEQkAcd3NXR+u0pjP0A9Y7+D4Us/o OIO84uDuJRDmsqcHDdVSBvurNacvVjxaCKLvoQlODjo1wxcWwLr07XY5y HWXvMEAnpQN9kPKrcar8clG7mLf8CVqa45mOH5/TGE95tHgEJHtqSSSc0 A==; X-CSE-ConnectionGUID: lIQQKMU2RvusPlJ62++ZPQ== X-CSE-MsgGUID: iYOdXzcNTPqE6V6jz4tiAg== X-IronPort-AV: E=McAfee;i="6700,10204,11222"; a="28399865" X-IronPort-AV: E=Sophos;i="6.11,199,1725346800"; d="scan'208";a="28399865" Received: from orviesa008.jf.intel.com ([10.64.159.148]) by orvoesa108.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 Oct 2024 14:39:53 -0700 X-CSE-ConnectionGUID: 0zHLHxjiQcS5cljg7BDMnQ== X-CSE-MsgGUID: 4+LcxtD6Ss+/m+D1aFx06A== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.11,203,1725346800"; d="scan'208";a="78518530" Received: from orsosgc001.jf.intel.com (HELO orsosgc001.intel.com) ([10.165.21.142]) by orviesa008-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 Oct 2024 14:39:53 -0700 Date: Mon, 14 Oct 2024 14:39:52 -0700 Message-ID: <85jzea2wk7.wl-ashutosh.dixit@intel.com> From: "Dixit, Ashutosh" To: Harish Chegondi Cc: , , , , , , Subject: Re: [PATCH v4 4/5] drm/xe/query: Add a device query to get EU stall data information In-Reply-To: <8a5f3cc1a7853b76ddde9442e4d11bf19b337509.1728884074.git.harish.chegondi@intel.com> References: <8a5f3cc1a7853b76ddde9442e4d11bf19b337509.1728884074.git.harish.chegondi@intel.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?ISO-8859-4?Q?Goj=F2?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/28.2 (x86_64-redhat-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-BeenThere: intel-xe@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel Xe graphics driver List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-xe-bounces@lists.freedesktop.org Sender: "Intel-xe" On Sun, 13 Oct 2024 23:00:35 -0700, Harish Chegondi wrote: Hi Harish, Only reviewing the uapi for now (xe_drm.h changes). Mostly nits for this patch. > > diff --git a/include/uapi/drm/xe_drm.h b/include/uapi/drm/xe_drm.h > index 50ad6b2e1450..f1a0f06b61f4 100644 > --- a/include/uapi/drm/xe_drm.h > +++ b/include/uapi/drm/xe_drm.h > @@ -700,6 +700,7 @@ struct drm_xe_device_query { > #define DRM_XE_DEVICE_QUERY_ENGINE_CYCLES 6 > #define DRM_XE_DEVICE_QUERY_UC_FW_VERSION 7 > #define DRM_XE_DEVICE_QUERY_OA_UNITS 8 > +#define DRM_XE_DEVICE_QUERY_EU_STALL_SAMPLING 9 Just call this DRM_XE_DEVICE_QUERY_EU_STALL? > /** @query: The type of data to query */ > __u32 query; > > @@ -1738,6 +1739,25 @@ enum drm_xe_eu_stall_property_id { > DRM_XE_EU_STALL_PROP_GT_ID, > }; > > +/** > + * struct drm_xe_query_eu_stall_data - Information about EU stall data > + * > + * If a query is made with a struct drm_xe_device_query where .query > + * is equal to DRM_XE_DEVICE_QUERY_EU_STALL_SAMPLING, then the reply uses > + * struct drm_xe_query_eu_stall_data in .data. Maybe add a @ before all references in this file. So @drm_xe_device_query, @DRM_XE_DEVICE_QUERY_EU_STALL_SAMPLING and @drm_xe_query_eu_stall_data. I think better to do this even if this hasn't been done for queries elsewhere in this file, looks like a miss. > + */ > +struct drm_xe_query_eu_stall_data { Just call this 'struct drm_xe_query_eu_stall'? > + /** @extensions: Pointer to the first extension struct, if any */ > + __u64 extensions; > + > + /** @record_size: size of each EU stall data record */ > + __u64 record_size; > + > + /** @capabilities: EU stall capabilities bit-mask */ > + __u64 capabilities; > +#define DRM_XE_EU_STALL_CAPS_BASE (1 << 0) > +}; > + > #if defined(__cplusplus) > } > #endif > -- > 2.45.1 > Thanks. -- Ashutosh