From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 986C0CF9C72 for ; Tue, 24 Sep 2024 03:52:48 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 5D9E710E4C6; Tue, 24 Sep 2024 03:52:48 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=intel.com header.i=@intel.com header.b="nkncUhip"; dkim-atps=neutral Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.9]) by gabe.freedesktop.org (Postfix) with ESMTPS id B198E10E4C6 for ; Tue, 24 Sep 2024 03:52:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1727149966; x=1758685966; h=date:message-id:from:to:cc:subject:in-reply-to: references:mime-version; bh=5QGALkxWkll/It2jDRnKb3zr0XE8NrvK9eKdYXCg5ZY=; b=nkncUhipcmDr7P/lZYRAi3yCk9eJBpfndpsjUUjNioaFjxGrFbwFKSG3 C0oMM4bRdiFw1FZu3ZjfpvaWdU645SSociHtHqJ2cNC6usD7WMk5Z1B9u EhZyc2h6GgPWftxtU+FsK8C0X4OK7MwozzKljzLbAv9WAv4MKFRpS6mKh i4XGl2szFmJsFBPm/E0JURimnD90RukAkPNwyKtPSh2DfpgRWELaxiKAd Dnf2fpqtB8uUvdrlS6+ttkcwxW/c/7n74MW0v9F80lGF9b0yP50dLkshr QrTFhxo0hLLwAjzqCXFneIB0BE0nvftQonii4PamZ4vaBletgBqmh8U1U Q==; X-CSE-ConnectionGUID: 2ulNaZK6SPKTeWVtNXebZw== X-CSE-MsgGUID: ZiMjqoJNSg+VPZBZ6V89Fg== X-IronPort-AV: E=McAfee;i="6700,10204,11204"; a="36794578" X-IronPort-AV: E=Sophos;i="6.10,253,1719903600"; d="scan'208";a="36794578" Received: from orviesa009.jf.intel.com ([10.64.159.149]) by fmvoesa103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 Sep 2024 20:52:46 -0700 X-CSE-ConnectionGUID: V4/oGGj1QgCxFI5hw1C0Ag== X-CSE-MsgGUID: rapMwMonTSa6BFv/peU4Pg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.10,253,1719903600"; d="scan'208";a="71331564" Received: from orsosgc001.jf.intel.com (HELO orsosgc001.intel.com) ([10.165.21.138]) by orviesa009-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 Sep 2024 20:52:46 -0700 Date: Mon, 23 Sep 2024 20:52:46 -0700 Message-ID: <85jzf1g12p.wl-ashutosh.dixit@intel.com> From: "Dixit, Ashutosh" To: Maarten Lankhorst Cc: Subject: Re: [PATCH 2/2] drm/xe: Use XE_BO_FLAG_NEEDS_WC_CPU for DSB In-Reply-To: <20240920190107.156914-2-maarten.lankhorst@linux.intel.com> References: <20240920190107.156914-1-maarten.lankhorst@linux.intel.com> <20240920190107.156914-2-maarten.lankhorst@linux.intel.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?ISO-8859-4?Q?Goj=F2?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/28.2 (x86_64-redhat-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-BeenThere: intel-xe@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel Xe graphics driver List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-xe-bounces@lists.freedesktop.org Sender: "Intel-xe" On Fri, 20 Sep 2024 12:01:07 -0700, Maarten Lankhorst wrote: > > Now that we have an explicit flag, we can stop abusing the scanout flag > for this. > > Signed-off-by: Maarten Lankhorst > --- > drivers/gpu/drm/xe/display/xe_dsb_buffer.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/xe/display/xe_dsb_buffer.c b/drivers/gpu/drm/xe/display/xe_dsb_buffer.c > index 9f941fc2e36b..59c5aedefc25 100644 > --- a/drivers/gpu/drm/xe/display/xe_dsb_buffer.c > +++ b/drivers/gpu/drm/xe/display/xe_dsb_buffer.c > @@ -47,7 +47,7 @@ bool intel_dsb_buffer_create(struct intel_crtc *crtc, struct intel_dsb_buffer *d > NULL, PAGE_ALIGN(size), > ttm_bo_type_kernel, > XE_BO_FLAG_VRAM_IF_DGFX(xe_device_get_root_tile(xe)) | > - XE_BO_FLAG_SCANOUT | XE_BO_FLAG_GGTT); > + XE_BO_FLAG_NEEDS_WC_CPU | XE_BO_FLAG_GGTT); Also delete the comment just above the function call above: "Set scanout flag for WC mapping". > if (IS_ERR(obj)) { > kfree(vma); > return false; > -- > 2.45.2 >