From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 98A87C54E58 for ; Wed, 20 Mar 2024 05:09:06 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 5AFCE10E684; Wed, 20 Mar 2024 05:09:06 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=intel.com header.i=@intel.com header.b="CdfTdtr7"; dkim-atps=neutral Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.14]) by gabe.freedesktop.org (Postfix) with ESMTPS id 6FA8B10E684 for ; Wed, 20 Mar 2024 05:09:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1710911346; x=1742447346; h=date:message-id:from:to:cc:subject:in-reply-to: references:mime-version; bh=zYywk4o3ZAVsUyK3WfczzrmzOHxpfH0xPYchd+5sqyM=; b=CdfTdtr7tgGsIQFzPVwU6Z1VCXU+2GjvQ4FbaPHnuq8bhoGTqAwIv78x cj5PgbGwe74UtabCG4Ixy8LOGKmItRnnlwQ5FjeEckQwWbG91RKg+ie8C bNvbhkSWqKnd30/UHYa1kPCKmn9Qh73bmAnLZytNTyRD3dqlE5sjA0dVi srgXqnH30my3GNepQn7nNIcNgZuIS7f0t+B+avlFNi+vnlbuBvRP7hRFc WObgga+lijDKOhOkiWhpZX90ux/Xv673xU9GS2Kb/c/o9mnjMD14ydIC4 zwoGdSvsvYytp2x5pDGQITjbEl/jzjrs9eB6YuJvWJVDFHYPclHt1haju w==; X-IronPort-AV: E=McAfee;i="6600,9927,11018"; a="9636353" X-IronPort-AV: E=Sophos;i="6.07,139,1708416000"; d="scan'208";a="9636353" Received: from fmviesa001.fm.intel.com ([10.60.135.141]) by orvoesa106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Mar 2024 22:09:05 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.07,139,1708416000"; d="scan'208";a="45122870" Received: from orsosgc001.jf.intel.com (HELO unerlige-ril.intel.com) ([10.165.21.138]) by smtpauth.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Mar 2024 22:09:04 -0700 Date: Tue, 19 Mar 2024 22:09:04 -0700 Message-ID: <85le6d5w27.wl-ashutosh.dixit@intel.com> From: "Dixit, Ashutosh" To: Himal Prasad Ghimiray Cc: intel-xe@lists.freedesktop.org, Rodrigo Vivi Subject: Re: [PATCH] gpu/drm/xe/xe_devcoredump: Check NULL before dereferencing coredump. In-Reply-To: <20240320051719.3248723-1-himal.prasad.ghimiray@intel.com> References: <20240320051719.3248723-1-himal.prasad.ghimiray@intel.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?ISO-8859-4?Q?Goj=F2?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/28.2 (x86_64-redhat-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-BeenThere: intel-xe@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel Xe graphics driver List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-xe-bounces@lists.freedesktop.org Sender: "Intel-xe" On Tue, 19 Mar 2024 22:17:19 -0700, Himal Prasad Ghimiray wrote: > > Derefernce coredump to get xe_devcoredump_snapshot only if coredump is > not NULL. > > Cc: Rodrigo Vivi > Signed-off-by: Himal Prasad Ghimiray > --- > drivers/gpu/drm/xe/xe_devcoredump.c | 11 +++++++---- > 1 file changed, 7 insertions(+), 4 deletions(-) > > diff --git a/drivers/gpu/drm/xe/xe_devcoredump.c b/drivers/gpu/drm/xe/xe_devcoredump.c > index 0fcd30680323..83a1f3cd37cf 100644 > --- a/drivers/gpu/drm/xe/xe_devcoredump.c > +++ b/drivers/gpu/drm/xe/xe_devcoredump.c > @@ -74,17 +74,20 @@ static ssize_t xe_devcoredump_read(char *buffer, loff_t offset, > size_t count, void *data, size_t datalen) > { > struct xe_devcoredump *coredump = data; > + if (!coredump) Needs empty line before this line. > + return -ENODATA; > + > struct xe_device *xe = coredump_to_xe(coredump); Declarations after code statements are not premitted in standard C. Does this compile? If you fix these things looks like we're back to the original code? > + /* Our device is gone already... */ > + if (!xe) > + return -ENODEV; > + > struct xe_devcoredump_snapshot *ss = &coredump->snapshot; > struct drm_printer p; > struct drm_print_iterator iter; > struct timespec64 ts; > int i; > > - /* Our device is gone already... */ > - if (!data || !coredump_to_xe(coredump)) > - return -ENODEV; > - > /* Ensure delayed work is captured before continuing */ > flush_work(&ss->work); > > -- > 2.25.1 >