From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 83B75C369D9 for ; Wed, 30 Apr 2025 22:49:44 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id DF7C610E12B; Wed, 30 Apr 2025 22:49:43 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=intel.com header.i=@intel.com header.b="ADDMPgxp"; dkim-atps=neutral Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.14]) by gabe.freedesktop.org (Postfix) with ESMTPS id AFAD510E12B for ; Wed, 30 Apr 2025 22:49:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1746053383; x=1777589383; h=date:message-id:from:to:cc:subject:in-reply-to: references:mime-version; bh=DA6TKiRu7UgV6Gl0aSYY5nneWto92fwFAORGh6loHWY=; b=ADDMPgxptpxhsM8Lh0ljjjo+GEAw71sPCN5xjEksUh0w/IeVPRNgAgPE GUTUKz6caDieYWX5bwkuXUO+Z5Q7JWEohHAm3CWQPlPWwmgvgpe7poNuA BlfWAtQ7MzDnaUhF/dna3HkDG4paOgFbJ3sJ3XXbhGy5kZz7szVMDPFKY KIPyVCnH9oMt9NZMihGoiUGW3Jg8lHOcxD5+tG3bYUTA0SVFFeLVZINXu vPmB4wMucuWUspQdbwcQ85HZ9fEJJwdt0ioPh5RVhZ1q0aBZ6qmPRREp9 4Fri1f/FeukOBQmkWCwdfpFKp4LwUzevyrmSuKAtYVpODoxSRoGCj4rCP Q==; X-CSE-ConnectionGUID: +4QxujzLRm2b+JyUkLUorw== X-CSE-MsgGUID: Rr7MQY7HQt2wYb7x8Iltcg== X-IronPort-AV: E=McAfee;i="6700,10204,11419"; a="51551304" X-IronPort-AV: E=Sophos;i="6.15,252,1739865600"; d="scan'208";a="51551304" Received: from orviesa006.jf.intel.com ([10.64.159.146]) by orvoesa106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 30 Apr 2025 15:49:42 -0700 X-CSE-ConnectionGUID: mP7dqccCQaCnjj+DBUNhWw== X-CSE-MsgGUID: B8Hw1hSGRCyhRNF20zvWbw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.15,252,1739865600"; d="scan'208";a="134146528" Received: from orsosgc001.jf.intel.com (HELO orsosgc001.intel.com) ([10.165.21.142]) by orviesa006-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 30 Apr 2025 15:49:42 -0700 Date: Wed, 30 Apr 2025 15:49:41 -0700 Message-ID: <85r019qn7e.wl-ashutosh.dixit@intel.com> From: "Dixit, Ashutosh" To: Kees Cook Cc: Harish Chegondi , intel-xe@lists.freedesktop.org Subject: Re: [PATCH 1/1] drm/xe/eustall: Use copy_from_user() instead of __copy_from_user() In-Reply-To: <202504301151.81F35C4@keescook> References: <202504301151.81F35C4@keescook> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?ISO-8859-4?Q?Goj=F2?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/29.4 (x86_64-redhat-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-BeenThere: intel-xe@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel Xe graphics driver List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-xe-bounces@lists.freedesktop.org Sender: "Intel-xe" On Wed, 30 Apr 2025 11:51:18 -0700, Kees Cook wrote: > > On Tue, Apr 29, 2025 at 10:11:11PM -0700, Harish Chegondi wrote: > > copy_from_user() has more checks and is more safer than > > __copy_from_user() > > > > Fixes: 1537ec85ebd7 ("drm/xe/uapi: Introduce API for EU stall sampling") > > Signed-off-by: Harish Chegondi > > Thanks! > > Reviewed-by: Kees Cook Harish, could we add the other instances of __copy_from_user() also to this patch? So we can fix all of them in one go. Thanks. -- Ashutosh