From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 45583C48260 for ; Wed, 14 Feb 2024 02:51:52 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id E909D10E1E3; Wed, 14 Feb 2024 02:51:51 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=intel.com header.i=@intel.com header.b="KBDg+m9a"; dkim-atps=neutral Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.16]) by gabe.freedesktop.org (Postfix) with ESMTPS id 1E64910E33A for ; Wed, 14 Feb 2024 02:51:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1707879111; x=1739415111; h=date:message-id:from:to:cc:subject:in-reply-to: references:mime-version; bh=ZBCv6k8An4I6eHBDkW2OLvDV+d15JF9yVmg1qB6+52Y=; b=KBDg+m9aEhYZLmjxGitrWY409zPqJ62u8KL1doC1dD/7omf4ZvKLeiY7 soxNzmAamYOpDrftdzxRv85JwF1jPDBOSvb0++9uqOdk1upgx0RUWDFAp 1G/0d5NX78P7+6rf3DWYoeAqvWcYgtm0D+hQZ4jpWguQGUn+l+6K2dyfH eZLSptQJtM7N74bMVJyTffOF8a0kuylmhHp8iHeZ9Wh+Jy/KSLPrTy7I7 PbjxLLQfv9qQFepYL4LQy6/CIU1yU0wJi/FgMxZcuCYe9ZKiP11kinWI+ 2bbXDyxY/DTzB8WyGpF8NnGLp2wnpK040Vh8ncZx5Tp4r0Tk0+ehhrXGb w==; X-IronPort-AV: E=McAfee;i="6600,9927,10982"; a="2274862" X-IronPort-AV: E=Sophos;i="6.06,158,1705392000"; d="scan'208";a="2274862" Received: from fmviesa003.fm.intel.com ([10.60.135.143]) by fmvoesa110.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 Feb 2024 18:51:51 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.06,158,1705392000"; d="scan'208";a="7650910" Received: from orsosgc001.jf.intel.com (HELO unerlige-ril.intel.com) ([10.165.21.138]) by fmviesa003-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 Feb 2024 18:51:50 -0800 Date: Tue, 13 Feb 2024 18:51:50 -0800 Message-ID: <85r0hfvjuh.wl-ashutosh.dixit@intel.com> From: "Dixit, Ashutosh" To: Umesh Nerlige Ramappa Cc: intel-xe@lists.freedesktop.org Subject: Re: [PATCH 13/16] drm/xe/oa/uapi: Query OA unit properties In-Reply-To: References: <20240213064423.131601-1-ashutosh.dixit@intel.com> <20240213064423.131601-14-ashutosh.dixit@intel.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?ISO-8859-4?Q?Goj=F2?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/28.2 (x86_64-redhat-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-BeenThere: intel-xe@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel Xe graphics driver List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-xe-bounces@lists.freedesktop.org Sender: "Intel-xe" On Tue, 13 Feb 2024 12:05:15 -0800, Umesh Nerlige Ramappa wrote: > > On Mon, Feb 12, 2024 at 10:44:20PM -0800, Ashutosh Dixit wrote: > > Implement query for properties of OA units present on a device. > > > > v2: Clean up reserved/pad fields (Umesh) > > Follow the same scheme as other query structs > > v3: Skip reporting reserved engines attached to OA units > > v4: Expose oa_buf_size via DRM_XE_PERF_IOCTL_INFO (Umesh) > > v5: Don't expose capabilities as OR of properties (Umesh) > > > > Signed-off-by: Ashutosh Dixit > > lgtm, > > Reviewed-by: Umesh Nerlige Ramappa Hi Umesh, thanks a lot for completing the review of this OA series :) Ashutosh