From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 5D86FC46CD2 for ; Sat, 27 Jan 2024 20:10:15 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id DF00D10F363; Sat, 27 Jan 2024 20:10:14 +0000 (UTC) Received: from mgamail.intel.com (mgamail.intel.com [134.134.136.31]) by gabe.freedesktop.org (Postfix) with ESMTPS id 8D62110F363; Sat, 27 Jan 2024 20:10:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1706386213; x=1737922213; h=date:message-id:from:to:cc:subject:in-reply-to: references:mime-version; bh=LkkZLsAOCXfOD+qIuG4LdRejoWlXrMg68Vt62UnS9a8=; b=InI6n3Cgb1uBF6LfXXldPeVScp7k86+rY6OGX+1XugYB9uhqoGMlYX1k 9qLcoSWYrriLnfnR75z96/SQYYHNxYi3KpHN7fhOPws1oF8vI4jVTj1zt 8rrB7TBNnDgErT1qX81YYqmY8Z5/+fIGXYXcNy6RGah3NkVpBxaNt1C5G hsNYQqg91qPlxelK6orQrFFlVwNBA9pmcqJ21ae0C3QEWBpFQnmgqVJFX ilh3Sk6oTXVoafI2u9xtRMYkOx0S9x6/MWEYcZrhhUBwcW0BpmyKJS8nY /CGc+ZWHiFB4UDYKESV3iRcbVMdBLjSw9BlNVTA2rc+uMx1N8KCttUsH+ Q==; X-IronPort-AV: E=McAfee;i="6600,9927,10966"; a="466982021" X-IronPort-AV: E=Sophos;i="6.05,220,1701158400"; d="scan'208";a="466982021" Received: from orviesa002.jf.intel.com ([10.64.159.142]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 27 Jan 2024 12:10:08 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.05,220,1701158400"; d="scan'208";a="29132697" Received: from orsosgc001.jf.intel.com (HELO unerlige-ril.intel.com) ([10.165.21.138]) by orviesa002-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 27 Jan 2024 12:10:08 -0800 Date: Sat, 27 Jan 2024 12:10:08 -0800 Message-ID: <85ttmyczbz.wl-ashutosh.dixit@intel.com> From: "Dixit, Ashutosh" To: Badal Nilawar Subject: Re: [PATCH v2] drm/hwmon: Fix abi doc warnings In-Reply-To: <20240127165040.2348009-1-badal.nilawar@intel.com> References: <20240127165040.2348009-1-badal.nilawar@intel.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?ISO-8859-4?Q?Goj=F2?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/28.2 (x86_64-redhat-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-BeenThere: intel-xe@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel Xe graphics driver List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: intel-gfx@lists.freedesktop.org, lucas.demarchi@intel.com, thomas.hellstrom@intel.com, rodrigo.vivi@intel.com, intel-xe@lists.freedesktop.org Errors-To: intel-xe-bounces@lists.freedesktop.org Sender: "Intel-xe" On Sat, 27 Jan 2024 08:50:40 -0800, Badal Nilawar wrote: > Hi Badal, > This fixes warnings in xe, i915 hwmon docs > > Warning: /sys/devices/.../hwmon/hwmon/curr1_crit is defined 2 times: Documentation/ABI/testing/sysfs-driver-intel-xe-hwmon:35 Documentation/ABI/testing/sysfs-driver-intel-i915-hwmon:52 > Warning: /sys/devices/.../hwmon/hwmon/energy1_input is defined 2 times: Documentation/ABI/testing/sysfs-driver-intel-xe-hwmon:54 Documentation/ABI/testing/sysfs-driver-intel-i915-hwmon:65 > Warning: /sys/devices/.../hwmon/hwmon/in0_input is defined 2 times: Documentation/ABI/testing/sysfs-driver-intel-xe-hwmon:46 Documentation/ABI/testing/sysfs-driver-intel-i915-hwmon:0 > Warning: /sys/devices/.../hwmon/hwmon/power1_crit is defined 2 times: Documentation/ABI/testing/sysfs-driver-intel-xe-hwmon:22 Documentation/ABI/testing/sysfs-driver-intel-i915-hwmon:39 > Warning: /sys/devices/.../hwmon/hwmon/power1_max is defined 2 times: Documentation/ABI/testing/sysfs-driver-intel-xe-hwmon:0 Documentation/ABI/testing/sysfs-driver-intel-i915-hwmon:8 > Warning: /sys/devices/.../hwmon/hwmon/power1_max_interval is defined 2 times: Documentation/ABI/testing/sysfs-driver-intel-xe-hwmon:62 Documentation/ABI/testing/sysfs-driver-intel-i915-hwmon:30 > Warning: /sys/devices/.../hwmon/hwmon/power1_rated_max is defined 2 times: Documentation/ABI/testing/sysfs-driver-intel-xe-hwmon:14 Documentation/ABI/testing/sysfs-driver-intel-i915-hwmon:22 /snip/ > diff --git a/Documentation/ABI/testing/sysfs-driver-intel-i915-hwmon b/Documentation/ABI/testing/sysfs-driver-intel-i915-hwmon > index 8d7d8f05f6cd..92fe7c5c5ac1 100644 > --- a/Documentation/ABI/testing/sysfs-driver-intel-i915-hwmon > +++ b/Documentation/ABI/testing/sysfs-driver-intel-i915-hwmon > @@ -1,4 +1,4 @@ > -What: /sys/devices/.../hwmon/hwmon/in0_input Are the warnings happening because this path doesn't exist? > +What: /sys/bus/pci/drivers/i915/.../hwmon/hwmon/in0_input So this I guess could also be /sys/class/drm/card/device/hwmon/hwmon/in0_input? But no need to change, what you have is also a valid path. But maybe to make clear: /sys/bus/pci/drivers/i915//hwmon/hwmon/in0_input ? But anyway... Assuming you turned on the htmldoc build option, could reproduce this and verified that this patch is fixing these warnings, this is: Reviewed-by: Ashutosh Dixit