From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 3776AC27C52 for ; Thu, 6 Jun 2024 19:56:16 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id C27CD10E090; Thu, 6 Jun 2024 19:56:15 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=intel.com header.i=@intel.com header.b="JmZTd+LW"; dkim-atps=neutral Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.10]) by gabe.freedesktop.org (Postfix) with ESMTPS id 9790610E090 for ; Thu, 6 Jun 2024 19:56:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1717703774; x=1749239774; h=date:message-id:from:to:cc:subject:in-reply-to: references:mime-version:content-transfer-encoding; bh=cgBwCYnGNEcmXbS+yY8ENIlZ4LZbKKsP8R6ZsfXLD6Y=; b=JmZTd+LWQcHZteS05IcWULHyIQwI1Ig+g/iUQ693lUxwy+EEW/rvGjaS Ot5ndMKzrMNDkaiRE6NXlEU1Y+GF4gyaHhBa5CclldmyyoS6+6YJ4iY5r Uk4PTmE7pVRsyODAqF2SS8uHXy1sDv3QYa5jFQnUhEkYojblp6V+9ObWb 1UII4CE+J8skSnJEoNUGP5yjyyaFwlifqxh/EPNv5wxsMDd6pqSJ1J4iG O2I2UK4yqAiRQAxTwryVFunspk30EiUGSUJ3Dgkq2JxestXUYSl5xejiC 0c0ClBgMpz0SCHORUTh5lYKbEPV9aVqOHsrnu86RwLOnQdItYM9gttMVb w==; X-CSE-ConnectionGUID: GgVzb9tiS+qTs5Jag8Kqsw== X-CSE-MsgGUID: z5vd9broRpm/Q2y1sHk+jw== X-IronPort-AV: E=McAfee;i="6600,9927,11095"; a="25799016" X-IronPort-AV: E=Sophos;i="6.08,219,1712646000"; d="scan'208";a="25799016" Received: from fmviesa001.fm.intel.com ([10.60.135.141]) by fmvoesa104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 06 Jun 2024 12:56:14 -0700 X-CSE-ConnectionGUID: d7+BxQ1pS2K9ZjS3hZIwQg== X-CSE-MsgGUID: gEDxaupTTs2PYTboJyG9Ng== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.08,219,1712646000"; d="scan'208";a="69245398" Received: from orsosgc001.jf.intel.com (HELO orsosgc001.intel.com) ([10.165.21.138]) by smtpauth.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 06 Jun 2024 12:56:13 -0700 Date: Thu, 06 Jun 2024 12:56:13 -0700 Message-ID: <85v82ldew2.wl-ashutosh.dixit@intel.com> From: "Dixit, Ashutosh" To: "Souza, Jose" Cc: "intel-xe@lists.freedesktop.org" Subject: Re: [PATCH v15 00/17] Add OA functionality to Xe In-Reply-To: <6bee6a666dd0ab8440ca74d692a80788bfb1d748.camel@intel.com> References: <20240527014333.603914-1-ashutosh.dixit@intel.com> <6bee6a666dd0ab8440ca74d692a80788bfb1d748.camel@intel.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?ISO-8859-4?Q?Goj=F2?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/28.2 (x86_64-redhat-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable X-BeenThere: intel-xe@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel Xe graphics driver List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-xe-bounces@lists.freedesktop.org Sender: "Intel-xe" On Wed, 05 Jun 2024 07:12:54 -0700, Souza, Jose wrote: > Hi Jose, > On Sun, 2024-05-26 at 18:43 -0700, Ashutosh Dixit wrote: > > Please see cover letter for v7 here: > > https://patchwork.freedesktop.org/series/121084/#rev7 > > > > For changes in later versions see changelog below. > > > > This series is also available at: > > https://gitlab.freedesktop.org/adixit/kernel/-/tree/xe-oa > > > > The series has been tested against this IGT series: > > https://gitlab.freedesktop.org/adixit/igt-gpu-tools/-/tree/xe-oa > > or, > > https://patchwork.freedesktop.org/series/130033/ > > > > Opensource consumers using uapi in this series: > > > > gpuvis: > > https://github.com/mikesart/gpuvis/pull/86 > > > > mesa: > > https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/29312 > > > > Test-with: 20240524031439.106332-1-ashutosh.dixit@intel.com > > > > As first round this uAPI looks good for Mesa usage, second round after > this ones is merged will add additional features and uAPIs need to > support all Mesa needs. Correct. Copy/paste from another email in this thread, this is what we are looking at for the second round: * hold preemption (needs some investigation as to feasibility) * xe_sync for OA stream configuration and reconfiguration * Equivalent of DRM_I915_QUERY_PERF_CONFIG_DATA_FOR_UUID. I am still trying to figure out if this is really needed. See here: https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/29312#note_2429= 650 Since this seems to be using some MDAPI metrics in Mesa, I think it should be ok to do this in the second round too. > Acked-by: Jos=E9 Roberto de Souza Thanks very much for the Mesa ack. I will start asking the Xe maintainers if this (and gpuvis PR which is also merged) is sufficient to merge this series now. Thanks. -- Ashutosh > thank you > > > v2: Fix build > > v3: Rebase, due to s/xe_engine/xe_exec_queue/ > > v4: Re-run for testing > > v5: Address review comments, new patches 11 through 17 > > v6: New patches 18 through 21 > > v7: Patches are completely redone and don't start with i915 version of = the uapi > > v8: See https://patchwork.freedesktop.org/patch/575214/?series=3D128993= &rev=3D1 > > v9: See https://patchwork.freedesktop.org/patch/577441/?series=3D128993= &rev=3D2 > > v10: See https://patchwork.freedesktop.org/patch/577943/?series=3D12899= 3&rev=3D3 > > v11: See https://patchwork.freedesktop.org/patch/581239/?series=3D13070= 5&rev=3D1 > > v12: Add last two new patches to enable Xe2+ overrun mode > > v13: Update last two patches after code review completion > > v14: https://patchwork.freedesktop.org/patch/595447/?series=3D134028&re= v=3D1 > > v15: https://patchwork.freedesktop.org/patch/595549/?series=3D134056&re= v=3D1 > > > > Ashutosh Dixit (17): > > drm/xe/perf/uapi: "Perf" layer to support multiple perf counter stream > > types > > drm/xe/perf/uapi: Add perf_stream_paranoid sysctl > > drm/xe/oa/uapi: Add OA data formats > > drm/xe/oa/uapi: Initialize OA units > > drm/xe/oa/uapi: Add/remove OA config perf ops > > drm/xe/oa/uapi: Define and parse OA stream properties > > drm/xe/oa: OA stream initialization (OAG) > > drm/xe/oa/uapi: Expose OA stream fd > > drm/xe/oa/uapi: Read file_operation > > drm/xe/oa: Add OAR support > > drm/xe/oa: Add OAC support > > drm/xe/oa/uapi: Query OA unit properties > > drm/xe/oa/uapi: OA buffer mmap > > drm/xe/oa: Add MMIO trigger support > > drm/xe/oa: Override GuC RC with OA on PVC > > drm/xe/oa: Changes to OA_TAKEN > > drm/xe/oa: Enable Xe2+ overrun mode > > > > drivers/gpu/drm/xe/Makefile | 2 + > > .../gpu/drm/xe/instructions/xe_mi_commands.h | 3 + > > drivers/gpu/drm/xe/regs/xe_engine_regs.h | 2 + > > drivers/gpu/drm/xe/regs/xe_gt_regs.h | 3 + > > drivers/gpu/drm/xe/regs/xe_oa_regs.h | 103 + > > drivers/gpu/drm/xe/xe_device.c | 19 +- > > drivers/gpu/drm/xe/xe_device_types.h | 4 + > > drivers/gpu/drm/xe/xe_gt_types.h | 4 + > > drivers/gpu/drm/xe/xe_guc_pc.c | 57 + > > drivers/gpu/drm/xe/xe_guc_pc.h | 3 + > > drivers/gpu/drm/xe/xe_hw_engine_types.h | 2 + > > drivers/gpu/drm/xe/xe_lrc.c | 11 +- > > drivers/gpu/drm/xe/xe_lrc.h | 1 + > > drivers/gpu/drm/xe/xe_module.c | 6 + > > drivers/gpu/drm/xe/xe_oa.c | 2370 +++++++++++++++++ > > drivers/gpu/drm/xe/xe_oa.h | 27 + > > drivers/gpu/drm/xe/xe_oa_types.h | 232 ++ > > drivers/gpu/drm/xe/xe_perf.c | 67 + > > drivers/gpu/drm/xe/xe_perf.h | 20 + > > drivers/gpu/drm/xe/xe_query.c | 77 + > > drivers/gpu/drm/xe/xe_reg_whitelist.c | 24 +- > > include/uapi/drm/xe_drm.h | 291 ++ > > 22 files changed, 3321 insertions(+), 7 deletions(-) > > create mode 100644 drivers/gpu/drm/xe/regs/xe_oa_regs.h > > create mode 100644 drivers/gpu/drm/xe/xe_oa.c > > create mode 100644 drivers/gpu/drm/xe/xe_oa.h > > create mode 100644 drivers/gpu/drm/xe/xe_oa_types.h > > create mode 100644 drivers/gpu/drm/xe/xe_perf.c > > create mode 100644 drivers/gpu/drm/xe/xe_perf.h > > >