From: "Dixit, Ashutosh" <ashutosh.dixit@intel.com>
To: "Cavitt, Jonathan" <jonathan.cavitt@intel.com>
Cc: "Nerlige Ramappa, Umesh" <umesh.nerlige.ramappa@intel.com>,
"intel-xe@lists.freedesktop.org" <intel-xe@lists.freedesktop.org>,
"Souza, Jose" <jose.souza@intel.com>
Subject: Re: [PATCH v5 1/2] xe/oa: Fix query mode of operation for OAR/OAC
Date: Fri, 20 Dec 2024 10:24:45 -0800 [thread overview]
Message-ID: <85wmfu5i1e.wl-ashutosh.dixit@intel.com> (raw)
In-Reply-To: <BL1PR11MB54457FB542D12F9E10AB2AD2E5072@BL1PR11MB5445.namprd11.prod.outlook.com>
On Fri, 20 Dec 2024 10:08:41 -0800, Cavitt, Jonathan wrote:
>
> > diff --git a/drivers/gpu/drm/xe/xe_ring_ops.c b/drivers/gpu/drm/xe/xe_ring_ops.c
> > index 3a75a08b6be9..c8ab37fa0d19 100644
> > --- a/drivers/gpu/drm/xe/xe_ring_ops.c
> > +++ b/drivers/gpu/drm/xe/xe_ring_ops.c
> > @@ -223,7 +223,10 @@ static int emit_pipe_imm_ggtt(u32 addr, u32 value, bool stall_only, u32 *dw,
> >
> > static u32 get_ppgtt_flag(struct xe_sched_job *job)
> > {
> > - return job->q->vm ? BIT(8) : 0;
> > + if (job->q->vm && !job->ggtt)
> > + return BIT(8);
>
> Non-blocking question:
> I'm assuming that xe_oa_submit_bb isn't the only function that can submit
> jobs for get_ppgtt_flag to decode, because otherwise job->ggtt would always
> return true?
Look at callers of xe_sched_job_push.
next prev parent reply other threads:[~2024-12-20 18:24 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-20 17:19 [PATCH v5 0/2] Fixes for MI_REPORT_PERF_COUNT Umesh Nerlige Ramappa
2024-12-20 17:19 ` [PATCH v5 1/2] xe/oa: Fix query mode of operation for OAR/OAC Umesh Nerlige Ramappa
2024-12-20 18:08 ` Cavitt, Jonathan
2024-12-20 18:24 ` Dixit, Ashutosh [this message]
2024-12-20 18:51 ` Cavitt, Jonathan
2024-12-20 22:00 ` Dixit, Ashutosh
2024-12-20 17:19 ` [PATCH v5 2/2] xe/oa: Drop the unused logic to parse context image Umesh Nerlige Ramappa
2024-12-20 18:09 ` Cavitt, Jonathan
2024-12-20 18:03 ` ✓ CI.Patch_applied: success for Fixes for MI_REPORT_PERF_COUNT (rev5) Patchwork
2024-12-20 18:03 ` ✓ CI.checkpatch: " Patchwork
2024-12-20 18:05 ` ✓ CI.KUnit: " Patchwork
2024-12-20 18:23 ` ✓ CI.Build: " Patchwork
2024-12-20 18:25 ` ✓ CI.Hooks: " Patchwork
2024-12-20 18:27 ` ✓ CI.checksparse: " Patchwork
2024-12-20 18:59 ` ✓ Xe.CI.BAT: " Patchwork
2024-12-20 19:54 ` [PATCH v5 0/2] Fixes for MI_REPORT_PERF_COUNT Souza, Jose
2024-12-20 20:05 ` Dixit, Ashutosh
2024-12-21 0:35 ` Umesh Nerlige Ramappa
2024-12-21 22:41 ` ✗ Xe.CI.Full: failure for Fixes for MI_REPORT_PERF_COUNT (rev5) Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=85wmfu5i1e.wl-ashutosh.dixit@intel.com \
--to=ashutosh.dixit@intel.com \
--cc=intel-xe@lists.freedesktop.org \
--cc=jonathan.cavitt@intel.com \
--cc=jose.souza@intel.com \
--cc=umesh.nerlige.ramappa@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox