From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id EF90BC71136 for ; Mon, 16 Jun 2025 22:26:32 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id B19D910E464; Mon, 16 Jun 2025 22:26:32 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=intel.com header.i=@intel.com header.b="VOcNQIP6"; dkim-atps=neutral Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.19]) by gabe.freedesktop.org (Postfix) with ESMTPS id 3C47E10E464 for ; Mon, 16 Jun 2025 22:26:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1750112791; x=1781648791; h=date:message-id:from:to:cc:subject:in-reply-to: references:mime-version; bh=uufh8zLND+EDUgpoQT/6FnPIt+39OtJI86s1Ri1ny2k=; b=VOcNQIP6SROOnFjNBV8QKOTwO6ime6XB2OHHXG4kZyI2ZhAD0wAOmC0m 0aPRQOgWAYR204+VKf61qYu2vrs2eZMmv8G8wVGOrX9zucf5/td5Igzlv zPDoceUes4GIEVFzUhFm8snys5N3ii4LauIATvANwykzcivWliXDLmg+Y dsiLmkBLqCN/YvqGg2XcUCJW0hQ400mTlqI0yAPNvUc7AU2sw4m1xSSI8 vfAtEudoUG+yfGY8b4WP+AdX0CXaFFsx+FZJ9S+7RCgWNyEiy61cwhxXl 7/Eh0FzOl0+HCFRk/HX8D3PDNG03CGHr7AxhGOyIso03z3BFKrGSJQ8t4 A==; X-CSE-ConnectionGUID: 81v4txVLQfCrCGee5n5AXQ== X-CSE-MsgGUID: 2Un1q/Z1ShWaa/ivf7gpmg== X-IronPort-AV: E=McAfee;i="6800,10657,11465"; a="51379874" X-IronPort-AV: E=Sophos;i="6.16,241,1744095600"; d="scan'208";a="51379874" Received: from fmviesa008.fm.intel.com ([10.60.135.148]) by fmvoesa113.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 16 Jun 2025 15:26:31 -0700 X-CSE-ConnectionGUID: bXAQ/QXZTHGHFrIaD57gKA== X-CSE-MsgGUID: ZbHHyvt1S3GPVQKAJKv9Lg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.16,241,1744095600"; d="scan'208";a="148957831" Received: from orsosgc001.jf.intel.com (HELO orsosgc001.intel.com) ([10.165.21.142]) by fmviesa008-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 16 Jun 2025 15:26:31 -0700 Date: Mon, 16 Jun 2025 15:26:30 -0700 Message-ID: <85zfe7jpbd.wl-ashutosh.dixit@intel.com> From: "Dixit, Ashutosh" To: Cc: Umesh Nerlige Ramappa Subject: Re: [PATCH 1/5] drm/xe/oa/uapi: Expose media OA units In-Reply-To: <87wm9j2oim.wl-ashutosh.dixit@intel.com> References: <20250606160253.4054668-1-ashutosh.dixit@intel.com> <20250606160253.4054668-2-ashutosh.dixit@intel.com> <87tt4su15k.wl-ashutosh.dixit@intel.com> <87wm9j2oim.wl-ashutosh.dixit@intel.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?ISO-8859-4?Q?Goj=F2?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/29.4 (x86_64-redhat-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-BeenThere: intel-xe@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel Xe graphics driver List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-xe-bounces@lists.freedesktop.org Sender: "Intel-xe" On Tue, 10 Jun 2025 15:57:37 -0700, Dixit, Ashutosh wrote: > > On Fri, 06 Jun 2025 12:21:11 -0700, Dixit, Ashutosh wrote: > > > > On Fri, 06 Jun 2025 10:37:53 -0700, Umesh Nerlige Ramappa wrote: > > > > > > On Fri, Jun 06, 2025 at 09:02:49AM -0700, Ashutosh Dixit wrote: > > > > On Xe2+ platforms, media engines are attached to "SCMI" OA media (OAM) > > > > units. One or more SCMI OAM units might be present on a platform. In > > > > addition there is another OAM unit for global events, called > > > > OAM-SAG. Performance metrics for media workloads can be obtained from these > > > > OAM units, similar to OAG. > > > > > > > > Expose these OAM units for userspace to use. OAM-SAG is exposed as an OA > > > > unit without any attached engines. > > > > > > > > Bspec: 70819, 67103, 63844, 72572, 74476, 61284 > > > > > > > > v2: Fix xe_gt_WARN_ON in __hwe_oam_unit for < 12.7 platforms > > > > v3: Return XE_OA_UNIT_INVALID for < 12.7 to indicate no OAM units > > > > v4: Move xe_oa_print_oa_units() to separate patch > > > > v5: Introduce DRM_XE_OA_UNIT_TYPE_OAM_SAG > > > > > > > > Signed-off-by: Ashutosh Dixit > > > > > > LGTM, > > > > > > Reviewed-by: Umesh Nerlige Ramappa > > > > Thanks Umesh. I also just added a DRM_XE_OA_CAPS_OAM capability also to > > this patch. I was debating initially, since userland will see at least 2 > > OAM units after this series is merged, so that is the way to figure out if > > correct OAM support is present in the driver. But then went ahead and added > > DRM_XE_OA_CAPS_OAM, since that's how we've been doing things: if you change > > uapi, you add a capability. Thanks. > > MDAPI PR which consumes uapi changes in this patch: > > https://github.com/intel/metrics-discovery/pull/35 More user space updates for this series: - IGT xe perf tools update: https://patchwork.freedesktop.org/series/150274/ - gpuvis PR: https://github.com/mikesart/gpuvis/pull/100/