From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D50CFC02198 for ; Sun, 16 Feb 2025 05:49:46 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 826F810E048; Sun, 16 Feb 2025 05:49:46 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=intel.com header.i=@intel.com header.b="XGaOYTMS"; dkim-atps=neutral Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.15]) by gabe.freedesktop.org (Postfix) with ESMTPS id D151B10E048 for ; Sun, 16 Feb 2025 05:49:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1739684985; x=1771220985; h=date:message-id:from:to:cc:subject:in-reply-to: references:mime-version; bh=CmMvFRj6F5BmDAqyEvhPJhhpb5rXmnP6t4CL8mzj5V8=; b=XGaOYTMSbbd7tH9ESmrDVl9jPp5p3xXtzOMO5tepkW00yKwyZLMf2ljp 1Le4QwrxA/i2AxWN1Xg8/IL7RmsYHL9vAXNy1NsEvf6kHiD99tZt50ENV pCVmLVdpCMKj0k9ENVctxyzdW2ewtC0qhzJFKu5pGMY/KFe9NMxRuzhZQ hvaRpv9P8rwQ0DbjNbUkgXN5vYzA8IQo0zFkA2CRxuASE12Lpqm2B/hJA YwYQrYSDMGT6q+P5G2RzvOA9ZDokA5WnsYNaVCu5xKe7wV1REEqYaf7NH ndsl21VEmvPaCOjA2/8zwPkvxRk+/Nnh3GuJwwRdPvTpuG2p5iR+Wwjhb Q==; X-CSE-ConnectionGUID: std4NjH3SFGorZ/9qcCNVA== X-CSE-MsgGUID: m0ZmYwxuQaufRlBzDSJ2RA== X-IronPort-AV: E=McAfee;i="6700,10204,11346"; a="40531067" X-IronPort-AV: E=Sophos;i="6.13,290,1732608000"; d="scan'208";a="40531067" Received: from orviesa008.jf.intel.com ([10.64.159.148]) by fmvoesa109.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 15 Feb 2025 21:49:44 -0800 X-CSE-ConnectionGUID: QxMnmALUSOCk6y/OpjThag== X-CSE-MsgGUID: /C2iD+DmR/i2L8s4ZDg/LA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.12,224,1728975600"; d="scan'208";a="114720641" Received: from orsosgc001.jf.intel.com (HELO orsosgc001.intel.com) ([10.165.21.142]) by orviesa008-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 15 Feb 2025 21:49:44 -0800 Date: Sat, 15 Feb 2025 21:49:43 -0800 Message-ID: <85zfim1ls8.wl-ashutosh.dixit@intel.com> From: "Dixit, Ashutosh" To: Harish Chegondi Cc: Subject: Re: [PATCH v9 2/8] drm/xe/uapi: Introduce API for EU stall sampling In-Reply-To: References: <36d701413aeb171c86d5dd2ce7272918eb4ab818.1739193510.git.harish.chegondi@intel.com> <85h6512ybc.wl-ashutosh.dixit@intel.com> <85v7te7eks.wl-ashutosh.dixit@intel.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?ISO-8859-4?Q?Goj=F2?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/28.2 (x86_64-redhat-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-BeenThere: intel-xe@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel Xe graphics driver List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-xe-bounces@lists.freedesktop.org Sender: "Intel-xe" On Sat, 15 Feb 2025 17:49:16 -0800, Harish Chegondi wrote: > > > > > > +struct eu_stall_open_properties { > > > > > + unsigned int sampling_rate_mult; > > > > > + unsigned int wait_num_reports; > > > > > > > > I already said no need to be so specific. Just use int or u32 as types for > > > > these. > > > Okay, will try to change these back to u8/u32 in the next version. > > > > Use int or u32, not u8. > Any reason why I can't use u8? The maximum value of sampling_rate_mult > is 7. Use whatever you want. The real question to ask is why can't we use a generic type like int? Whether you use u8 or int, the CPU will still fetch a 64 byte cacheline. And this structure is only used at initialization, so performance is not a concern.