Intel-XE Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Gustavo Sousa <gustavo.sousa@intel.com>
To: Shuicheng Lin <shuicheng.lin@intel.com>,
	<intel-xe@lists.freedesktop.org>
Cc: Shuicheng Lin <shuicheng.lin@intel.com>,
	Zhanjun Dong <zhanjun.dong@intel.com>
Subject: Re: [PATCH] drm/xe/mcr: Remove unused xe_gt_mcr_steering_info_to_dss_id()
Date: Tue, 28 Apr 2026 17:55:41 -0300	[thread overview]
Message-ID: <871pfypzxu.fsf@intel.com> (raw)
In-Reply-To: <20260422155025.3660484-1-shuicheng.lin@intel.com>

Shuicheng Lin <shuicheng.lin@intel.com> writes:

> The function xe_gt_mcr_steering_info_to_dss_id() has had no callers
> since commit fa597710be6e ("drm/xe/guc: Cache DSS info when creating
> capture register list") which removed the only call site in
> xe_guc_capture.c. Remove the dead function and its declaration.
>
> No functional change.
>
> Signed-off-by: Shuicheng Lin <shuicheng.lin@intel.com>

Reviewed-by: Gustavo Sousa <gustavo.sousa@intel.com>

> ---
> Cc: Zhanjun Dong <zhanjun.dong@intel.com>
> ---
>  drivers/gpu/drm/xe/xe_gt_mcr.c | 13 -------------
>  drivers/gpu/drm/xe/xe_gt_mcr.h |  1 -
>  2 files changed, 14 deletions(-)
>
> diff --git a/drivers/gpu/drm/xe/xe_gt_mcr.c b/drivers/gpu/drm/xe/xe_gt_mcr.c
> index 7c6f039c880d..4bbe052d6d68 100644
> --- a/drivers/gpu/drm/xe/xe_gt_mcr.c
> +++ b/drivers/gpu/drm/xe/xe_gt_mcr.c
> @@ -430,19 +430,6 @@ void xe_gt_mcr_get_dss_steering(const struct xe_gt *gt, unsigned int dss, u16 *g
>  	*instance = dss % gt->steering_dss_per_grp;
>  }
>  
> -/**
> - * xe_gt_mcr_steering_info_to_dss_id - Get DSS ID from group/instance steering
> - * @gt: GT structure
> - * @group: steering group ID
> - * @instance: steering instance ID
> - *
> - * Return: the converted DSS id.
> - */
> -u32 xe_gt_mcr_steering_info_to_dss_id(struct xe_gt *gt, u16 group, u16 instance)
> -{
> -	return group * dss_per_group(gt) + instance;
> -}
> -
>  static void init_steering_dss(struct xe_gt *gt)
>  {
>  	gt->steering_dss_per_grp = dss_per_group(gt);
> diff --git a/drivers/gpu/drm/xe/xe_gt_mcr.h b/drivers/gpu/drm/xe/xe_gt_mcr.h
> index 283a1c9770e2..2be9419b8acc 100644
> --- a/drivers/gpu/drm/xe/xe_gt_mcr.h
> +++ b/drivers/gpu/drm/xe/xe_gt_mcr.h
> @@ -33,7 +33,6 @@ bool xe_gt_mcr_get_nonterminated_steering(struct xe_gt *gt,
>  void xe_gt_mcr_steering_dump(struct xe_gt *gt, struct drm_printer *p);
>  void xe_gt_mcr_get_dss_steering(const struct xe_gt *gt,
>  				unsigned int dss, u16 *group, u16 *instance);
> -u32 xe_gt_mcr_steering_info_to_dss_id(struct xe_gt *gt, u16 group, u16 instance);
>  
>  /*
>   * Loop over each DSS and determine the group and instance IDs that
> -- 
> 2.43.0

      parent reply	other threads:[~2026-04-28 20:55 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-04-22 15:50 [PATCH] drm/xe/mcr: Remove unused xe_gt_mcr_steering_info_to_dss_id() Shuicheng Lin
2026-04-22 15:58 ` ✓ CI.KUnit: success for " Patchwork
2026-04-22 21:53 ` ✗ Xe.CI.FULL: failure " Patchwork
2026-04-29 18:46   ` Lin, Shuicheng
2026-04-23  6:37 ` ✓ Xe.CI.BAT: success " Patchwork
2026-04-28 20:55 ` Gustavo Sousa [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=871pfypzxu.fsf@intel.com \
    --to=gustavo.sousa@intel.com \
    --cc=intel-xe@lists.freedesktop.org \
    --cc=shuicheng.lin@intel.com \
    --cc=zhanjun.dong@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox