Re: [PATCH 0/5] drm/xe/display: Rework display init for reducing flickering.

[Jani Nikula <jani.nikula@linux.intel.com>]

On Fri, 06 Dec 2024, Maarten Lankhorst <dev@lankhorst.se> wrote:
> I have rebased the previous series and took out the GuC parts. This makes it a lot easier to review missing parts,
> and not be dependent on GuC loading changes for merging.

I think all of the patches need more explanations in the commit
messages. Why are we doing this? Why is this okay? How does this work
with the plans to unify display code between i915 and xe, especially wrt
the init ordering and the expectations on irqs.

BR,
Jani.




>
> Maarten Lankhorst (5):
>   drm/xe/display: Add intel_plane_initial_vblank_wait
>   drm/xe: Remove double pageflip
>   drm/xe: Move suballocator init to after display init
>   drm/xe: Defer irq init until after xe_display_init_noaccel
>   drm/xe/display: Use a single early init call for display
>
>  drivers/gpu/drm/i915/display/intel_display.c  |  6 +-
>  .../drm/i915/display/intel_plane_initial.c    |  7 +-
>  .../drm/i915/display/intel_plane_initial.h    |  2 +
>  drivers/gpu/drm/xe/display/xe_display.c       | 71 +++++--------------
>  drivers/gpu/drm/xe/display/xe_display.h       |  8 +--
>  drivers/gpu/drm/xe/display/xe_plane_initial.c | 29 +++++---
>  drivers/gpu/drm/xe/xe_device.c                | 28 +++-----
>  drivers/gpu/drm/xe/xe_tile.c                  | 19 +++--
>  drivers/gpu/drm/xe/xe_tile.h                  |  1 +
>  9 files changed, 77 insertions(+), 94 deletions(-)

-- 
Jani Nikula, Intel