From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 39DCDCD4857 for ; Wed, 4 Sep 2024 16:04:36 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id C914910E7FB; Wed, 4 Sep 2024 16:04:35 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=intel.com header.i=@intel.com header.b="c20RROKy"; dkim-atps=neutral Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.15]) by gabe.freedesktop.org (Postfix) with ESMTPS id F0DCA10E7FB for ; Wed, 4 Sep 2024 16:04:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1725465875; x=1757001875; h=date:message-id:from:to:cc:subject:in-reply-to: references:mime-version; bh=psRiJeGo6UiVpxlkYk7eROQDcsc7EM5cptNXBcyvLjo=; b=c20RROKyCYb1N+wvCMECcnE9Xyaq0n+NC3EL/BzMBhFGNO/nQlxFUgHW DZ3nJYSKKsIQ6NbUJcL2wDM1HIw8Ft0IWEpQ+9nmVo+eRCt8Ho0q5pZ17 X1WYlqqaPjYdfHGXAVVOSuvdhUQSxhHSS3HVkkVNDfKFgY4gdIA5/2znI lK3r5Zm8s1nmi4R4TrDJKL8+jDfZc9nobDTmyd7daV+h1cFtEqvXOCTYR RzKoawn8Y+x5ckDLC2LSb9sX4jTrN5wIC2J2nud+LciSovdgIHtzYIH10 GQ/GsLM5jxwn/sE67WAFyklFPrH1Z3bFMSsGJkWhyFMhgwu8DKAwMDug3 A==; X-CSE-ConnectionGUID: ri6V653mT/62BRKPrEsARA== X-CSE-MsgGUID: hMgLcGBERdmJrKX1ehKg2A== X-IronPort-AV: E=McAfee;i="6700,10204,11185"; a="27896638" X-IronPort-AV: E=Sophos;i="6.10,202,1719903600"; d="scan'208";a="27896638" Received: from fmviesa005.fm.intel.com ([10.60.135.145]) by orvoesa107.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 04 Sep 2024 09:04:34 -0700 X-CSE-ConnectionGUID: vJW5SfPPRPCqJcwhfxVFQQ== X-CSE-MsgGUID: gC8U7wH+Rjasrej4Xi7Hdw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.10,202,1719903600"; d="scan'208";a="69724254" Received: from unknown (HELO adixit-arch.intel.com) ([10.57.129.167]) by fmviesa005-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 04 Sep 2024 09:04:34 -0700 Date: Wed, 04 Sep 2024 08:54:40 -0700 Message-ID: <871q1zza67.wl-ashutosh.dixit@intel.com> From: "Dixit, Ashutosh" To: Jani Nikula Cc: intel-xe@lists.freedesktop.org Subject: Re: [PATCH] drm/xe: use IS_ENABLED() instead of defined() on config options In-Reply-To: <20240904145231.3902289-1-jani.nikula@intel.com> References: <20240904145231.3902289-1-jani.nikula@intel.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?ISO-8859-4?Q?Goj=F2?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/29.4 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-BeenThere: intel-xe@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel Xe graphics driver List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-xe-bounces@lists.freedesktop.org Sender: "Intel-xe" On Wed, 04 Sep 2024 07:52:31 -0700, Jani Nikula wrote: > > Prefer IS_ENABLED() instead of defined() for checking whether a kconfig > option is enabled. Reviewed-by: Ashutosh Dixit > > Signed-off-by: Jani Nikula > --- > drivers/gpu/drm/xe/xe_bo.c | 2 +- > drivers/gpu/drm/xe/xe_gt_sriov_vf_debugfs.c | 2 +- > drivers/gpu/drm/xe/xe_guc.c | 2 +- > 3 files changed, 3 insertions(+), 3 deletions(-) > > diff --git a/drivers/gpu/drm/xe/xe_bo.c b/drivers/gpu/drm/xe/xe_bo.c > index 06911e9a3bf5..53948a965404 100644 > --- a/drivers/gpu/drm/xe/xe_bo.c > +++ b/drivers/gpu/drm/xe/xe_bo.c > @@ -468,7 +468,7 @@ static int xe_ttm_io_mem_reserve(struct ttm_device *bdev, > mem->bus.offset += vram->io_start; > mem->bus.is_iomem = true; > > -#if !defined(CONFIG_X86) > +#if !IS_ENABLED(CONFIG_X86) > mem->bus.caching = ttm_write_combined; > #endif > return 0; > diff --git a/drivers/gpu/drm/xe/xe_gt_sriov_vf_debugfs.c b/drivers/gpu/drm/xe/xe_gt_sriov_vf_debugfs.c > index f3ddcbefc6bc..2ed5b6780d30 100644 > --- a/drivers/gpu/drm/xe/xe_gt_sriov_vf_debugfs.c > +++ b/drivers/gpu/drm/xe/xe_gt_sriov_vf_debugfs.c > @@ -33,7 +33,7 @@ static const struct drm_info_list vf_info[] = { > .show = xe_gt_debugfs_simple_show, > .data = xe_gt_sriov_vf_print_version, > }, > -#if defined(CONFIG_DRM_XE_DEBUG) || defined(CONFIG_DRM_XE_DEBUG_SRIOV) > +#if IS_ENABLED(CONFIG_DRM_XE_DEBUG) || IS_ENABLED(CONFIG_DRM_XE_DEBUG_SRIOV) > { > "runtime_regs", > .show = xe_gt_debugfs_simple_show, > diff --git a/drivers/gpu/drm/xe/xe_guc.c b/drivers/gpu/drm/xe/xe_guc.c > index 52df28032a6f..db667850c8b8 100644 > --- a/drivers/gpu/drm/xe/xe_guc.c > +++ b/drivers/gpu/drm/xe/xe_guc.c > @@ -583,7 +583,7 @@ static s32 guc_pc_get_cur_freq(struct xe_guc_pc *guc_pc) > * extreme thermal throttling. And a system that is that hot during boot is probably > * dead anyway! > */ > -#if defined(CONFIG_DRM_XE_DEBUG) > +#if IS_ENABLED(CONFIG_DRM_XE_DEBUG) > #define GUC_LOAD_RETRY_LIMIT 20 > #else > #define GUC_LOAD_RETRY_LIMIT 3 > -- > 2.39.2 >