From: "Dixit, Ashutosh" <ashutosh.dixit@intel.com>
To: Francois Dugast <francois.dugast@intel.com>
Cc: intel-xe@lists.freedesktop.org, Rodrigo Vivi <rodrigo.vivi@intel.com>
Subject: Re: [Intel-xe] [PATCH v5 10/20] drm/xe: Remove XE_EXEC_QUEUE_SET_PROPERTY_COMPUTE_MODE from uAPI
Date: Tue, 17 Oct 2023 08:37:47 -0700 [thread overview]
Message-ID: <871qdtdzuc.wl-ashutosh.dixit@intel.com> (raw)
In-Reply-To: <20231006095943.7-11-francois.dugast@intel.com>
On Fri, 06 Oct 2023 02:59:33 -0700, Francois Dugast wrote:
>
Hi Francois,
> diff --git a/include/uapi/drm/xe_drm.h b/include/uapi/drm/xe_drm.h
> index ad21ba1d6e0b..2a9e04024723 100644
> --- a/include/uapi/drm/xe_drm.h
> +++ b/include/uapi/drm/xe_drm.h
> @@ -781,21 +781,14 @@ struct drm_xe_exec_queue_set_property {
> /** @exec_queue_id: Exec queue ID */
> __u32 exec_queue_id;
>
> -#define XE_EXEC_QUEUE_SET_PROPERTY_PRIORITY 0
> +#define XE_EXEC_QUEUE_SET_PROPERTY_PRIORITY 0
> #define XE_EXEC_QUEUE_SET_PROPERTY_TIMESLICE 1
> #define XE_EXEC_QUEUE_SET_PROPERTY_PREEMPTION_TIMEOUT 2
> - /*
> - * Long running or ULLS engine mode. DMA fences not allowed in this
> - * mode. Must match the value of DRM_XE_VM_CREATE_COMPUTE_MODE, serves
> - * as a sanity check the UMD knows what it is doing. Can only be set at
> - * engine create time.
> - */
> -#define XE_EXEC_QUEUE_SET_PROPERTY_COMPUTE_MODE 3
> -#define XE_EXEC_QUEUE_SET_PROPERTY_PERSISTENCE 4
> -#define XE_EXEC_QUEUE_SET_PROPERTY_JOB_TIMEOUT 5
> -#define XE_EXEC_QUEUE_SET_PROPERTY_ACC_TRIGGER 6
> -#define XE_EXEC_QUEUE_SET_PROPERTY_ACC_NOTIFY 7
> -#define XE_EXEC_QUEUE_SET_PROPERTY_ACC_GRANULARITY 8
> +#define XE_EXEC_QUEUE_SET_PROPERTY_PERSISTENCE 3
> +#define XE_EXEC_QUEUE_SET_PROPERTY_JOB_TIMEOUT 4
> +#define XE_EXEC_QUEUE_SET_PROPERTY_ACC_TRIGGER 5
> +#define XE_EXEC_QUEUE_SET_PROPERTY_ACC_NOTIFY 6
> +#define XE_EXEC_QUEUE_SET_PROPERTY_ACC_GRANULARITY 7
> /** @property: property to set */
> __u32 property;
>
> /** @value: property value */
> __u64 value;
Mostly a nit, but I had a question about this because I am facing a similar
decision elsewhere. Why do we have one property/value pair in this struct
when all the rest of the property/value pairs are coming in via the
extensions? Basically, how about removing this property/value pair from
thus struct and let all the property/value pairs come in only via
extensions? I think that would both simplify the code a bit and be more
consistent. Thoughts?
Thanks.
--
Ashutosh
next prev parent reply other threads:[~2023-10-17 15:38 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-06 9:59 [Intel-xe] [PATCH v5 00/20] uAPI Alignment - take 1 v5 Francois Dugast
2023-10-06 9:59 ` [Intel-xe] [PATCH v5 01/20] drm/xe: Fix array bounds check for queries Francois Dugast
2023-10-06 9:59 ` [Intel-xe] [PATCH v5 02/20] drm/xe: Set the correct type for xe_to_user_engine_class Francois Dugast
2023-10-06 9:59 ` [Intel-xe] [PATCH v5 03/20] drm/xe: Correlate engine and cpu timestamps with better accuracy Francois Dugast
2023-10-06 9:59 ` [Intel-xe] [PATCH v5 04/20] drm/xe/uapi: Separate VM_BIND's operation and flag Francois Dugast
2023-10-06 9:59 ` [Intel-xe] [PATCH v5 05/20] drm/xe/vm: Remove VM_BIND_OP macro Francois Dugast
2023-10-06 9:59 ` [Intel-xe] [PATCH v5 06/20] drm/xe/uapi: Remove MMIO ioctl Francois Dugast
2023-10-06 9:59 ` [Intel-xe] [PATCH v5 07/20] drm/xe: Fix xe_exec_queue_is_idle for parallel exec queues Francois Dugast
2023-10-06 9:59 ` [Intel-xe] [PATCH v5 08/20] drm/xe: Deprecate XE_EXEC_QUEUE_SET_PROPERTY_COMPUTE_MODE implementation Francois Dugast
2023-10-06 9:59 ` [Intel-xe] [PATCH v5 09/20] drm/xe: Rename exec_queue_kill_compute to xe_vm_remove_compute_exec_queue Francois Dugast
2023-10-06 9:59 ` [Intel-xe] [PATCH v5 10/20] drm/xe: Remove XE_EXEC_QUEUE_SET_PROPERTY_COMPUTE_MODE from uAPI Francois Dugast
2023-10-17 15:37 ` Dixit, Ashutosh [this message]
2023-10-17 16:02 ` Rodrigo Vivi
2023-10-17 16:24 ` Dixit, Ashutosh
2023-10-06 9:59 ` [Intel-xe] [PATCH v5 11/20] drm/xe/uapi: Use common drm_xe_ext_set_property extension Francois Dugast
2023-10-06 9:59 ` [Intel-xe] [PATCH v5 12/20] drm/xe: Kill XE_VM_PROPERTY_BIND_OP_ERROR_CAPTURE_ADDRESS extension Francois Dugast
2023-10-06 9:59 ` [Intel-xe] [PATCH v5 13/20] drm/xe/uapi: Kill DRM_XE_UFENCE_WAIT_VM_ERROR Francois Dugast
2023-10-06 9:59 ` [Intel-xe] [PATCH v5 14/20] drm/xe: Remove async worker and rework sync binds Francois Dugast
2023-10-06 9:59 ` [Intel-xe] [PATCH v5 15/20] drm/xe: Fix VM bind out-sync signaling ordering Francois Dugast
2023-10-06 9:59 ` [Intel-xe] [PATCH v5 16/20] drm/xe/uapi: Document drm_xe_query_gt Francois Dugast
2023-10-06 9:59 ` [Intel-xe] [PATCH v5 17/20] drm/xe/uapi: Replace useless 'instance' per unique gt_id Francois Dugast
2023-10-06 9:59 ` [Intel-xe] [PATCH v5 18/20] drm/xe/uapi: Remove unused field of drm_xe_query_gt Francois Dugast
2023-10-06 9:59 ` [Intel-xe] [PATCH v5 19/20] drm/xe/uapi: Rename gts to gt_list Francois Dugast
2023-10-06 9:59 ` [Intel-xe] [PATCH v5 20/20] drm/xe/uapi: Fix naming of XE_QUERY_CONFIG_MAX_EXEC_QUEUE_PRIORITY Francois Dugast
2023-10-06 12:14 ` [Intel-xe] ✓ CI.Patch_applied: success for uAPI Alignment - take 1 v5 Patchwork
2023-10-06 12:14 ` [Intel-xe] ✗ CI.checkpatch: warning " Patchwork
2023-10-06 12:16 ` [Intel-xe] ✓ CI.KUnit: success " Patchwork
2023-10-06 12:23 ` [Intel-xe] ✓ CI.Build: " Patchwork
2023-10-06 12:23 ` [Intel-xe] ✓ CI.Hooks: " Patchwork
2023-10-06 12:25 ` [Intel-xe] ✓ CI.checksparse: " Patchwork
2023-10-06 13:03 ` [Intel-xe] ✗ CI.BAT: failure " Patchwork
2023-10-17 8:52 ` [Intel-xe] [PATCH v5 00/20] " Francois Dugast
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=871qdtdzuc.wl-ashutosh.dixit@intel.com \
--to=ashutosh.dixit@intel.com \
--cc=francois.dugast@intel.com \
--cc=intel-xe@lists.freedesktop.org \
--cc=rodrigo.vivi@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox